Re: [Toybox] [PATCH] Fix modprobe error handling.

2018-08-04 Thread Rob Landley
On 08/01/2018 02:21 PM, enh wrote: > Bug: https://issuetracker.google.com/112069618 Cool, a public URL! Which turns into a Google login prompt. Which turns into a simultaneous "access denied" and "accept terms of service you haven't read" popups logging in with my gmail account. *shrug* I'm calli

[Toybox] [PATCH] Fix modprobe error handling.

2018-08-01 Thread enh
modprobe was failing if you `modprobe a.ko`, then `modprobe b.ko` where b.ko depends on a.ko --- b.ko will fail to load because a.ko is already loaded. The code to handle this was incorrectly checking `rc` rather than `errno` against EEXIST. (We should pull the insmod.c equivalent of `ins_mod` out