Re: [Toybox] [PATCH] Improve signal name<->number conversions.

2019-06-11 Thread enh via Toybox
okay, i've attached take two, which moves the signal stuff into portability instead... works for me on macOS and Linux. On Mon, Jun 10, 2019 at 3:33 PM Rob Landley wrote: > > On 6/10/19 3:56 PM, enh wrote: > > thanks. > > > > much lower priority for me (and i'm volunteering to fix it), but... >

Re: [Toybox] [PATCH] Improve signal name<->number conversions.

2019-06-10 Thread Rob Landley
On 6/10/19 3:56 PM, enh wrote: > thanks. > > much lower priority for me (and i'm volunteering to fix it), but... > what should i do about the mac here? Sigh, sounds like signames[] needs to move to portability.c. > #if around the > linux-only/mac-only signals (SIGPOLL is linux-only, SIGEMT is >

Re: [Toybox] [PATCH] Improve signal name<->number conversions.

2019-06-10 Thread enh via Toybox
thanks. much lower priority for me (and i'm volunteering to fix it), but... what should i do about the mac here? #if around the linux-only/mac-only signals (SIGPOLL is linux-only, SIGEMT is mac-only, for example). also -- something i didn't know until just now -- it turns out that the mac doesn't

Re: [Toybox] [PATCH] Improve signal name<->number conversions.

2019-06-10 Thread Rob Landley
On 6/10/19 10:23 AM, enh via Toybox wrote: > ping? Applied. > -*- > > i did think of a way we could maybe add a test for the real-time > signals: collect the value from `kill -l SIGRTMAX` and check that > `kill -l SIGRTMAX-1` is `$((sigrtmax - 1))`. (you might think that > SIGRTMIN/SIGRTMAX are

Re: [Toybox] [PATCH] Improve signal name<->number conversions.

2019-06-10 Thread enh via Toybox
ping? -*- i did think of a way we could maybe add a test for the real-time signals: collect the value from `kill -l SIGRTMAX` and check that `kill -l SIGRTMAX-1` is `$((sigrtmax - 1))`. (you might think that SIGRTMIN/SIGRTMAX are constants, but SIGRTMIN varies based on how many real-time signals

[Toybox] [PATCH] Improve signal name<->number conversions.

2019-06-07 Thread enh via Toybox
Include all the signals, not just the POSIX ones. In particular, improve support for real-time signals. My attempt to switch AOSP builds over to toybox timeout got reverted when I broke the ART build bots which use SIGRTMIN+2. Also fix `kill -l 3` to show "QUIT" and `kill -l QUIT` to show "3". A