Re: [Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

On Sat, Feb 10, 2018 at 10:40 AM, Rob Landley wrote: > Ok, trying again at ps -T. > > On 01/24/2018 10:42 AM, enh wrote: >> random example on my laptop: >> >> /tmp/toybox$ ./toybox ps -AT >> ... >> 244083 244083 ? 00:17:32 chrome >> 244083 244084 ? 00:14:38 chrome >> 244083 244085 ?

Re: [Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

Ok, trying again at ps -T. On 01/24/2018 10:42 AM, enh wrote: > random example on my laptop: > > /tmp/toybox$ ./toybox ps -AT > ... > 244083 244083 ? 00:17:32 chrome > 244083 244084 ? 00:14:38 chrome > 244083 244085 ? 00:14:38 chrome > 244083 244086 ? 00:14:38 chrome $ ps -T 2

Re: [Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

On Wed, Jan 24, 2018 at 1:14 PM, Rob Landley wrote: > On 01/24/2018 10:40 AM, enh wrote: >>> You want it to go _back_ to this old behavior, the new one where it >>> matches the other ps is wrong? >> >> having -AT broken breaks bug reports, because ps -AT is part of every >> bug report. i need to r

Re: [Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

On 01/24/2018 10:40 AM, enh wrote: >> You want it to go _back_ to this old behavior, the new one where it >> matches the other ps is wrong? > > having -AT broken breaks bug reports, because ps -AT is part of every > bug report. i need to revert this today, because bug reports must > work. > > hav

Re: [Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

random example on my laptop: /tmp/toybox$ ./toybox ps -AT ... 244083 244083 ? 00:17:32 chrome 244083 244084 ? 00:14:38 chrome 244083 244085 ? 00:14:38 chrome 244083 244086 ? 00:14:38 chrome 244083 244088 ? 00:14:38 chrome 244083 244089 ? 00:14:38 chrome 244083 244090

Re: [Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

On Wed, Jan 24, 2018 at 8:18 AM, Rob Landley wrote: > On 01/23/2018 05:13 PM, enh wrote: >> This reverts commit 416397e14858c75a9bf20d05f7729595e03943df. >> >> Reason: this breaks -AT while not actually fixing the -T PID problem. >> >> Previously just the -T PID case was showing the same informati

Re: [Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

On 01/23/2018 05:13 PM, enh wrote: > This reverts commit 416397e14858c75a9bf20d05f7729595e03943df. > > Reason: this breaks -AT while not actually fixing the -T PID problem. > > Previously just the -T PID case was showing the same information (most > obviously COMMAND) for each thread. With this p

[Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

This reverts commit 416397e14858c75a9bf20d05f7729595e03943df. Reason: this breaks -AT while not actually fixing the -T PID problem. Previously just the -T PID case was showing the same information (most obviously COMMAND) for each thread. With this patch, -AT now has the same bug. --- toys/posi