Well, I've already faced with the couple of issues I can't resolve using
clang-format config:
1. It puts linebreaks to
if (x) foo();
else bar();
statements even though I set AllowShortIfStatementsOnASingleLine to true
and it leaves if statements *without* "else" alon
On 1/25/19 2:26 AM, Reverend Homer wrote:
> Well, I could give clang-format a try and prepare the patchset with its config
> and fixes as an RFC, if Rob doesn't mind.
I'd rather not just now, thanks.
Rob
___
Toybox mailing list
Toybox@lists.landley.net
Well, I could give clang-format a try and prepare the patchset with its config
and fixes as an RFC, if Rob doesn't mind.
R.H.
On 24/01/2019 19:02, enh wrote:
that's what i meant about "you have to learn to give up control over
every last space or tab". many Google and Android projects use
clan
Yeah, that's an option. But AFAICS according to my experience every project
tried to use it had some issues. The latest example I have is systemd:
https://github.com/systemd/systemd/pull/11308
You can look through this PR and see how much trouble it creates.
R.H.
On 23/01/2019 21:07, enh wrot
that's what i meant about "you have to learn to give up control over
every last space or tab". many Google and Android projects use
clang-format, perhaps helped by the fact that no-one really loves
https://google.github.io/styleguide/cppguide.html but everyone has far
better things to do than waste
personally i'd like to have a .clang-format and a git hook to just
canonicalize. it takes a bit of getting used to, giving up the fine
control over every last space and linebreak, but it's remarkably
liberating once you've done it. in projects like that i just run
clang-format every time i save and
Maybe it's worth adding .editorconfig file? Pretty much all editors support it
from the box or have the plugin.
R.H.
On 23/01/2019 05:23, enh via Toybox wrote:
I accidentally added a tab in xargs.c, so as penance I'll clean up all
the tabs.
---
toys/pending/dhcp.c | 2 +-
toys/pending/
I accidentally added a tab in xargs.c, so as penance I'll clean up all
the tabs.
---
toys/pending/dhcp.c | 2 +-
toys/pending/dhcp6.c| 4 ++--
toys/pending/ip.c | 2 +-
toys/pending/mdev.c | 6 +++---
toys/pending/modprobe.c | 15 +++
toys/posix/xargs.c | 2
