On 07/11/2018 12:13 PM, enh wrote:
> (To be clear: I'm not feeding you the answer in pieces... I only know pieces
> of
> the answer. If I knew what the code should look like, I'd send a patch 😁)
Indeed. Trying to research it here myself, but can't during $DAYJOB time.
Rob
___
(To be clear: I'm not feeding you the answer in pieces... I only know
pieces of the answer. If I knew what the code should look like, I'd send a
patch 😁)
On Tue, Jul 10, 2018, 15:56 enh wrote:
> > why/how does ping ::1 work
>
> link-local addresses
> (https://tools.ietf.org/html/rfc4291?referrin
> why/how does ping ::1 work
link-local addresses
(https://tools.ietf.org/html/rfc4291?referring_site=bodynav#section-2.5.6)
are unrelated to the loopback address
(https://tools.ietf.org/html/rfc4291?referring_site=bodynav#section-2.5.3).
ping6 with just -I should not work, but ping6 with just %
On 07/09/2018 04:49 PM, enh wrote:
> On Fri, Jul 6, 2018 at 6:16 PM Rob Landley wrote:
>>
>> On 07/06/2018 03:19 PM, enh wrote:
>>> they said they'd be much more worried about whether we use IP_RECVERR
>>> and parse ICMP errors correctly,
>>
>> I don't think we do but I'll throw it on the todo
On Fri, Jul 6, 2018 at 6:16 PM Rob Landley wrote:
>
> On 07/06/2018 03:19 PM, enh wrote:
> > they said they'd be much more worried about whether we use IP_RECVERR
> > and parse ICMP errors correctly,
>
> I don't think we do but I'll throw it on the todo heap. I'm not 100% sure what
> "correctly" m
On 07/06/2018 03:19 PM, enh wrote:
> they said they'd be much more worried about whether we use IP_RECVERR
> and parse ICMP errors correctly,
I don't think we do but I'll throw it on the todo heap. I'm not 100% sure what
"correctly" means here, but I can try to research it.
> or do link-local pin
the networking folks said it probably doesn't matter. they did point
out that it's a lot easier to implement the toybox behavior with the
iputils ping than vice versa.
they said they'd be much more worried about whether we use IP_RECVERR
and parse ICMP errors correctly, or do link-local ping corre
On 06/14/2018 06:11 PM, enh wrote:
> This matches iputils and busybox.
I couldn't figure out what their -q was for. Those are printing the header and
footer text so not "quiet", and it's continuing to ping after confirming the
site is up so it's not "quick". The one I implemented is both quick and
This matches iputils and busybox.
---
toys/net/ping.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
From c9c6dfe0542fd962dc0706935f1e39d8e5d5364e Mon Sep 17 00:00:00 2001
From: Elliott Hughes
Date: Thu, 14 Jun 2018 16:08:32 -0700
Subject: [PATCH] ping: fix -q behavior.
