Re: [Toybox] [PATCH] setsid(1): call setsid(2) before setpgrp(2).

2021-04-20 Thread Rob Landley
On 4/20/21 5:37 AM, Yi-yo Chiang wrote: > Interesting. Probably because our previous for-loop takes input from regular > file. The GNU implementationĀ seems to treat only special files (block and char > devices) differently as a "magnetic tape". Ah. The test infrastructure is already doing echo ""

Re: [Toybox] [PATCH] setsid(1): call setsid(2) before setpgrp(2).

2021-04-20 Thread Yi-yo Chiang via Toybox
Interesting. Probably because our previous for-loop takes input from regular file. The GNU implementation seems to treat only special files (block and char devices) differently as a "magnetic tape". On Tue, Apr 20, 2021 at 5:33 PM Rob Landley wrote: > On 4/20/21 3:23 AM, Yi-yo Chiang via Toybox

Re: [Toybox] [PATCH] setsid(1): call setsid(2) before setpgrp(2).

2021-04-20 Thread Rob Landley
On 4/20/21 3:23 AM, Yi-yo Chiang via Toybox wrote: > Why do we need setsid in the new cpio testcase though? Because without it TEST_HOST=1 calls the gnu/dammit cpio which does: $ cpio -i < /dev/null Found end of tape. To continue, type device/file name when ready. And then hangs waiting for

Re: [Toybox] [PATCH] setsid(1): call setsid(2) before setpgrp(2).

2021-04-20 Thread Yi-yo Chiang via Toybox
Why do we need setsid in the new cpio testcase though? On Tue, Apr 20, 2021 at 3:50 AM enh via Toybox wrote: > The new cpio test that uses setsid fails if you're using the toybox > setsid. Move the setpgrp() call before the vfork() but after the > setsid(). > --- > toys/other/setsid.c | 9 +

[Toybox] [PATCH] setsid(1): call setsid(2) before setpgrp(2).

2021-04-19 Thread enh via Toybox
The new cpio test that uses setsid fails if you're using the toybox setsid. Move the setpgrp() call before the vfork() but after the setsid(). --- toys/other/setsid.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) From ef4fa9e1ee6cc24eec7a74eadc4a08eaf347 Mon Sep 17 00:00:00 20