Re: [Toybox] [PATCH] vi.c: added v command, updated help text, Fixed memory leak in 'g' command

2023-10-17 Thread Oliver Webb via Toybox
--- Original Message --- On Tuesday, October 17th, 2023 at 04:42, Rob Landley wrote: > On 10/16/23 22:29, Oliver Webb wrote: > > > > I was hoping to get stuff to share code, but I can worry about that in the > > > eventual cleanup pass. > > > > If you are planning on code-sharing the

Re: [Toybox] [PATCH] vi.c: added v command, updated help text, Fixed memory leak in 'g' command

2023-10-17 Thread Rob Landley
On 10/16/23 22:29, Oliver Webb wrote: >> I was hoping to get stuff to share code, but I can worry about that in the >> eventual cleanup pass. > > If you are planning on code-sharing the regex line substitution stuff. > Then this will probably be my last patch to vi.c for a while > (Unless there

Re: [Toybox] [PATCH] vi.c: added v command, updated help text, Fixed memory leak in 'g' command

2023-10-16 Thread Oliver Webb via Toybox
--- Original Message --- On Monday, October 16th, 2023 at 04:21, Rob Landley wrote: > On 10/14/23 17:15, Oliver Webb via Toybox wrote: > > > I have added the 'v' command (Which is essentially the opposite of the > > g[lobal] command). > > Fixed a memory leak in the g[lobal] command

Re: [Toybox] [PATCH] vi.c: added v command, updated help text, Fixed memory leak in 'g' command

2023-10-16 Thread Rob Landley
On 10/14/23 17:15, Oliver Webb via Toybox wrote: > I have added the 'v' command (Which is essentially the opposite of the > g[lobal] command). > Fixed a memory leak in the g[lobal] command (Freeing data while aborting) > Along with some code formatting (Replacing *(cmd+1) with cmd[1]) I removed

[Toybox] [PATCH] vi.c: added v command, updated help text, Fixed memory leak in 'g' command

2023-10-14 Thread Oliver Webb via Toybox
I have added the 'v' command (Which is essentially the opposite of the g[lobal] command). Fixed a memory leak in the g[lobal] command (Freeing data while aborting) Along with some code formatting (Replacing *(cmd+1) with cmd[1]) I have been trying to get a implementation of the s[ubsitute]