Re: [Toybox] bc power fix 2

2019-06-21 Thread Gavin Howard
Attached is the patch to fix the test suite. That is 01.patch. > there's a different top-level runner, but it's basically just an old > version of your tests (as can be seen from my diff --- that's from > doing a cp of the power*.txt files from your upstream ToT over the > toybox ones). my questio

Re: [Toybox] bc power fix 2

2019-06-21 Thread enh via Toybox
there's a different top-level runner, but it's basically just an old version of your tests (as can be seen from my diff --- that's from doing a cp of the power*.txt files from your upstream ToT over the toybox ones). my question is whether you're happy to dual-license ToT or just the exact drops fr

Re: [Toybox] bc power fix 2

2019-06-21 Thread Rob Landley
The only change to the bc tests since your commit 1ee1c71e9dbc was: commit 1201a665bfa6295ef9c0fd2b1a6476e0f0f5d0ac Author: Elliott Hughes Date: Thu Mar 28 12:11:22 2019 -0700 bc: add a trivial regression test for input from stdin. A trivial test, but it would have caught the previous

Re: [Toybox] bc power fix 2

2019-06-21 Thread Gavin Howard
Landley has created his own version of my test suite; I do not know what he has done. Gavin Howard On Thu, Jun 20, 2019 at 11:42 PM enh wrote: > > this breaks the power tests. did you mean to update them to the > current upstream ones, as in the attached patch? (it's not clear to me > whether th

Re: [Toybox] bc power fix 2

2019-06-20 Thread enh via Toybox
this breaks the power tests. did you mean to update them to the current upstream ones, as in the attached patch? (it's not clear to me whether the tests in toybox are forked because they're 0BSD in toybox but not upstream?) On Tue, Jun 11, 2019 at 7:09 PM Gavin Howard wrote: > > I accidentally pu

[Toybox] bc power fix 2

2019-06-11 Thread Gavin Howard
I accidentally put the error check into the wrong if statement... Gavin Howard From 487eff77b970cf940893dd49bdcd8e29d0423df6 Mon Sep 17 00:00:00 2001 From: Gavin Howard Date: Tue, 11 Jun 2019 20:07:43 -0600 Subject: [PATCH] bc: fix previous patch I put the check into the wrong if. That was my ba