[Toybox] [PATCH] Fix file.c build and fix sense of fstat test.

2016-02-29 Thread enh
--- toys/pending/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) From 2c386cc024a22cb890b12a69d6c2dab48a1375ef Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 29 Feb 2016 07:46:12 -0800 Subject: [PATCH] Fix file.c build and fix sense of fstat test. --- toys/pending/fil

Re: [Toybox] [PATCH] Distinguish 32- and 64-bit variants in file(1) for x32.

2016-02-29 Thread enh
On Sun, Feb 28, 2016 at 9:44 AM, Rob Landley wrote: > On 02/28/2016 09:48 AM, enh wrote: >> On Sat, Feb 27, 2016 at 10:51 PM, Rob Landley wrote: >>> Newly introduced platforms tend to have EM_MANUFACTURER_ARCH and then >>> later switch it to EM_ARCH. Here

[Toybox] [PATCH] Fix trailing spaces on ps -o cmdline.

2016-02-29 Thread enh
--- toys/posix/ps.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) From 7b3f113f4c172c30f4905793be64791b2a8e3a1e Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 29 Feb 2016 10:34:07 -0800 Subject: [PATCH] Fix trailing spaces on ps -o cmdline. --- toys/posix/ps.c | 5 +++--

Re: [Toybox] [PATCH] Fix file.c build and fix sense of fstat test.

2016-02-29 Thread enh
; > $ file /usr/lib/firefox/firefox.sh > /usr/lib/firefox/firefox.sh: POSIX shell script, ASCII text executable > > According to posix that should reply "commands text". Once again, posix > is completely ignored in practice. > > Sigh, > > Rob -- Elliott Hughes

[Toybox] [PATCH] Fix file for Java class files, improve script detection, and add tests.

2016-02-29 Thread enh
--- tests/file.test | 21 + toys/pending/file.c | 5 - 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 tests/file.test From 04562ab2b0969ed8298d04940521875a976f219f Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 29 Feb 2016 19:35:13 -080

Re: [Toybox] [PATCH] include sys/sysmacros.h

2016-02-29 Thread enh
ysmacros.h at all. The set of programs that have any use for > these macros is basically ls, mknod, and archivers (tar, cpio, etc.) > that support archiving device nodes, and these programs can just > include the appropriate header to get them. > > Rich > ___

Re: [Toybox] [PATCH] Fix file.c build and fix sense of fstat test.

2016-02-29 Thread enh
i think you want this patch rather than the one you committed (c1161cf09f5d9646b0e0c6ec504ed26a0623e691) --- doesn't yours leak fd? On Mon, Feb 29, 2016 at 4:25 PM, enh wrote: > what's checked in now still doesn't work in the regular file case though... > > > Subjec

Re: [Toybox] [PATCH] Fix "make help" again.

2016-03-01 Thread enh
ping. On Sat, Feb 27, 2016 at 1:29 PM, enh wrote: > Same missing quote at end of line as last time. The new additions to > the help are very useful though. > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) -- Elliott Hughes - http://who/enh - http://j

Re: [Toybox] [PATCH] Use the correct types for recvfrom.

2016-03-01 Thread enh
ping. On Wed, Feb 24, 2016 at 9:37 PM, enh wrote: > (sending on behalf of the actual author; i've edited the attached > patch so the from line has his details rather than mine.) > > > The clang FORITFY implementation doesn't like pointer signedness mismatch. > &qu

Re: [Toybox] [PATCH] Use the correct types for recvfrom.

2016-03-01 Thread enh
No worries. Is it easier to keep track of things if I use github pull requests? On Mar 1, 2016 7:16 PM, "Rob Landley" wrote: > On Tue, Mar 1, 2016 at 9:08 PM, enh wrote: > > ping. > > Both applied, sorry for the delay. > > Rob >

Re: [Toybox] [PATCH] Use the correct types for recvfrom.

2016-03-01 Thread enh
ng commands...) On Mar 1, 2016 7:18 PM, "enh" wrote: > No worries. Is it easier to keep track of things if I use github pull > requests? > On Mar 1, 2016 7:16 PM, "Rob Landley" wrote: > >> On Tue, Mar 1, 2016 at 9:08 PM, enh

Re: [Toybox] [PATCH] Fix file.c build and fix sense of fstat test.

2016-03-01 Thread enh
since you seem to be around right now... ping on this too. On Mon, Feb 29, 2016 at 10:22 PM, Rob Landley wrote: > Sigh. I am juggling too many things the past couple days. > > Rob > > On 02/29/2016 11:50 PM, enh wrote: >> i think you want this patch rather than

Re: [Toybox] [PATCH] Fix file for Java class files, improve script detection, and add tests.

2016-03-01 Thread enh
...and ping on this, the tests part of which should put an end to the current continual file(1) breakage. On Mon, Feb 29, 2016 at 7:37 PM, enh wrote: > --- > tests/file.test | 21 + > toys/pending/file.c | 5 - > 2 files changed, 25 insertions(+)

[Toybox] [PATCH] Fix ulimit parsing of "unlimited".

2016-03-02 Thread enh
POSIX says nothing about how to specify no limit, but the ulimits I've known all take the same "unlimited" as input that they (and POSIX) use as output. --- toys/posix/ulimit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From d147837b9c0e33aee65a5a1ea5657dbcc3a4b0b0 Mon Sep 17 00:00:00 2

[Toybox] [PATCH] Fix the potential fd leak in file(1).

2016-03-03 Thread enh
This avoids duplicating the xputs call, which I assume was the sticking point with my previous suggestion. Also remove the now-duplicated command name in the tests, and add a couple more tests. --- tests/file.test | 23 --- toys/pending/file.c | 10 +- 2 files chan

Re: [Toybox] [PATCH] Fix ulimit parsing of "unlimited".

2016-03-04 Thread enh
ping. (i'd like to kill Android's prlimit this week, and even if "-p" is a toybox extension i'd like to use the same "unlimited" as everyone else rather than the current "idiosyncratic" or "illuminati" or whatever it was you had in mind :-)

[Toybox] [PATCH] toolbox prlimit is no more.

2016-03-07 Thread enh
Replaced by toybox ulimit -p. --- www/roadmap.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) From c1fd385c42e0219ba74c68b0e8b454d9f9dcc5d6 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 7 Mar 2016 14:51:10 -0800 Subject: [PATCH] toolbox prlimit is no more. Replaced by

Re: [Toybox] Toybox test image / fuzzing

2016-03-13 Thread enh
t because it's >> sorted by pid, which wraps, so if your ps pid is lower than your bash >> pid it would come first. Oh, and there's no guarantee the shell you're >> running is "bash" unless you're in a controlled environment... That's >> just t

[Toybox] non-GPLv3 mtools?

2016-03-14 Thread enh
EFI specification and its associate reference documents is the only definition of FAT that needs to be implemented to support EFI. To differentiate the EFI file system from pure FAT, a new partition file system type has been defined.") but FAT-ish. -- Elliott Hughes - http://who/enh - http://je

Re: [Toybox] non-GPLv3 mtools?

2016-03-15 Thread enh
On Mon, Mar 14, 2016 at 10:05 PM, Rob Landley wrote: > On 03/14/2016 10:36 PM, enh wrote: >> a non-GPLv3 mtools would be nice for UEFI purposes. > > That's on my todo list, and actually not that hard. I could bump it up, > it was just post 1.0 because it's not in

Re: [Toybox] [PATCH] Fix "tail -f single_file".

2016-03-18 Thread enh
> part. > > Patch attached. > > ___ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net > -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/

[Toybox] [PATCH] Add od -w.

2016-03-18 Thread enh
I'm not an od user myself, but I copy & pasted an 'od' invocation from a bug and it didn't work. Which was embarrassing because I'd just claimed that the od user didn't need to run od on their desktop (as they had done) and could have run it on the device instead... --- toys/posix/od.c | 34 ++

[Toybox] [PATCH] lsof should use CFG_TOYBOX_FREE, not CFG_FREE.

2016-03-18 Thread enh
--- toys/pending/lsof.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From f788f5a018dade6c14a183c5586408ae5bf2cab2 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 18 Mar 2016 20:21:33 -0700 Subject: [PATCH] lsof should use CFG_TOYBOX_FREE, not CFG_FREE. --- toys/pending/lsof.c

Re: [Toybox] [PATCH] Use the correct types for recvfrom.

2016-03-18 Thread enh
On Fri, Mar 4, 2016 at 2:28 PM, Rob Landley wrote: > On 03/01/2016 09:18 PM, enh wrote: >> No worries. Is it easier to keep track of things if I use github pull >> requests? > > Not really. That's not the problem. > > Right now I'm trying to figure out how to

Re: [Toybox] [PATCH] Use the correct types for recvfrom.

2016-03-19 Thread enh
On Sat, Mar 19, 2016 at 7:56 AM, Rob Landley wrote: > > > On 03/18/2016 10:31 PM, enh wrote: >> On Fri, Mar 4, 2016 at 2:28 PM, Rob Landley wrote: > ... >>> My pending cleanup of lsof needs to address the fact it takes 18 seconds >>> to produce its first line

Re: [Toybox] [PATCH] lsof should use CFG_TOYBOX_FREE, not CFG_FREE.

2016-03-19 Thread enh
(i've rolled this into the 10x faster patch, since this code changes more drastically there.) On Fri, Mar 18, 2016 at 8:22 PM, enh wrote: > --- > toys/pending/lsof.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) -- Elliott Hughes - http://who/enh - http://jessies.org

[Toybox] [PATCH] Make lsof 10x faster by caching /proc/net socket info.

2016-03-19 Thread enh
I deliberately didn't do this first time round because for me our lsof is already 10x faster than traditional lsof, and caching means we potentially give less information about a socket that's created while we're running. It turns out that traditional lsof caches anyway, so I guess nobody cares. T

Re: [Toybox] testing / branching (was Re: [PATCH] Fix the operator precedence in expr.)

2016-03-19 Thread enh
-1.0 roadmap is implementing enough of > my own (0BSD-licensed) git implementation to drive repo in the AOSP > build. (You saw the 2013 ELC talk linked from the left edge of the > toybox page? Making Android a self-hosting development environment? > There are still missing toolchain

Re: [Toybox] [PATCH] Add od -w.

2016-03-23 Thread enh
ping. On Fri, Mar 18, 2016 at 8:15 PM, enh wrote: > I'm not an od user myself, but I copy & pasted an 'od' invocation from a bug > and it didn't work. Which was embarrassing because I'd just claimed that the > od user didn't need to run od on their desk

Re: [Toybox] [PATCH] toolbox prlimit is no more.

2016-03-23 Thread enh
ping. On Mon, Mar 7, 2016 at 2:52 PM, enh wrote: > Replaced by toybox ulimit -p. > --- > www/roadmap.html | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/dr

[Toybox] [PATCH] Fix build when wchar_t is unsigned.

2016-03-26 Thread enh
external/toybox/lib/linestack.c:84:5: error: conflicting types for 'crunch_str' int crunch_str(char **str, int width, FILE *out, char *escmore, ^ external/toybox/lib/lib.h:228:5: note: previous declaration is here int crunch_str(char **str, int width, FILE *out, char *escmore, ^

Re: [Toybox] [PATCH] Fix build when wchar_t is unsigned.

2016-03-28 Thread enh
ping. can't upgrade without this. if you actually want to go the wchar_t route, let me know and i'll prepare that patch. i just assumed you'd be more likely to go this way. On Sat, Mar 26, 2016 at 11:00 AM, enh wrote: > external/toybox/lib/linestack.c:84:5: error: con

Re: [Toybox] [PATCH] Implement mv -n / cp -n (no clobber).

2016-04-15 Thread enh
ind dozens of bugs > in there if I were to have continued on my path with the test harness. > > I was planning to add a whole bunch of tests, clean things up, and do > stuff like make tests a subprocess and define the test environment as > we discussed. But I don't mind that I got

Re: [Toybox] And back.

2016-04-15 Thread enh
Back in 2006 I printed out the Advanced Bash Scripting guide and made it > about 1/3 of the way through it on various bus rides. I have the problem > reasonably scoped, but am doing a variant of "shortest job first" > scheduling by leaving the really nasty ones for last unless somet

Re: [Toybox] [PATCH] Implement mv -n / cp -n (no clobber).

2016-04-15 Thread enh
On Fri, Apr 15, 2016 at 12:40 PM, Andy Chu wrote: > On Fri, Apr 15, 2016 at 10:16 AM, enh wrote: >> things to avoid/reasons why i'd happily get rid of mksh in Android: > > OK interesting -- can you say more about the use cases of shell and > toybox in Android? > >

Re: [Toybox] [PATCH] Implement mv -n / cp -n (no clobber).

2016-04-15 Thread enh
On Fri, Apr 15, 2016 at 3:48 PM, Andy Chu wrote: > On Fri, Apr 15, 2016 at 1:51 PM, enh wrote: >> On Fri, Apr 15, 2016 at 12:40 PM, Andy Chu wrote: >>> On Fri, Apr 15, 2016 at 10:16 AM, enh wrote: >>>> things to avoid/reasons why i'd happily get rid of mksh

[Toybox] [PATCH] Fix top -b.

2016-04-15 Thread enh
Batch mode should never output terminal escape sequences, should ignore the keyboard, and should include a gap between datasets. --- toys/posix/ps.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) From 086f59ce1e196e459c6896b11abdbda8a5f2ca85 Mon Sep 17 00:00:00 2001 From: Elli

[Toybox] [PATCH] Fix "ssh top".

2016-04-15 Thread enh
The ps.c change allows us to start. The interestingtimes.c change allows us to clean up properly afterwards if you ^C out (which you usually do). Tested with both ssh and "adb shell" (the latter being where I noticed the problem). --- lib/interestingtimes.c | 2 +- toys/posix/ps.c| 2 +-

[Toybox] [PATCH] Fix tail -NUM again.

2016-04-16 Thread enh
This time with a test. --- tests/tail.test | 1 + toys/posix/tail.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) From 0ffc6f5afb4a0293cabab97de7000a4260c08270 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Sat, 16 Apr 2016 08:19:23 -0700 Subject: [PATCH] Fix tail -NUM again

[Toybox] ps and top (and Android)

2016-04-20 Thread enh
re: https://github.com/landley/toybox/commit/529d5db29a32db565d2ee0aeac133e47ec045e12, note that we're not switched over because neither ps nor top have thread support. everything on Android is threaded except init, so people would notice :-) there are a bunch of little things too that i can send

[Toybox] [PATCH] Fix more to a non-tty.

2016-04-21 Thread enh
And add a test. --- toys/pending/more.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From 984fc8bb249970845b342e2f0bdc07a97804bf77 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Thu, 21 Apr 2016 17:41:40 -0700 Subject: [PATCH] Fix more to a non-tty. And add a test. --- toys/pendin

[Toybox] [PATCH] Fix more to not append an extra newline.

2016-04-21 Thread enh
More's sigatexit handler needs to distinguish between normal exit and exit due to receipt of a signal. Change tty_sigreset to look at the signal number too, so that pressing 'q' to exit top doesn't cause its exit status to be 128. --- lib/interestingtimes.c | 2 +- lib/xwrap.c| 4 +++-

Re: [Toybox] ps and top (and Android)

2016-04-21 Thread enh
On Thu, Apr 21, 2016 at 1:06 AM, Rob Landley wrote: > On 04/20/2016 08:47 PM, enh wrote: >> re: >> https://github.com/landley/toybox/commit/529d5db29a32db565d2ee0aeac133e47ec045e12, >> note that we're not switched over because neither ps nor top have >> thread s

Re: [Toybox] ps and top (and Android)

2016-04-23 Thread enh
On Sat, Apr 23, 2016 at 3:06 AM, Rob Landley wrote: > On 04/21/2016 08:59 PM, enh wrote: >> On Thu, Apr 21, 2016 at 1:06 AM, Rob Landley wrote: >>> On 04/20/2016 08:47 PM, enh wrote: >>>> re: >>>> https://github.com/landley/toybox/commit/529d5db29a32db

Re: [Toybox] ps and top (and Android)

2016-04-23 Thread enh
On Sat, Apr 23, 2016 at 3:06 AM, Rob Landley wrote: > On 04/21/2016 08:59 PM, enh wrote: >> On Thu, Apr 21, 2016 at 1:06 AM, Rob Landley wrote: >>> On 04/20/2016 08:47 PM, enh wrote: >>>> re: >>>> https://github.com/landley/toybox/commit/529d5db29a32db

[Toybox] [PATCH] Add the non-tty more(1) test.

2016-04-23 Thread enh
(This was supposed to be in the earlier patch, but I was fooled by "git commit -a" yet again...) --- tests/more.test | 14 ++ 1 file changed, 14 insertions(+) create mode 100755 tests/more.test From 8486532a9e1aca764ab8292d7538538d4c0ea226 Mon Sep 17 00:00:00 2001 From: Elliott Hughes

Re: [Toybox] [PATCH] Fix more to a non-tty.

2016-04-23 Thread enh
On Sat, Apr 23, 2016 at 12:39 PM, Rob Landley wrote: > On 04/21/2016 07:42 PM, enh wrote: >> And add a test. >> --- >> toys/pending/more.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, but I don't see the test? d'oh. fooled by

Re: [Toybox] [PATCH] Fix more to a non-tty.

2016-04-23 Thread enh
yeah, i'm pretty sure 100% of our more(1) users are using because we don't have less. the sad part is that Android might be creating more more(1) users because we're retraining their muscle memory :-) On Sat, Apr 23, 2016 at 3:04 PM, dmccunney wrote: > On Sat, Apr 23, 2016 at 5

Re: [Toybox] ps and top (and Android)

2016-04-24 Thread enh
On Sat, Apr 23, 2016 at 11:53 PM, Isaac Dunham wrote: > On Sat, Apr 23, 2016 at 09:57:12AM -0700, enh wrote: >> On Sat, Apr 23, 2016 at 3:06 AM, Rob Landley wrote: >> > Non-pending commands _not_ included in the build: >> > >> > $ make list_working | tr '

Re: [Toybox] [PATCH] Fix more to a non-tty.

2016-04-24 Thread enh
On Sat, Apr 23, 2016 at 8:41 PM, Rob Landley wrote: > On 04/23/2016 04:40 PM, enh wrote: >> On Sat, Apr 23, 2016 at 12:39 PM, Rob Landley wrote: >>> On 04/21/2016 07:42 PM, enh wrote: >>>> And add a test. >>>> --- >>>> toys/pending/more.c |

Re: [Toybox] Et tu, Google Plus? (Mount bugs.)

2016-04-28 Thread enh
every time. > ___ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail m

Re: [Toybox] Et tu, Google Plus? (Mount bugs.)

2016-04-28 Thread enh
On Thu, Apr 28, 2016 at 10:31 PM, Rob Landley wrote: > On 04/28/2016 11:44 PM, enh wrote: >> yeah, not sure why that guy just whined to himself rather than >> reporting a bug to either Android or toybox. maybe he's one of those >> people who thinks that _is_

Re: [Toybox] Curious (cyanogenmod).

2016-04-29 Thread enh
ttp://lists.landley.net/listinfo.cgi/toybox-landley.net > > > ___________ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://who/enh - http://jessies

Re: [Toybox] ps and top (and Android)

2016-04-29 Thread enh
t through my old notes and i think everything else is now done. i'll get AOSP synced this afternoon (must be friday again!) and send you a patch for the scheduling policy names. On Mon, Apr 25, 2016 at 11:59 PM, Rob Landley wrote: > On 04/23/2016 11:13 AM, enh wrote: >> On Sat, Apr 2

Re: [Toybox] ps and top (and Android)

2016-04-29 Thread enh
On Fri, Apr 29, 2016 at 5:45 PM, Rob Landley wrote: > On 04/29/2016 04:06 PM, enh wrote: >> sorry, hadn't had time to look until now. notes: >> >> * the tid column seems very wrong. in particular, i see a lot of >> duplicate tids. ah, the pid/tid columns don

Re: [Toybox] date test failures

2016-04-29 Thread enh
t code for the error reporting case, it might be > slightly slower but it's not going to be bigger.) > > And while we're at it, bracket if (flag) setenv() and if (flag) clearenv > around the caller lets us collapse to only one caller so we can inline it... > > Rob > __

Re: [Toybox] ps and top (and Android)

2016-04-30 Thread enh
On Fri, Apr 29, 2016 at 6:06 PM, enh wrote: > On Fri, Apr 29, 2016 at 5:45 PM, Rob Landley wrote: >> On 04/29/2016 04:06 PM, enh wrote: >>> sorry, hadn't had time to look until now. notes: >>> >>> * the tid column seems very wrong. in particular, i see

Re: [Toybox] ps and top (and Android)

2016-04-30 Thread enh
to find problems before they find me i did find a couple of uses in the tree of GNU ps' --no-headers option. obviously they're in scripts meant for the host, but i thought you might be interested anyway. On Sat, Apr 30, 2016 at 9:50 AM, enh wrote: > On Fri, Apr 29, 2016 at 6:06 PM, enh

[Toybox] ps -T -o name

2016-05-04 Thread enh
((toys.optflags&FLAG_T) || (TT.bits&(_PS_TID|_PS_TCNT))) ? get_threads : get_ps); ? -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. ___ To

Re: [Toybox] ps -T -o name

2016-05-04 Thread enh
On Wed, May 4, 2016 at 4:44 PM, Rob Landley wrote: > > > On 05/04/2016 03:55 PM, enh wrote: >> seems like a bug that if you use -o but don't include 'tid', -T becomes a >> no-op? >> >> ps -A -T | wc -l >> ps -A -T -o name | wc -l >

[Toybox] [PATCH] "top -b -n1" should end with a newline.

2016-05-04 Thread enh
The use of TT.time to determine whether to use \r or \n is a little odd, but let's stick with that for now. Correct the spelling of millitime and add a test. --- tests/top.test | 7 +++ toys/posix/ps.c | 17 +++-- 2 files changed, 14 insertions(+), 10 deletions(-) create mode 10

[Toybox] [PATCH] Android roadmap update.

2016-05-05 Thread enh
I removed iftop a while back but didn't remove it everywhere in the documentation. I switched over to toybox ps yesterday. --- www/roadmap.html | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) From 387c062c863e9e80af9b3b062957117100ec6d06 Mon Sep 17 00:00:00 2001 From: Elliott Hugh

[Toybox] [PATCH] Add top -H.

2016-05-05 Thread enh
Also enable the same behavior we have with ps, where adding a thread-related field implies that you're interested in threads. Also clean up the help text slightly --- we're still not including the TOP_COMMON help, but at least when we do, we'll have each option covered with no duplicates. --- toy

[Toybox] imgtec patch: Fix static linkage of toybox binary.

2016-05-05 Thread enh
aste (from the top-right in the gerrit UI) is: git fetch https://android.googlesource.com/platform/external/toybox refs/changes/60/223060/1 && git cherry-pick FETCH_HEAD -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by

Re: [Toybox] [PATCH] Android roadmap update.

2016-05-06 Thread enh
On Thu, May 5, 2016 at 8:04 PM, Rob Landley wrote: > On 05/05/2016 11:25 AM, enh wrote: >> I removed iftop a while back but didn't remove it everywhere in the >> documentation. I switched over to toybox ps yesterday. > > Yay! > >> --- >> www/roadmap.h

[Toybox] ps down, top to go

2016-05-06 Thread enh
tation of one of the existing ones. thoughts? (if you want a stand-alone C pthread test .c file let me know, but if you're running chrome, you can see this even with toybox ps -A -T --- chrome has plenty of threads.) -- Elliott Hughes - http://who/enh - http://jes

Re: [Toybox] imgtec patch: Fix static linkage of toybox binary.

2016-05-06 Thread enh
On Thu, May 5, 2016 at 8:15 PM, Rob Landley wrote: > On 05/05/2016 06:21 PM, enh wrote: >> imgtec sent us https://android-review.googlesource.com/#/c/223060/ >> >> Fix static linkage of toybox binary. >> >> If toybox was compiled statically e.g. for use in a

Re: [Toybox] [PATCH] Android roadmap update.

2016-05-06 Thread enh
On Fri, May 6, 2016 at 5:04 PM, Rob Landley wrote: > On 05/06/2016 11:25 AM, enh wrote: >> On Thu, May 5, 2016 at 8:04 PM, Rob Landley wrote: >>> On 05/05/2016 11:25 AM, enh wrote: >>>> I removed iftop a while back but didn't remove it everywhere in the >

Re: [Toybox] ps down, top to go

2016-05-06 Thread enh
On Fri, May 6, 2016 at 6:01 PM, Rob Landley wrote: > On 05/06/2016 01:58 PM, enh wrote: >> in case you're wondering why i sent the roadmap update saying i'd >> switched to toybox ps although the ps pid/tid truncation bug i found >> hasn't been fixed, it's

Re: [Toybox] imgtec patch: Fix static linkage of toybox binary.

2016-05-06 Thread enh
On Fri, May 6, 2016 at 5:12 PM, Rob Landley wrote: > On 05/06/2016 02:56 PM, enh wrote: >> On Thu, May 5, 2016 at 8:15 PM, Rob Landley wrote: >>> Applied, and that fetch+cherry-pick thing _also_ seems to avoid a >>> gratuitous merge commit, which is very nice. >&

Re: [Toybox] ps down, top to go

2016-05-06 Thread enh
On Fri, May 6, 2016 at 9:11 PM, Rob Landley wrote: > On 05/06/2016 08:34 PM, enh wrote: >> On Fri, May 6, 2016 at 6:01 PM, Rob Landley wrote: >>>> 1794 1806 u0_a11 20 0 0% S 1502820K 54016K fg Binder_1 >>>> com.android.onetimeinitializer >&g

Re: [Toybox] imgtec patch: Fix static linkage of toybox binary.

2016-05-07 Thread enh
So it checks how much stack we've used as a simple > heuristic to see whether we should recurse or should exec. > > This heuristic has not been particularly tuned, that's one of my toysh > todo items. (toysh is likely to be the heaviest user.) >

Re: [Toybox] ps down, top to go

2016-05-09 Thread enh
On Mon, May 9, 2016 at 4:47 PM, Rob Landley wrote: > > > On 05/06/2016 11:49 PM, enh wrote: >> On Fri, May 6, 2016 at 9:11 PM, Rob Landley wrote: >>> On 05/06/2016 08:34 PM, enh wrote: >>>> On Fri, May 6, 2016 at 6:01 PM, Rob Landley wrote: >>>&g

Re: [Toybox] ps down, top to go

2016-05-09 Thread enh
On Mon, May 9, 2016 at 5:28 PM, enh wrote: > On Mon, May 9, 2016 at 4:47 PM, Rob Landley wrote: >> >> >> On 05/06/2016 11:49 PM, enh wrote: >>> On Fri, May 6, 2016 at 9:11 PM, Rob Landley wrote: >>>> On 05/06/2016 08:34 PM, enh wrote: >>>&g

Re: [Toybox] imgtec patch: Fix static linkage of toybox binary.

2016-05-09 Thread enh
; > If not, lib/portability.* is the place #ifdef THINGY && THINGY code > blocks for envrionment-specific stuff. i think YAGNI... anyone running SafeStack is probably LP64 and probably better off just using NORECURSE (with the small fix to not maintain toys.stacktop). > Rob

Re: [Toybox] imgtec patch: Fix static linkage of toybox binary.

2016-05-10 Thread enh
On Tue, May 10, 2016 at 1:13 AM, Rob Landley wrote: > > > On 05/10/2016 12:28 AM, enh wrote: >> On Mon, May 9, 2016 at 8:45 PM, Rob Landley wrote: >>> On 05/09/2016 04:43 PM, Evgenii Stepanov wrote: >>>> Now, if we want to really preserve this check logic unde

Re: [Toybox] New Toy: toys/android/runconuid

2016-05-20 Thread enh
directly to toys/android or to toys/pending >> - Appropriate mechanism for submitting patches > > Any follow-up on this? > > Would you like to submit the patch to the list? > > Rob > ___ > Toybox mailing list > Toybox@lists.la

Re: [Toybox] ps down, top to go

2016-05-20 Thread enh
On Fri, May 20, 2016 at 2:30 PM, Rob Landley wrote: > Now that I've dealt with the "ps -A not working after building top" bug, > being sick for a week due to travel, and catching up on the $DAYJOB > backlog thereof... > > On 05/09/2016 07:46 PM, enh wrote: >>

Re: [Toybox] ps down, top to go

2016-05-21 Thread enh
On Fri, May 20, 2016 at 3:37 PM, Rob Landley wrote: > On 05/20/2016 04:57 PM, enh wrote: >> On Fri, May 20, 2016 at 2:30 PM, Rob Landley wrote: >>> Threads have nothing in /proc/$$/cmdline, so command and friends have >>> nothing to show and fall back to showing ker

[Toybox] [PATCH] Fix pkill -9.

2016-05-23 Thread enh
This fixes the existing test. Internal Android bug 28877702. I've left -l as-is, even though the desktop doesn't support that. --- toys/posix/ps.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) From 8f73c19013098a3809e44f645fbe0d9e2e94ac0d Mon Sep 17 00:00:00 2001 From: Elliott Hu

[Toybox] [PATCH] Fix remaining pkill tests.

2016-05-23 Thread enh
I don't know that anyone cares, but these failures made me think I'd broken something while testing the -SIGNAL patch. The -s parsing wasn't taking into account that -s 0 is a special case, and the -o test was assuming that pkill can tell the difference between two processes started at roughly the

Re: [Toybox] awk (Re: ps down, top to go)

2016-05-23 Thread enh
er than getting repeatedly interrupted. And that means >>> knocking down a bunch of smaller todo items first. >> >> I definitely agree that you want a big block of uninterrupted time. >> (I've been off work since March so I've got that going for me.) >>

[Toybox] top -H segfault

2016-05-23 Thread enh
just running home, so no time to debug further, but in case you haven't seen this yet... plain "top -H" is segfaulting for me before displaying anything. /tmp/toybox$ gdb --args ./generated/unstripped/toybox top -H ... (gdb) run Starting program: /tmp/toybox/generated/unstripped/toybox top -H [Thr

Re: [Toybox] top -H segfault

2016-05-25 Thread enh
On Tue, May 24, 2016 at 2:23 PM, Rob Landley wrote: > On 05/23/2016 07:59 PM, enh wrote: >> just running home, so no time to debug further, but in case you >> haven't seen this yet... plain "top -H" is segfaulting for me before >> displaying anything. > >

Re: [Toybox] top -H segfault

2016-05-25 Thread enh
On Wed, May 25, 2016 at 1:59 PM, enh wrote: > On Tue, May 24, 2016 at 2:23 PM, Rob Landley wrote: >> On 05/23/2016 07:59 PM, enh wrote: >>> just running home, so no time to debug further, but in case you >>> haven't seen this yet... plain "top -H" i

[Toybox] [PATCH] Stabilize another sort.

2016-05-25 Thread enh
Unstable sorting means confusing diffs if you're checking in the generated files. (Which I shouldn't be doing, but getting this bundle of random scripts into Android's build system isn't going to be easy...) --- scripts/genconfig.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From bc62f9

Re: [Toybox] top -H segfault

2016-05-26 Thread enh
On Thu, May 26, 2016 at 1:03 PM, Rob Landley wrote: > On 05/25/2016 04:35 PM, enh wrote: >> On Wed, May 25, 2016 at 1:59 PM, enh wrote: >>> On Tue, May 24, 2016 at 2:23 PM, Rob Landley wrote: >>>> On 05/23/2016 07:59 PM, enh wrote: >>>>> just runn

[Toybox] pgrep --help feedback

2016-06-02 Thread enh
random data point from catching up on my mail: the incompleteness of the pgrep help output led someone to reinvent the wheel badly with ps and grep because they didn't think pgrep had -u. ___ Toybox mailing list Toybox@lists.landley.net http://lists.landl

Re: [Toybox] top -H segfault

2016-06-04 Thread enh
On Fri, May 27, 2016 at 12:56 PM, Rob Landley wrote: > > > On 05/26/2016 05:20 PM, enh wrote: >> On Thu, May 26, 2016 at 1:03 PM, Rob Landley wrote: >>> On 05/25/2016 04:35 PM, enh wrote: >>>> On Wed, May 25, 2016 at 1:59 PM, enh wrote: >>>>>

[Toybox] how to show all processes with ps on all versions of Android

2016-06-04 Thread enh
toolbox ps didn't support -A. seems to be working for them so far, and lets us move forward to a ps that actually lets you choose what you want to see. posting here so it's easy for others to find. -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questi

[Toybox] [PATCH] Basic success/failure return from pgrep/pkill.

2016-06-04 Thread enh
The man page says they also return 2 for syntax errors and 3 for "fatal error: out of memory etc", but I don't know how to implement that and don't need it (or have any reason to believe anyone needs it). Bug: 29092208 --- tests/pgrep.test | 4 tests/pkill.test | 10 -- toys/posix/p

Re: [Toybox] Chromium's producing even _more_ insane ps data.

2016-06-06 Thread enh
command line > contents with quotes argument arguments and %XX hex escapes similar to > URL quoting? (In this case screw utf8: surround each argument with > quotes and %escape anything <32, >=127 (plus % and "). > > Sigh, I hate making up new "standards". Any opinions here? > > Rob > ___ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] Simplifying (was Re: top -H segfault)

2016-06-06 Thread enh
On Mon, Jun 6, 2016 at 12:41 PM, Rob Landley wrote: > Too much chatter, let me simplify. (Patch inlined below.) > > On 06/04/2016 04:46 PM, Rob Landley wrote: >> On 06/04/2016 11:08 AM, enh wrote: >>> sorry, been busy/out but finally got chance to look at this. >>

[Toybox] [PATCH] Update Android roadmap section.

2016-06-06 Thread enh
We killed toolbox ioctl and wouldn't build a toybox one anyway. Also admit that -- although toybox has a grep -- we're not actually using it yet (and why we're not). --- www/roadmap.html | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) From 1f4fe69efc6c7fab7a013be692c7e8a5bea7ad35 M

[Toybox] ps on Android

2016-06-08 Thread enh
folks are starting to notice how broken it is... i'll probably submit https://android-review.googlesource.com/237370 (shown below) tomorrow and then revert it when we have a better solution. >From a0d899ba14f390e3cf0f15fb08de349c7ec43270 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 8

Re: [Toybox] Simplifying (was Re: top -H segfault)

2016-06-08 Thread enh
On Wed, Jun 8, 2016 at 6:37 PM, Rob Landley wrote: > On 06/06/2016 05:33 PM, enh wrote: >> On Mon, Jun 6, 2016 at 12:41 PM, Rob Landley wrote: >>> Too much chatter, let me simplify. (Patch inlined below.) >>>> I checked in a thing, >>> >>> Let me

Re: [Toybox] ps on Android

2016-06-08 Thread enh
On Wed, Jun 8, 2016 at 9:06 PM, Rob Landley wrote: > On 06/08/2016 07:09 PM, enh wrote: >> folks are starting to notice how broken it is... > > I never quite got a clear idea whether or not I should apply the patch > in the last email, and I'd held off because I did

Re: [Toybox] A couple of minor fixes

2016-06-09 Thread enh
t toybox already has a workaround for. this thread is about a *new* glibc bug. > ___ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://who/enh - http://je

Re: [Toybox] Simplifying (was Re: top -H segfault)

2016-06-09 Thread enh
On Wed, Jun 8, 2016 at 10:25 PM, Rob Landley wrote: > On 06/08/2016 09:59 PM, enh wrote: >> On Wed, Jun 8, 2016 at 6:37 PM, Rob Landley wrote: >>>> yeah, as far as i can tell this is right. >>> >>> Ok, I'll apply it then. >> >> i can't

Re: [Toybox] ps on Android

2016-06-09 Thread enh
On Wed, Jun 8, 2016 at 9:06 PM, Rob Landley wrote: > On 06/08/2016 07:09 PM, enh wrote: >> folks are starting to notice how broken it is... > > I never quite got a clear idea whether or not I should apply the patch > in the last email, and I'd held off because I did

<    1   2   3   4   5   6   7   8   9   10   >