Re: [Toybox] Stat, wrong blockcount for F2FS filesystems?

2017-04-07 Thread enh
ooking something else? >> >> ~Matthias >> > > > _______ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net > > -- Elliott Hughes - http://who/enh - http://jess

[Toybox] [PATCH] Fix "make test_split".

2017-04-07 Thread enh
The test shouldn't assume there's a toybox binary on the path. --- tests/split.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From d832e3d9dbe1defe724f42e9acb61a43f7013a8c Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 7 Apr 2017 23:00:54 -0700 Subject: [PATCH] Fix "make tes

Re: [Toybox] [PATCH] Make renice.test work without awk.

2017-04-07 Thread enh
oops. accidental "git commit -a" of debugging "printf"s. will come back to losetup properly at some point. On Fri, Apr 7, 2017 at 9:54 AM, Rob Landley wrote: > On 04/03/2017 10:58 AM, enh wrote: > > > > Also try to only kill processes we created.

[Toybox] [PATCH] Speed up tail.test for shells without builtin printf.

2017-04-07 Thread enh
The test only needs echo, and Android currently doesn't use mksh's builtin printf; the toybox printf is fuller featured and less buggy, but a lot slower to call in a loop like this (and mksh doesn't fall back to the printf on the path if given something it can't handle, so we can't have the best of

[Toybox] [PATCH] Fix "ls -m".

2017-04-07 Thread enh
No new test; the existing test was already failing. --- toys/posix/ls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) From e1b38296d521d56f4cc9a17dbbb73dfdafa532b6 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 7 Apr 2017 23:30:31 -0700 Subject: [PATCH] Fix "ls -m". No new

Re: [Toybox] [PATCH] Fix touch -a/-m (and add the missing tests).

2017-04-10 Thread enh
ping? On Thu, Apr 6, 2017 at 2:47 PM, enh wrote: > > utimensat takes atime in [0] and mtime in [1], but since we're overwriting > with UTIME_OMIT, we actually want to flip the comparison so -a blats 1 and > -m blats 0. > --- > tests/touch.test | 12 +--- >

Re: [Toybox] [PATCH] Add "uudecode -o -" support.

2017-04-10 Thread enh
ping? On Mon, Apr 3, 2017 at 2:14 PM, enh wrote: > > busybox uudecode supports this, and POSIX explicitly mentions it (albeit > only in the "STDOUT" section). Plus Android doesn't have /dev/stdout and > /dev/stdin, so this lets us rewrite the uudecode tests so

Re: [Toybox] [PATCH] Add "uudecode -o -" support.

2017-04-10 Thread enh
On Mon, Apr 10, 2017 at 8:06 PM, Rob Landley wrote: > On 04/10/2017 02:03 PM, enh wrote: > > ping? > > Sorry, drove back from Minneapolis to Austin over the weekend, didn't > get much programming done. > > I had a window open on this one because it adds an explic

Re: [Toybox] [PATCH] Make ls.test work without awk.

2017-04-11 Thread enh
On Tue, Apr 11, 2017 at 12:14 PM, Rob Landley wrote: > On 04/05/2017 12:28 PM, enh wrote: > > tests/ls.test | 4 > > 1 file changed, 4 insertions(+) > > This patch removes no lines, it just adds a new test. How does this make > it work without awk in a way that wa

[Toybox] 3354319e3d3e0b4f5f113d65fa508608f278092c

2017-04-11 Thread enh
instead of https://github.com/landley/toybox/commit/3354319e3d3e0b4f5f113d65fa508608f278092c are you sure you don't just want to add this to your makefile: -Wno-string-plus-int i added that to the Android build file a long time ago since you're keen on this idiom... -e _

Re: [Toybox] Android O: XARGS - bad system call

2017-04-13 Thread enh
; V/Shell:Interactive: Error : Bad system call >> > D/Shell:Interactive: runCommand(...): Command.Result(exitcode=159) >> > > Any idea why? Or how I could find out why? > > ~Matthias > > ___ > Toybox mailing list >

Re: [Toybox] [PATCH] Make ls.test work without awk.

2017-04-14 Thread enh
sorry it took so long, but here's the patch i intended to send 9 days ago :-/ the stats look more plausible this time too: --- tests/ls.test | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) On Tue, Apr 11, 2017 at 12:56 PM, enh wrote: > > > On Tue, Apr 11, 2017 at

Re: [Toybox] [PATCH] Speed up tail.test for shells without builtin printf.

2017-04-14 Thread enh
ping? On Fri, Apr 7, 2017 at 11:19 PM, enh wrote: > > The test only needs echo, and Android currently doesn't use mksh's > builtin printf; the toybox printf is fuller featured and less buggy, > but a lot slower to call in a loop like this (and mksh doesn't fall >

[Toybox] [PATCH] Support the %N coreutils/busybox extension to date.

2017-04-15 Thread enh
Used by the toybox touch test suite (and thus necessary to pass the toybox tests on a toybox-only system). --- tests/date.test | 10 ++ toys/posix/date.c | 50 +++--- 2 files changed, 49 insertions(+), 11 deletions(-) From c998db70bb5a47f2290d3

[Toybox] [PATCH] Use $(( rather than $[ for arithmetic in expand.test.

2017-04-15 Thread enh
I can't find any reference to $[ for arithmetic on the bash man page, but it seems to be a synonym for $((. mksh doesn't support this, so the expand tests that use it fail on Android. No other toybox tests are using $[. --- tests/expand.test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

Re: [Toybox] [PATCH] Support the %N coreutils/busybox extension to date.

2017-04-16 Thread enh
On Sun, Apr 16, 2017 at 1:28 PM, Rob Landley wrote: > On 04/15/2017 01:17 PM, enh wrote: > > > > Used by the toybox touch test suite (and thus necessary to pass the > toybox > > tests on a toybox-only system). > > Did I ever actually post my rant on this topic? Or

Re: [Toybox] [PATCH] Support the %N coreutils/busybox extension to date.

2017-04-17 Thread enh
:51 PM, enh wrote: > > yeah, definitely a mess. > > > > note that i only did this because (a) existing tests were using it and > > (b) busybox has it too. i've been assuming (perhaps incorrectly) that > > busybox also tried to avoid needlessly implementing GNU ex

Re: [Toybox] Android O: XARGS - bad system call

2017-04-17 Thread enh
> https://blog.nelhage.com/2010/08/write-yourself-an-strace- > in-70-lines-of-code/ > and some build-time header preprocessing ala > http://landley.net/notes.html#18-02-2017 into a simple strace for toybox. > > It's on the todo list... > > Rob > -- Elliott Hughes - h

[Toybox] [PATCH] Add the gzip/gunzip/zcat tests I wrote for toolbox gzip/gunzip/zcat.

2017-04-24 Thread enh
Bringing the zlib-based gzip/gunzip/zcat over to toybox is a problem for another day, but at least the tests are easy... (These tests pass with TEST_HOST and on the toolbox versions, but the toybox toys are in pending and very broken.) --- tests/gunzip.test | 50 ++

Re: [Toybox] Test design issue.

2017-04-25 Thread enh
t;\e". > > I guess I can break it into 3 tests with the middle one SKIP_HOST? Seems > awkward... > > Rob > _______________ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net &g

Re: [Toybox] Test design issue.

2017-04-26 Thread enh
On Wed, Apr 26, 2017 at 2:41 PM, Rob Landley wrote: > On 04/25/2017 12:28 PM, enh wrote: > > note that the existing SKIP_HOST mechanism is very error prone. iirc > > none of the sed tests actually run because one near the top needs > > SKIP_HOST and it never gets unse

Re: [Toybox] [PATCH] Add the gzip/gunzip/zcat tests I wrote for toolbox gzip/gunzip/zcat.

2017-04-26 Thread enh
On Wed, Apr 26, 2017 at 2:43 PM, Rob Landley wrote: > On 04/24/2017 03:43 PM, enh wrote: > > Bringing the zlib-based gzip/gunzip/zcat over to toybox is a problem for > > another day, > > Blah, I should take this one. > > I have deflate decompression side implemented al

[Toybox] toybox and NDK sitrep

2017-04-28 Thread enh
ash stuff) --- there is no public API for the , so that still won't build out of the box. (this was a useful exercise because it showed that was still missing from the NDK, so that bug should finally be fixed for real this time.) -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ An

Re: [Toybox] libselinux can depend on libcutils

2017-05-01 Thread enh
ox-landley.net > > -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [landley/toybox] cp -R --preserve timing (#66)

2017-05-03 Thread enh
it > images it and if you have hardlinks it updates all copies. > > I'm fine with changing how it works, just explaining why I did it in the > first place. > > Elliott: any opinions on the right place to fix this? > > Rob >

Re: [Toybox] toybox and NDK sitrep

2017-05-05 Thread enh
On Sun, Apr 30, 2017 at 12:58 AM, Rob Landley wrote: > On 04/28/2017 05:31 PM, enh wrote: > > since rob asked on some other thread earlier this week... > > > > NDK r15beta2 should hopefully ship in time for I/O in a couple of weeks, > > so i had a quick go at building

[Toybox] toybox fdisk

2017-05-05 Thread enh
al author ran it once"... -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] Add the gzip/gunzip/zcat I wrote for toolbox.

2017-05-08 Thread enh
On Mon, May 8, 2017 at 4:37 PM, Rob Landley wrote: > On 04/26/2017 05:03 PM, enh wrote: >> if you're actually going to start to look, i'll attach my port of the >> current toolbox implementation. > > Ok, carving out a half hour to look at this... optargs should re

Re: [Toybox] [PATCH] Support the %N coreutils/busybox extension to date.

2017-05-09 Thread enh
what's the plan? "half an eye is better than no eye" (especially when no-one else has this particular missing eye), or "rewrite the test to use --full-time"? since i personally have never needed %N except for getting this test to run, i'm happy to do either. On Mon

Re: [Toybox] [PATCH] Add the gzip/gunzip/zcat tests I wrote for toolbox gzip/gunzip/zcat.

2017-05-09 Thread enh
On Wed, Apr 26, 2017 at 2:43 PM, Rob Landley wrote: > On 04/24/2017 03:43 PM, enh wrote: >> Bringing the zlib-based gzip/gunzip/zcat over to toybox is a problem for >> another day, > > Blah, I should take this one. > > I have deflate decompression side implemented al

Re: [Toybox] [PATCH] Add the gzip/gunzip/zcat I wrote for toolbox.

2017-05-09 Thread enh
On Tue, May 9, 2017 at 1:25 PM, Rob Landley wrote: > On 05/08/2017 08:27 PM, enh wrote: >> On Mon, May 8, 2017 at 4:37 PM, Rob Landley wrote: >>> On 04/26/2017 05:03 PM, enh wrote: >>>> if you're actually going to start to look, i'll attach my port of

[Toybox] [PATCH] Make fewer assumptions about the shell in echo.test.

2017-05-10 Thread enh
This test fails with mksh, but we're not here to test mksh. --- tests/echo.test | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) From 7144d78f0f515472cfba1ebe885f78048e08b2cb Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 10 May 2017 13:51:44 -0700 Subject: [PATCH] Make fewer ass

[Toybox] [PATCH] Add bzip2 support to tar.

2017-05-12 Thread enh
Also trivial cleanup of pipe -> xpipe. Bug: http://b/38215123 --- tests/files/tar/tar.tbz2 | Bin 0 -> 168 bytes tests/files/tar/tar.tgz | Bin 0 -> 166 bytes tests/tar.test | 14 ++ toys/pending/tar.c | 23 --- 4 files changed, 26 insertions(+),

Re: [Toybox] Stat output for %N

2017-05-12 Thread enh
d the filepath. Both items are > directories. > > Why the format difference? > > ~Matthias > > ___ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net > -- Elliott Hughes

Re: [Toybox] Valid range for stat userID and groupID?

2017-05-13 Thread enh
94967295" seems large too. > > Is it normal and I should expect these kind of values or is this some weird > root related stuff one should ignore or is it maybe a bug in toybox or the > Android kernel? > > ~Matthias > > _______ > Toyb

[Toybox] [PATCH] Fix various seq bugs.

2017-05-13 Thread enh
Use the precision of the inputs to determine the default output. This was the reported bug. (Two existing tests were failing on the host because of this, so I've fixed those tests and added more tests for other special cases.) Reject invalid inputs. Match GNU/busybox behavior with 0 increment. (A

Re: [Toybox] [PATCH] Fix various seq bugs.

2017-05-13 Thread enh
Also remove a couple of locals that were duplicating globals. > > Bug: http://b/37792952 > --- > tests/seq.test | 23 +++--- > toys/lsb/seq.c | 74 > ++ > 2 files changed, 69 insertions(+), 28 deletions(-)

[Toybox] [PATCH] factor shouldn't give incorrect answers for >64-bit integers.

2017-05-13 Thread enh
--- toys/other/factor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) From fab8f56370abe41374692587c4bf92bdbd8b711a Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Sat, 13 May 2017 12:48:35 -0700 Subject: [PATCH] factor shouldn't give incorrect answers for >64-bit integers. --- to

Re: [Toybox] chrt.c cleanup

2017-05-22 Thread enh
On Sun, May 21, 2017 at 11:15 AM, Rob Landley wrote: > On 05/09/2017 10:57 AM, enh wrote: >> On Mon, May 8, 2017 at 4:38 PM, Rob Landley wrote: >>> On 05/08/2017 03:52 PM, enh wrote: >> toys/pending/chrt.c \ > > Ooh, it's <100 lines! Grab! >

Re: [Toybox] [PATCH] Fix various seq bugs.

2017-05-22 Thread enh
ping? On Sat, May 13, 2017 at 12:49 PM, enh wrote: > i wasn't seriously considering implementing the arbitrary-precision > arithmetic that GNU seems to use, but i did wonder about at least > using long long instead of double for 53 deciding i was already far enough down the rat h

Re: [Toybox] [PATCH] Add the gzip/gunzip/zcat tests I wrote for toolbox gzip/gunzip/zcat.

2017-05-22 Thread enh
On Tue, May 9, 2017 at 9:02 AM, enh wrote: > On Wed, Apr 26, 2017 at 2:43 PM, Rob Landley wrote: >> On 04/24/2017 03:43 PM, enh wrote: >>> Bringing the zlib-based gzip/gunzip/zcat over to toybox is a problem for >>> another day, >> >> Blah, I sho

[Toybox] [PATCH] Add and use xmmap.

2017-05-23 Thread enh
Everyone forgets that mmap returns MAP_FAILED rather than NULL on failure. Every use of mmap in toybox was either doing the wrong check, or no check at all (including the two I personally added). --- lib/lib.h | 1 + lib/xwrap.c| 7 ++ toys/android/load_policy.

Re: [Toybox] chrt.c cleanup

2017-05-25 Thread enh
On Mon, May 22, 2017 at 7:53 PM, Rob Landley wrote: > On 05/22/2017 11:12 AM, enh wrote: >>> Do you care if somebody does "chrt -m ls -l"? Right now -m happens and >>> it ignores the rest of the command line. >> >> seems like a bug. > > I added a &

Re: [Toybox] chrt.c cleanup

2017-05-26 Thread enh
On Fri, May 26, 2017 at 12:23 AM, Rob Landley wrote: > On 05/25/2017 07:59 PM, enh wrote: >> On Mon, May 22, 2017 at 7:53 PM, Rob Landley wrote: >>> I could teach the parser to notice multiple usage lines but then how >>> would the option merging work? What woul

[Toybox] [PATCH] Allow ':' in property names.

2017-05-31 Thread enh
Bug: http://b/62114389 Test: setprop Change-Id: I165bcc01bb2422d991f746c5e6490cbdfb74472f --- toys/android/setprop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From c69eba340488113b05c06155ee96df2b7e4989e3 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 31 May 2017 11:01:11 -0

Re: [Toybox] [PATCH] Allow ':' in property names.

2017-05-31 Thread enh
(i broke my usual rule about not submitting in AOSP before getting a patch submitted upstream for this, since it had to go in today.) On Wed, May 31, 2017 at 2:23 PM, enh wrote: > Bug: http://b/62114389 > Test: setprop > Change-Id: I165bcc01bb2422d991f746c5e6490cbdfb74472f > --- >

Re: [Toybox] Grinding away at a release.

2017-06-04 Thread enh
e/design review. Alas right now I'm a little less coherent than I'd > like due to this cold... > ___ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] Command exit numbers.

2017-06-12 Thread enh
iously usable? > Rob > _______ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions?

Re: [Toybox] Command exit numbers.

2017-06-13 Thread enh
On Tue, Jun 13, 2017 at 3:52 PM, Rob Landley wrote: > On 06/12/2017 10:49 AM, enh wrote: >> On Sat, Jun 10, 2017 at 11:29 AM, Rob Landley wrote: >>> Would it be useful if perror_exit() set exitval to errno by default >>> instead of 1? They're well defined values t

Re: [Toybox] ps crashes

2017-06-15 Thread enh
teps and (afaik) this is the first crash since March :-/ On Wed, Mar 22, 2017 at 12:37 PM, Rob Landley wrote: > On 03/22/2017 01:18 PM, enh wrote: >> (For those following along at home, a fix was merged yesterday.) > > And the reason I didn't change what lib/dirtree.c was doi

Re: [Toybox] 0.7.4 is out.

2017-06-19 Thread enh
ling list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. ___

Re: [Toybox] [PATCH] netcat: make -l exit after handling a request

2017-06-29 Thread enh
atible address it resolves to, so we can maybe just ignore this.) > > -Josh > > _______ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net > -- Elliott Hughes - http://wh

[Toybox] building multiple configurations from one tree

2017-06-29 Thread enh
want to be without an alternative when the music stops and we have to sit somewhere... though dummy implementations is probably the smallest hack if it comes to it. -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewe

Re: [Toybox] building multiple configurations from one tree

2017-06-30 Thread enh
On Fri, Jun 30, 2017 at 12:52 PM, Rob Landley wrote: > On 06/30/2017 01:13 AM, enh wrote: >> i've mentioned this a few times, but i have a concrete example now. >> with treble >> [https://android-developers.googleblog.com/2017/05/here-comes-treble-modular-base-for.htm

Re: [Toybox] building multiple configurations from one tree

2017-07-01 Thread enh
t;make" in a way that doesn't actually try to build toybox (which will always fail on the host anyway), instead just stopping after all the generated/ stuff is done. On Fri, Jun 30, 2017 at 3:13 PM, enh wrote: > On Fri, Jun 30, 2017 at 12:52 PM, Rob Landley wrote: >> On 06/

[Toybox] [PATCH] Fix -Wformat compiler warning in expr.c.

2017-07-07 Thread enh
Android forces -Wformat on for all source. toys/pending/expr.c:116:28: warning: field precision should have type 'int', but argument has type 'long' [-Wformat] ret->s = xmprintf("%.*s", m[1].rm_eo-m[1].rm_so, target+m[1].rm_so);

Re: [Toybox] dd tests for transaction size?

2017-07-09 Thread enh
It's used in various boot disk generation scripts in the Android tree. (Whether it's needed is a question I can't answer as easily!) On Jul 9, 2017 15:07, "Rob Landley" wrote: On 07/09/2017 02:41 AM, Rob Landley wrote: > does anybody have a decent strategy for testing the ibs > and obs options?

Re: [Toybox] dd tests for transaction size?

2017-07-09 Thread enh
On Sun, Jul 9, 2017 at 4:23 PM, Rob Landley wrote: > > On 07/09/2017 05:18 PM, enh wrote: >> > On 07/09/2017 02:41 AM, Rob Landley wrote: >> > > does anybody have a decent strategy for testing the ibs >> > > and obs options? >> > >>

Re: [Toybox] dd tests for transaction size?

2017-07-10 Thread enh
On Mon, Jul 10, 2017 at 10:46 AM, Rob Landley wrote: > On 07/10/2017 12:15 AM, enh wrote: >> On Sun, Jul 9, 2017 at 4:23 PM, Rob Landley wrote: >>>> It's used in various boot disk generation scripts in the Android tree. >>>> (Whether it's ne

Re: [Toybox] dd tests for transaction size?

2017-07-10 Thread enh
On Mon, Jul 10, 2017 at 10:57 AM, enh wrote: > On Mon, Jul 10, 2017 at 10:46 AM, Rob Landley wrote: >> On 07/10/2017 12:15 AM, enh wrote: >>> On Sun, Jul 9, 2017 at 4:23 PM, Rob Landley wrote: >>>>> It's used in various boot disk generation scripts in

Re: [Toybox] dd tests for transaction size?

2017-07-11 Thread enh
On Tue, Jul 11, 2017 at 12:10 PM, Rob Landley wrote: > On 07/10/2017 02:00 PM, enh wrote: >> On Mon, Jul 10, 2017 at 10:57 AM, enh wrote: >>>> Would the above bs= behavior tie sound like it would work for the users >>>> you found? >>> >>> for

Re: [Toybox] banging on ping

2017-07-17 Thread enh
rth go at dealing with those guys just yet.) > > Sigh. I can implement a ping requiring suid, but... ouch? They MADE an > api not to need this, and then cripped that API for no apparent reason. > (If you wanna ping flood somebody you can do it with UDP?) > > Lemme check in wha

Re: [Toybox] banging on ping

2017-07-18 Thread enh
On Mon, Jul 17, 2017 at 11:47 PM, Rob Landley wrote: > On 07/17/2017 09:55 AM, enh wrote: >> On Mon, Jul 17, 2017 at 3:33 AM, Rob Landley wrote: >>> Over the weekend I started looking at ping.c again thinking "this seems >>> really easy, why haven't I alrea

[Toybox] [PATCH] Don't unnecessarily use printf in wc.test when echo will do.

2017-08-03 Thread enh
(And is much faster if your shell doesn't have a builtin printf.) --- tests/wc.test | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) From 87c06ec04c5e7aaa6a54492c5a1194b645bfd2b6 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Thu, 3 Aug 2017 17:13:20 -07

[Toybox] [PATCH] Fix wc -m on bionic.

2017-08-04 Thread enh
When mbrtowc returns -2, all n bytes have been processed. Bionic's interpretation of POSIX is that you must not re-supply those bytes on the next call, and should only supply the bytes needed to complete the character. If you re-supply the bytes on the next call, bionic considers that an illegal se

Re: [Toybox] [PATCH] Fix wc -m on bionic.

2017-08-08 Thread enh
(sorry, didn't get time to look at this until now.) On Sun, Aug 6, 2017 at 6:38 PM, Rob Landley wrote: > On 08/04/2017 07:54 PM, enh wrote: >> When mbrtowc returns -2, all n bytes have been processed. Bionic's >> interpretation of POSIX is that you must not re-supply t

[Toybox] [PATCH] Fix iconv build and add trivial test.

2017-08-22 Thread enh
--- tests/iconv.test | 15 +++ toys/pending/iconv.c | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 tests/iconv.test From a5b5b18a36a61a1bebd487e172c52b896252d136 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Tue, 22 Aug 2017 14:03:45 -0700 Subj

Re: [Toybox] [PATCH] Fix wc -m on bionic.

2017-08-22 Thread enh
happy with the replacement patch? On Tue, Aug 8, 2017 at 3:21 PM, enh wrote: > (sorry, didn't get time to look at this until now.) > > On Sun, Aug 6, 2017 at 6:38 PM, Rob Landley wrote: >> On 08/04/2017 07:54 PM, enh wrote: >>> When mbrtowc returns -2, all n bytes

Re: [Toybox] musl intentionally broke chrt

2017-08-29 Thread enh
and the runtime produce a message, but of course > there isn't... > > Rob > _______ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.net/listinfo.cgi/toybox-landley.net -- Elliott Hughes - http://wh

Re: [Toybox] musl intentionally broke chrt

2017-08-29 Thread enh
On Tue, Aug 29, 2017 at 8:32 AM, enh wrote: > can't you just infer musl from the relatively small ...number of c libraries out there... > ? > > #if defined(__linux__) && (!defined(__BIONIC__) && !defined(__GLIBC__) > && whatever ulibc is if you have

Re: [Toybox] musl intentionally broke chrt

2017-08-30 Thread enh
On Wed, Aug 30, 2017 at 1:42 AM, Rob Landley wrote: > On 08/29/2017 10:32 AM, enh wrote: >> On Tue, Aug 29, 2017 at 8:32 AM, enh wrote: >>> can't you just infer musl from the relatively small >> >> ...number of c libraries out there... > > It would work,

Re: [Toybox] musl intentionally broke chrt

2017-08-31 Thread enh
On Thu, Aug 31, 2017 at 1:46 PM, Rob Landley wrote: > On 08/30/2017 10:25 AM, enh wrote: >> no: the point of the C library is to hide the mapping from >> functionality to system call. if you ever do port to BSD/macOS you'll >> need to cope with their syscall differen

Re: [Toybox] utf8 (was Re: musl intentionally broke chrt)

2017-09-01 Thread enh
http://www.unicode.org/faq/utf_bom.html#utf8-4 On Fri, Sep 1, 2017 at 1:08 AM, Rob Landley wrote: > On 08/31/2017 04:01 PM, enh wrote: >>>> didn't you get in to utf8 because of my wc -m patch? :-) >>> >>> Working on it. It's one of those "I&#

Re: [Toybox] [PATCH] Fix various seq bugs.

2017-09-10 Thread enh
"use cases you care about", > and I'm not really getting it from these...) > > Rob > > P.S. We got GPS to work at $DAYJOB! Yay! Still lots to do but light at > the end of the darn tunnel... > ___ > Toybox mailing list > Toybox@lists.landley.net > http://lists.landley.

[Toybox] [PATCH] Stably sort generated/help.h.

2017-09-18 Thread enh
Pairs like "dhcp" and "dhcp6" keep swapping around, messing up the diff for checked in generated files. --- scripts/config2help.c | 2 +- scripts/make.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) From b296dac61f8404a24a34c6efcf0d0d61cb8656b4 Mon Sep 17 00:00:00 2001 From: Elli

Re: [Toybox] [landley/toybox] xargs: exec ... Argument list too long (#40)

2017-09-20 Thread enh
+- 3 files changed, 27 insertions(+), 1 deletion(-) On Mon, Aug 15, 2016 at 12:06 AM, Rob Landley wrote: > On 08/13/2016 04:36 PM, enh wrote: >>>> Oh well, use the sysconf and then file a bug against musl. (Elliott will >>>> probably notice this, and if not he'll notice

[Toybox] ps -T

2017-09-20 Thread enh
8633602584 9455861888 140720560866826 140720560866928 140720560866928 140720560869342 0 and copies 147058 into SLOT_pid because that code no longer knows the real pid. not sure how best to fix this. -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Ma

Re: [Toybox] [landley/toybox] xargs: exec ... Argument list too long (#40)

2017-09-21 Thread enh
he toybox on a device if we do ever find someone relying on this safety margin. (the guy who owns the NDK and has to regularly test on ancient devices may thank me for this some day.) On Wed, Sep 20, 2017 at 1:59 PM, enh wrote: > this bug was reported again internally this week (within a day of

Re: [Toybox] Regarding toybox 'top' command options support

2017-09-25 Thread enh
he options > should be moved to the earlier quoted string in the NEWTOY macro to mark > them as not common... And -O differs because iotop uses it to mean > something else. But maybe -H can be shared... > ___ > Toybox mailing list &

Re: [Toybox] Release prep and testcmd in tests/*.test

2017-09-25 Thread enh
axes being nonobviously different. > > Sigh. Maybe testcmd should have a different name? I don't want it to be > significantly longer name because that leads to more wrapped lines.) > > This is another one of those "it's close enough there isn't an obvious > s

[Toybox] [PATCH] Basic Mach-O support in file(1).

2017-09-25 Thread enh
The Nexus Player build was subtly broken in that it assumed that the host was using ELF. No-one noticed until a Mac user tried to flash their build, which contained a Mach-O x86 binary instead of an ELF x86 binary. Hilarity ensued. (On the same day, file(1) was able to explain a mixup with an ELF

Re: [Toybox] [landley/toybox] xargs: exec ... Argument list too long (#40)

2017-09-25 Thread enh
i did find some time (no pun intended) to look at the equivalent bug in find on friday, but spent it all on a couple of ratholes i discovered trying to set up a test :-( On Sat, Sep 23, 2017 at 6:14 AM, Rob Landley wrote: > On 09/21/2017 10:40 AM, enh wrote: >> i should probably have

[Toybox] [PATCH] Fix groups(1) and id -G.

2017-09-29 Thread enh
Both should only output the groups. --- toys/posix/id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From 4e16de4e367b288e7b65ba6c1043fd54fa4566e4 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 29 Sep 2017 15:20:26 -0700 Subject: [PATCH] Fix groups(1) and id -G. Both should on

Re: [Toybox] [landley/toybox] xargs: exec ... Argument list too long (#40)

2017-10-02 Thread enh
On Sun, Oct 1, 2017 at 3:31 PM, Rob Landley wrote: > On 09/28/2017 10:18 AM, enh wrote: >> Did you look at my xargs patch in this thread? > > Not closely enough. (Description implied it was the same as last time.) > >> It handles all that. I think the find patch i

Re: [Toybox] [PATCH] Fix groups(1) and id -G.

2017-10-04 Thread enh
Ping. (Seems like a good candidate to get in if you're working on a release.) On Sep 29, 2017 15:21, "enh" wrote: > Both should only output the groups. > --- > toys/posix/id.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Toybox] Release fiddling, need another day or two.

2017-10-04 Thread enh
ork, I DO like toybox. > > regards > scsijon > ps I wonder if android could make use of it? pay attention at the back there! https://android.googlesource.com/platform/system/core/+/master/shell_and_utilities/ :-) > _______ > Toybox mailing list > To

Re: [Toybox] [PATCH] Fix groups(1) and id -G.

2017-10-11 Thread enh
Ping? On Oct 4, 2017 11:25, "enh" wrote: > Ping. (Seems like a good candidate to get in if you're working on a > release.) > > On Sep 29, 2017 15:21, "enh" wrote: > >> Both should only output the groups. >> --- >> toys/posix/

Re: [Toybox] Yes, I'm aware dreamhost has deleted the mailing list web archive again.

2017-10-11 Thread enh
Seems like it's not being updated even now... "*Note:*The archive search index was last rebuilt at Friday, 29 Sep 2017 19:07:57 PDT. Any postings after that will not be found by a search. Index rebuild is usally done once every 24 hours for this list." On Sep 28, 2017 22:47, "Rob Landley" wrote:

Re: [Toybox] Yes, I'm aware dreamhost has deleted the mailing list web archive again.

2017-10-11 Thread enh
On Wed, Oct 11, 2017 at 1:58 PM, Rob Landley wrote: > > > On 10/11/2017 12:36 PM, enh wrote: > > On Sep 28, 2017 22:47, "Rob Landley" wrote: > > > > > > It's an annual event with them. They're deeply incompetent. > > > > Seems l

[Toybox] TOYBOX_VERSION

2017-10-16 Thread enh
oid-review.googlesource.com/511275). but if your plan is for the git tag to be the one true source of version, we can switch to a git/sed combo... -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android native code/tools questions? Mail me/drop by/add me as a reviewer. _

Re: [Toybox] TOYBOX_VERSION

2017-10-16 Thread enh
On Mon, Oct 16, 2017 at 2:24 PM, Rob Landley wrote: > Hey, didn't wind up in spam this time! (Gmail learns.) > > On 10/16/2017 12:29 PM, enh wrote: >> i was going to send this patch to allow Android to add "-android" >> without having to work out what the to

Re: [Toybox] Yes, I'm aware dreamhost has deleted the mailing list web archive again.

2017-10-17 Thread enh
On Wed, Oct 11, 2017 at 1:58 PM, Rob Landley wrote: > > On 10/11/2017 12:36 PM, enh wrote: >> On Sep 28, 2017 22:47, "Rob Landley" wrote: >> > >> > It's an annual event with them. They're deeply incompetent. >> >> Seems like it'

Re: [Toybox] TOYBOX_VERSION

2017-10-19 Thread enh
ping on TOYBOX_VENDOR? On Mon, Oct 16, 2017 at 5:20 PM, enh wrote: > On Mon, Oct 16, 2017 at 2:24 PM, Rob Landley wrote: >> Hey, didn't wind up in spam this time! (Gmail learns.) >> >> On 10/16/2017 12:29 PM, enh wrote: >>> i was going to send this patc

Re: [Toybox] ps -T

2017-10-19 Thread enh
dows full of tabs. Working on it...) > > [Notices this email didn't get sent, while stopped at a McDonald's in > Oklahoma on the drive back from minneapolis to austin. Right, time to > press send...] > > On 09/20/2017 05:08 PM, enh wrote: >> ps -T doesn't really

Re: [Toybox] ps -T

2017-11-01 Thread enh
On Wed, Nov 1, 2017 at 1:57 AM, Rob Landley wrote: > On 10/19/2017 06:13 PM, enh wrote >>> On 09/20/2017 05:08 PM, enh wrote: >>>> ps -T doesn't really work if you have any filters. so ps -AT is fine, >>>> but ps -p -T only shows the main thread. >>

Re: [Toybox] Yes, I'm aware dreamhost has deleted the mailing list web archive again.

2017-11-01 Thread enh
https://github.com/landley/toybox/commit/2d893a4077c12732238f5a9fc9c31fda8bcc3ed9 fixes the cut and chmod tests for me. thanks! On Tue, Oct 17, 2017 at 11:19 AM, enh wrote: > On Wed, Oct 11, 2017 at 1:58 PM, Rob Landley wrote: >> >> On 10/11/2017 12:36 PM, enh wrote: >>&g

[Toybox] [PATCH] file(1): add ogg, TrueType font, LLVM bitcode, PEM certs, and PE executables.

2017-11-01 Thread enh
More of the files encountered on the Android system image (plus PE executables, which we build but which shouldn't actually make it to the system image!). --- toys/posix/file.c | 43 +++ 1 file changed, 43 insertions(+) From 6fd1cf99b2bfff67f756d95b060074a5a

[Toybox] dd and other pending stuff on Android

2017-11-02 Thread enh
, and no-one will notice. it's the _previous_ list folks will notice. (with the possible exception of expr, they're not just available, they're actively used.) -- Elliott Hughes - http://who/enh - http://jessies.org/~enh/ Android

Re: [Toybox] Regression: commit da029c11e6b1 broke toybox xargs.

2017-11-03 Thread enh
the various libc implementations don't > agree, then the actual kernel limit changed again while I was looking at it. > >>Linus > > Should I just go back to hardwiring in 131072? It's no _less_ arbitrary > than 10 megs, and it sounds like getting it _right_ i

[Toybox] [PATCH] Add "df -i".

2017-11-15 Thread enh
Also switch to u64 for calculations. Some FUSE file systems have inode counts large enough to overflow s64. --- toys/posix/df.c | 69 +++-- 1 file changed, 47 insertions(+), 22 deletions(-) From a79e67ab7846bc5f2f3b2389806230e4c13f2e2d Mon Sep 17

<    3   4   5   6   7   8   9   10   11   12   >