-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I'll review in my slack time. So I'll do this chunk per chunk. Let's
start with the first few commits ;-)
e5b5280b5f336b80b00d9c9671a72391ab1f0a9b
+ data-dbus_path = g_strdup_printf (/%s, dbus_name);
+
+ p =
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:09, Philip Van Hoof wrote:
87c30cc73629ff54ff8e5170ded499c2cbbda61a
Sorry it's like this instead of course:
Enumerable thingThatHasItems = new List(); Enumerable e =
thingThatHasItems.Enumerate(); // (not this but)
Enumerator e =
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
b291f85416674b4b7a54cded5f6e6fe8af22d181
+ if (!priv-root) {
+ g_object_unref (priv-root);
+ }
Perhaps this got fixed afterwards in a later commit and I missed it,
but it can't be right in this comment:
if the thing is
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Martyn,
You have to be more careful about ontology changes:
https://git.gnome.org/browse/tracker/commit/?id=6b2dff6e18bd9a9d4238557b2dce2565fea49491
Maxcardinality changes are not supported by our ontology change coping
mechanism:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
c5d068279c9db7ac45e577b18b38d0bcb62b1d06
+ guint external_crawler : 1; /* TRUE if we're being feed files
+* instead of discovering them
+* ourselves */
+ guint
On 08/08/14 09:09, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
87c30cc73629ff54ff8e5170ded499c2cbbda61a
About TrackerEnumeratorIface:
In my opinion an enumerator has a Next() method to enumerate to the
next element. I think it's a bit wierd to return a linked list on
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:27, Philip Van Hoof wrote:
b291f85416674b4b7a54cded5f6e6fe8af22d181
+ if (!priv-root) { +g_object_unref (priv-root); + }
Perhaps this got fixed afterwards in a later commit and I missed
it, but it can't be
On 08/08/14 09:27, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
b291f85416674b4b7a54cded5f6e6fe8af22d181
+ if (!priv-root) {
+ g_object_unref (priv-root);
+ }
Perhaps this got fixed afterwards in a later commit and I missed it,
but it can't be
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:58, Philip Van Hoof wrote:
On 8/08/2014 10:27, Philip Van Hoof wrote:
Can you squash those two commits together before merging master?
Just git rebase -i, you know the drill ;-)
8cdc0188e2c4d341e6e9788370e9381e085ae34b
- -
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:56, Martyn Russell wrote:
Yah, just fix it anyway ;-)
Poor Aleksander. git blame is too good.
c2863b39b4e8f178c4d87ceee5d96ad0c3647585
if (fs-priv-item_queue_blocker) { trace_eq ( cancelled: item
queue blocked waiting for
On 08/08/14 09:54, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
c5d068279c9db7ac45e577b18b38d0bcb62b1d06
+ guint external_crawler : 1; /* TRUE if we're being feed files
+* instead of discovering them
+
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 11:11, Martyn Russell wrote:
On 08/08/14 09:54, Philip Van Hoof wrote:
It will mess up your alignment and padding and that makes future
API changes more difficult. You'll need to know how the bit
fields will happen on each
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:56, Martyn Russell wrote:
On 08/08/14 08:58, Philip Van Hoof wrote:
Reply inline below.
e5b5280b5f336b80b00d9c9671a72391ab1f0a9b
+data-dbus_path = g_strdup_printf (/%s, dbus_name); +
+p = data-dbus_path; +
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
How to implement this would go like this:
- - Detect the change with nao:lastModified and the existing
introspection ontology (tooling for this is available because of the
existing support)
- - Store the pending change (tooling available)
- -
14 matches
Mail list logo
