Re: [Tracker] [PATCH] Some smaller 'style' fixes and a missing g_free ()

2007-07-15 Thread jamie
On Sun, 2007-07-15 at 00:43 +0200, Marcus Fritzsch wrote: > Hi, > > i took a look over some code and changed some minor points - nothing grave ;) > > One question: is g_return_... prefered for invalid input parameters, > or also for errors coming up within the function context? My current > setti

[Tracker] [PATCH] Some smaller 'style' fixes and a missing g_free ()

2007-07-14 Thread Marcus Fritzsch
Hi, i took a look over some code and changed some minor points - nothing grave ;) One question: is g_return_... prefered for invalid input parameters, or also for errors coming up within the function context? My current setting is the first one ;) (see patch line 36 and 37) Kind regards, Marcus