[Tracker] Anonymous File Nodes branch review

2010-02-03 Thread Martyn Russell
Hi all, Carlos and Philip recently worked on the anonymous-file-nodes branch to fix a regression with the way resources are stored in the database which was changed recently. This is the review of that branch: http://git.gnome.org/browse/tracker/log/?h=anonymous-file-nodes 1. We should us

Re: [Tracker] Anonymous File Nodes branch review

2010-02-03 Thread Philip Van Hoof
On Wed, 2010-02-03 at 12:08 +, Martyn Russell wrote: > Hi all, > > Carlos and Philip recently worked on the anonymous-file-nodes branch to > fix a regression with the way resources are stored in the database which > was changed recently. This is the review of that branch: > >http://git.

Re: [Tracker] Anonymous File Nodes branch review

2010-02-03 Thread Carlos Garnacho
Hi! On miƩ, 2010-02-03 at 12:08 +, Martyn Russell wrote: > Hi all, > > Carlos and Philip recently worked on the anonymous-file-nodes branch to > fix a regression with the way resources are stored in the database which > was changed recently. This is the review of that branch: > >http:/

Re: [Tracker] Anonymous File Nodes branch review

2010-02-03 Thread Martyn Russell
On 03/02/10 12:51, Philip Van Hoof wrote: On Wed, 2010-02-03 at 12:08 +, Martyn Russell wrote: - tracker_sparql_builder_object_iri (sparql, uri); + tracker_sparql_builder_object (sparql, "_:foo"); Looks right to me Just to repeat what I said on IRC: Technically there is noth

Re: [Tracker] Anonymous File Nodes branch review

2010-02-03 Thread Martyn Russell
On 03/02/10 13:05, Carlos Garnacho wrote: 1. We should use G_DIR_SEPARATOR_S here instead: + slash_uri = g_strconcat (source_uri, "/", NULL); Hmm, we're building an uri here, I don't think we want uris with '\' if tracker is ported (again?) to Windows :) This is a good point :P 2. Th

Re: [Tracker] Anonymous File Nodes branch review

2010-02-03 Thread Martyn Russell
On 03/02/10 12:08, Martyn Russell wrote: Hi all, Carlos and Philip recently worked on the anonymous-file-nodes branch to fix a regression with the way resources are stored in the database which was changed recently. This is the review of that branch: http://git.gnome.org/browse/tracker/log/?h=a