This is the latest merge-patch for Turtle to Trunk.
Please review
--
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://pvanhoof.be/blog
http://codeminded.be
Index: src/tracker-indexer/tracker-main.c
==
Ping
On Thu, 2008-12-04 at 14:16 +0100, Philip Van Hoof wrote:
> This is the latest merge-patch for Turtle to Trunk.
>
> Please review
>
--
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://pvanhoof.be/blog
http://codeminded.be
Hi!
Thanks Martyn for the review. I'll try to clarify how this
backup/restore metadata works.
> Summary:
>
> It looks to me like a lot of work is still needed to keep the code clean
> and consistent with the current code base. There are a couple of leaks
> which need fixing and a couple of is
On 08/12/08 12:37, Philip Van Hoof wrote:
Ping
On Thu, 2008-12-04 at 14:16 +0100, Philip Van Hoof wrote:
This is the latest merge-patch for Turtle to Trunk.
Please review
Hi,
OK, so here are my review comments. Note, this patch doesn't compile for
me, there are a lot of warnings/errors.
Hi!
the tracker-indexer part seems conceptually right, but if we're going to
use TRANSACTION_MAX elsewhere, maybe it should have a proper name, have
a nice prefix, etc...
On jue, 2008-12-04 at 14:16 +0100, Philip Van Hoof wrote:
> This is the latest merge-patch for Turtle to Trunk.
>
> Please re
Extra note
This one is in the patch. I'm posting it a second time to catch
Garnacho's full attention:
Index: src/tracker-indexer/tracker-module-metadata.c
===
--- src/tracker-indexer/tracker-module-metadata.c (revision 2683)
++
On Tue, 2008-12-09 at 18:32 +0100, Philip Van Hoof wrote:
>
> - g_hash_table_insert (metadata->table,
> - g_object_ref (field),
> - data);
> + g_hash_table_replace (metadata->table,
> + g_object_ref (field),
> +
On Tue, 2008-12-09 at 18:42 +0100, Jürg Billeter wrote:
> On Tue, 2008-12-09 at 18:32 +0100, Philip Van Hoof wrote:
> >
> > - g_hash_table_insert (metadata->table,
> > -g_object_ref (field),
> > -data);
> > + g_hash_table_replace (metadata->tabl
El mar, 09-12-2008 a las 18:17 +0100, ext Philip Van Hoof escribió:
> Hi there,
>
> This is a new version of the patch.
>
> Garnacho: You want to review the part where I'm changing your precious
> src/tracker-indexer/tracker-module-metadata.c at line 1016 in this diff.
>
> Ivan: Continue commit
Hi,
I am thinking that this mechanism is broken if we call the "restart with
> reindex" from the preferences window, because in that case tracker
> remove the DB files and restart.
>
I answer to myself: This case is fixed in the turtle branch.
>
> Ivan
> __
On 10/12/08 15:37, Philip Van Hoof wrote:
This is today's patch which includes Ivan's most recent changes
svn merge -r 2555:2615 ../branches/turtle/<- needed conflict solving
svn merge -r 2615:2680 ../branches/turtle/<- needed conflict solving
svn merge -r 2680:2682 ../branches/turtle
svn merge
On 09/12/08 13:19, Ivan Frade wrote:
Hi!
Hi :)
Thanks Martyn for the review. I'll try to clarify how this
backup/restore metadata works.
Summary:
It looks to me like a lot of work is still needed to keep the code clean
and consistent with the current code base. There are a couple of leak
Hi!
> > #13. Is this a leak, looks like only str is freed, not service_type in
> > the if (!field):
> >
> > + gchar *str = NULL;
> > + gchar *uri;
> > + gchar *service_type;
> > +
> > + g_value_init (&transform, G_TYPE_STRING);
> > +
> > + tracke
On Tue, 2008-12-09 at 18:32 +0100, Philip Van Hoof wrote:
> Extra note
>
> This one is in the patch. I'm posting it a second time to catch
> Garnacho's full attention:
That's conceptually a leak of the hashtable value if the module is
overwriting several times the same field, right, but I think t
On Tue, 2008-12-16 at 12:54 +, Martyn Russell wrote:
I will attach a new patch as soon as Ivan fixed issues #13 and #15
> #1, Didn't we decide to depend on Raptor? If so, we don't need the
> AC_DEFINE right?
>
> +# Check for Raptor
> +PKG_CHECK_MODULES(RAPTOR, [raptor], have_raptor=yes, hav
On Tue, 2008-12-16 at 14:44 +, Martyn Russell wrote:
> On 16/12/08 14:40, Philip Van Hoof wrote:
> > Hi there,
> >
> > Here's a new patch
> >
> > svn merge -r 2696:2709 ../branches/turtle
> >
> > svn diff ain't adding the created files this time (for some reason), so
> > I added them manually t
On 16/12/08 14:40, Philip Van Hoof wrote:
Hi there,
Here's a new patch
svn merge -r 2696:2709 ../branches/turtle
svn diff ain't adding the created files this time (for some reason), so
I added them manually to this mail
No need to re-review, you can go ahead with the commit I think :) thanks
17 matches
Mail list logo
