On 08/08/14 08:58, Philip Van Hoof wrote:
In finalize:
+ if (priv->roots_to_notify) {
+ g_hash_table_unref (priv->roots_to_notify);
+ }
vs.
notify_roots_finished:
+ if (check_queues && g_hash_table_size (fs->priv->roots_to_notify) < 2) {
So if you check priv-
On 08/08/14 10:21, Philip Van Hoof wrote:
Maybe I'm getting a bit old and rusty with D-Bus and/or have things
changed since a few years ago ..
I'm going ahead with this, it's easily fixed later and it works now.
It should be possible to have a different D-Bus service name than
the object's pa
On 07/08/14 12:36, Martyn Russell wrote:
On 06/08/14 22:22, Sam Thursfield wrote:
diff --git a/src/libtracker-miner/tracker-file-system.c
b/src/libtracker-miner/tracker-file-system.c
index 7d9a236..dd81f49 100644
--- a/src/libtracker-miner/tracker-file-system.c
+++ b/src/libtracker-miner/tracker
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:56, Martyn Russell wrote:
> On 08/08/14 08:58, Philip Van Hoof wrote:
Reply inline below.
>> e5b5280b5f336b80b00d9c9671a72391ab1f0a9b
>>
>> +data->dbus_path = g_strdup_printf ("/%s", dbus_name); +
>> +p = data->dbus_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 11:11, Martyn Russell wrote:
> On 08/08/14 09:54, Philip Van Hoof wrote:
>> It will mess up your alignment and padding and that makes future
>> API changes more difficult. You'll need to know how the bit
>> fields will happen on each arch
On 08/08/14 10:08, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:56, Martyn Russell wrote:
Yah, just fix it anyway ;-)
Poor Aleksander. git blame is too good.
Yes, I thought it was Carlos who added the bitfield stuff but actually
it was me, that's why
On 08/08/14 09:54, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
c5d068279c9db7ac45e577b18b38d0bcb62b1d06
+ guint external_crawler : 1; /* TRUE if we're being feed files
+* instead of discovering them
+
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:56, Martyn Russell wrote:
Yah, just fix it anyway ;-)
Poor Aleksander. git blame is too good.
>> c2863b39b4e8f178c4d87ceee5d96ad0c3647585
>>
>> if (fs->priv->item_queue_blocker) { trace_eq (" cancelled: item
>> queue blocked wait
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:58, Philip Van Hoof wrote:
> On 8/08/2014 10:27, Philip Van Hoof wrote:
> Can you squash those two commits together before merging master?
>
> Just git rebase -i, you know the drill ;-)
8cdc0188e2c4d341e6e9788370e9381e085ae34b
- -
On 08/08/14 09:27, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
b291f85416674b4b7a54cded5f6e6fe8af22d181
+ if (!priv->root) {
+ g_object_unref (priv->root);
+ }
Perhaps this got fixed afterwards in a later commit and I missed it,
but it can't b
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:27, Philip Van Hoof wrote:
> b291f85416674b4b7a54cded5f6e6fe8af22d181
>
> + if (!priv->root) { +g_object_unref (priv->root); + }
>
> Perhaps this got fixed afterwards in a later commit and I missed
> it, but it can't
On 08/08/14 09:09, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
87c30cc73629ff54ff8e5170ded499c2cbbda61a
About TrackerEnumeratorIface:
In my opinion an enumerator has a Next() method to enumerate to the
next element. I think it's a bit wierd to return a linked list on
S
On 08/08/14 08:58, Philip Van Hoof wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I'll review in my slack time. So I'll do this chunk per chunk. Let's
start with the first few commits ;-)
e5b5280b5f336b80b00d9c9671a72391ab1f0a9b
+ data->dbus_path = g_strdup_printf ("/%s",
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
c5d068279c9db7ac45e577b18b38d0bcb62b1d06
+ guint external_crawler : 1; /* TRUE if we're being feed files
+* instead of discovering them
+* ourselves */
+ guint mtime_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
b291f85416674b4b7a54cded5f6e6fe8af22d181
+ if (!priv->root) {
+ g_object_unref (priv->root);
+ }
Perhaps this got fixed afterwards in a later commit and I missed it,
but it can't be right in this comment:
if the thing is NU
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/08/2014 10:09, Philip Van Hoof wrote:
> 87c30cc73629ff54ff8e5170ded499c2cbbda61a
Sorry it's like this instead of course:
> Enumerable thingThatHasItems = new List(); Enumerable e =
> thingThatHasItems.Enumerate(); // (not this but)
Enumerator e
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
87c30cc73629ff54ff8e5170ded499c2cbbda61a
About TrackerEnumeratorIface:
In my opinion an enumerator has a Next() method to enumerate to the
next element. I think it's a bit wierd to return a linked list on
Start() of the enumerator API.
You can find
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I'll review in my slack time. So I'll do this chunk per chunk. Let's
start with the first few commits ;-)
e5b5280b5f336b80b00d9c9671a72391ab1f0a9b
+ data->dbus_path = g_strdup_printf ("/%s", dbus_name);
+
+ p = data->dbus
On 06/08/14 22:22, Sam Thursfield wrote:
hi Martyn!
Hi Sam,
I reviewed the branch before comprehending your overview of what it
does, so there are some comments on patches that are later completely
overwritten. I've left them in case they are helpful in some way. It'd
be nice to squash a bunc
hi Martyn!
I reviewed the branch before comprehending your overview of what it does,
so there are some comments on patches that are later completely
overwritten. I've left them in case they are helpful in some way. It'd be
nice to squash a bunch of the commits in the branch together though before
Hello all,
I've recently been involved in a project to make Tracker the main
indexer and search engine for content on an embedded platform.
Part of that project is about making remote content available in
Tracker, for example: 3rd party online cloud based content.
This already presents some
21 matches
Mail list logo
