Re: [Tracker] REVIEW: external-crawler branch, part1

2014-08-12 Thread Martyn Russell
On 08/08/14 10:21, Philip Van Hoof wrote: Maybe I'm getting a bit old and rusty with D-Bus and/or have things changed since a few years ago .. I'm going ahead with this, it's easily fixed later and it works now. It should be possible to have a different D-Bus service name than the object's

Re: [Tracker] REVIEW: external-crawler branch, part1

2014-08-12 Thread Martyn Russell
On 08/08/14 08:58, Philip Van Hoof wrote: In finalize: + if (priv-roots_to_notify) { + g_hash_table_unref (priv-roots_to_notify); + } vs. notify_roots_finished: + if (check_queues g_hash_table_size (fs-priv-roots_to_notify) 2) { So if you check

[Tracker] REVIEW: external-crawler branch, part1

2014-08-08 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'll review in my slack time. So I'll do this chunk per chunk. Let's start with the first few commits ;-) e5b5280b5f336b80b00d9c9671a72391ab1f0a9b + data-dbus_path = g_strdup_printf (/%s, dbus_name); + + p =

Re: [Tracker] REVIEW: external-crawler branch, part1

2014-08-08 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 8/08/2014 10:56, Martyn Russell wrote: Yah, just fix it anyway ;-) Poor Aleksander. git blame is too good. c2863b39b4e8f178c4d87ceee5d96ad0c3647585 if (fs-priv-item_queue_blocker) { trace_eq ( cancelled: item queue blocked waiting for

Re: [Tracker] REVIEW: external-crawler branch, part1

2014-08-08 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 8/08/2014 10:56, Martyn Russell wrote: On 08/08/14 08:58, Philip Van Hoof wrote: Reply inline below. e5b5280b5f336b80b00d9c9671a72391ab1f0a9b +data-dbus_path = g_strdup_printf (/%s, dbus_name); + +p = data-dbus_path; +