Re: [Tracker] REVIEW: external-crawler branch, part3

2014-08-08 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 b291f85416674b4b7a54cded5f6e6fe8af22d181 + if (!priv->root) { + g_object_unref (priv->root); + } Perhaps this got fixed afterwards in a later commit and I missed it, but it can't be right in this comment: if the thing is NU

Re: [Tracker] REVIEW: external-crawler branch, part3

2014-08-08 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 8/08/2014 10:27, Philip Van Hoof wrote: > b291f85416674b4b7a54cded5f6e6fe8af22d181 > > + if (!priv->root) { +g_object_unref (priv->root); + } > > Perhaps this got fixed afterwards in a later commit and I missed > it, but it can't

Re: [Tracker] REVIEW: external-crawler branch, part3

2014-08-08 Thread Martyn Russell
On 08/08/14 09:27, Philip Van Hoof wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 b291f85416674b4b7a54cded5f6e6fe8af22d181 + if (!priv->root) { + g_object_unref (priv->root); + } Perhaps this got fixed afterwards in a later commit and I missed it, but it can't b

Re: [Tracker] REVIEW: external-crawler branch, part3

2014-08-08 Thread Philip Van Hoof
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 8/08/2014 10:58, Philip Van Hoof wrote: > On 8/08/2014 10:27, Philip Van Hoof wrote: > Can you squash those two commits together before merging master? > > Just git rebase -i, you know the drill ;-) 8cdc0188e2c4d341e6e9788370e9381e085ae34b - -