Note
I decided to make a branch for this on Codethink's git repos.
http://git.codethink.co.uk/?p=tracker;a=shortlog;h=push
http://git.codethink.co.uk/?p=tracker;a=commitdiff;h=8923218e08b250b96c269e42257e61e35044d0c3
On Tue, 2009-02-03 at 11:55 +0100, Philip Van Hoof wrote:
> This is a new patch
Hi Philip!
Overall, great patch :), makes things quite more generic. A few comments
about it:
* What about using GTypeModule and GInterfaces for the modules? you
could have a single module that implements one interface for the indexer
and other interface for trackerd.
* Do we really have to expo
On Wed, 2009-02-11 at 15:09 +0100, Carlos Garnacho wrote:
> Overall, great patch :), makes things quite more generic. A few comments
> about it:
>
> * What about using GTypeModule and GInterfaces for the modules? you
> could have a single module that implements one interface for the indexer
> and
Philip Van Hoof wrote:
On Wed, 2009-02-11 at 15:09 +0100, Carlos Garnacho wrote:
Overall, great patch :), makes things quite more generic. A few comments
about it:
* What about using GTypeModule and GInterfaces for the modules? you
could have a single module that implements one interface for t
On mié, 2009-02-11 at 15:15 +0100, Philip Van Hoof wrote:
> On Wed, 2009-02-11 at 15:09 +0100, Carlos Garnacho wrote:
>
> > Overall, great patch :), makes things quite more generic. A few comments
> > about it:
> >
> > * What about using GTypeModule and GInterfaces for the modules? you
> > could
On Wed, 2009-02-11 at 14:30 +, Martyn Russell wrote:
> Philip Van Hoof wrote:
> > Pausing, pre-committing and continuing it something I think will
> > eventually be necessary to add (for example a AddMany that adds really a
> > lot of triples, should pause+pre-commit, import, and then continue
On Wed, 2009-02-11 at 15:33 +0100, Carlos Garnacho wrote:
> >
> > Kinda like freeze/thaw.
>
> Hmm, I see... but I still think it's TrackerIndexer which should decide
> upon external factors, and not let 3rd party modules fiddle with
> tracker-indexer behavior, also it sounds to me like push modu
Philip Van Hoof wrote:
On Wed, 2009-02-11 at 14:30 +, Martyn Russell wrote:
Philip Van Hoof wrote:
Pausing, pre-committing and continuing it something I think will
eventually be necessary to add (for example a AddMany that adds really a
lot of triples, should pause+pre-commit, import, and
Philip Van Hoof wrote:
This is a new patch but with the indentation right for the two new files
this time
Hi Philip,
Some initial comments. I have not had a chance to try the new code yet.
#1, I don't have src/trackerd/tracker-push.[ch] to patch, so the patch
fails to apply. This also means
On Wed, 2009-02-11 at 17:55 +, Martyn Russell wrote:
> Philip Van Hoof wrote:
> > This is a new patch but with the indentation right for the two new files
> > this time
>
> Hi Philip,
>
> Some initial comments. I have not had a chance to try the new code yet.
>
>
> #1, I don't have src/trac
Philip Van Hoof wrote:
On Wed, 2009-02-11 at 17:55 +, Martyn Russell wrote
You can also just use git on this (branch is called push):
http://git.codethink.co.uk/?p=tracker;a=shortlog;h=push
OK thanks.
#2, Before we go on, can you explain ALL the libraries and what they do.
From the name
On Thu, 2009-02-12 at 10:15 +, Martyn Russell wrote:
> Philip Van Hoof wrote:
> > On Wed, 2009-02-11 at 17:55 +, Martyn Russell wrote
> > *-indexer-module.la is an 'indexer' module which runs in
> > tracker-indexer. It will pump the data actually into the database.
> >
> > *-daemon-modul
Philip Van Hoof wrote:
On Thu, 2009-02-12 at 10:15 +, Martyn Russell wrote:
+void
+tracker_push_registrar_set_object (TrackerPushRegistrar *registrar,
+ GObject *object)
+{
+ TrackerPushRegistrarPrivate *priv;
+
+ priv = TRACKER_PUSH_
ok, fair enough.
http://git.codethink.co.uk/?p=tracker;a=commitdiff;h=739e33a1a7175d8f481e0fa617cc388b7b7803a7
Was this the last remark before commit approval?
On Thu, 2009-02-12 at 11:39 +, Martyn Russell wrote:
> Philip Van Hoof wrote:
> > On Thu, 2009-02-12 at 10:15 +, Martyn Russell
Philip Van Hoof wrote:
ok, fair enough.
http://git.codethink.co.uk/?p=tracker;a=commitdiff;h=739e33a1a7175d8f481e0fa617cc388b7b7803a7
Was this the last remark before commit approval?
I just wanted to look at the files I didn't have,
trackerd/tracker-push.[ch] first. Will get back to you befo
Martyn Russell wrote:
Philip Van Hoof wrote:
ok, fair enough.
http://git.codethink.co.uk/?p=tracker;a=commitdiff;h=739e33a1a7175d8f481e0fa617cc388b7b7803a7
Was this the last remark before commit approval?
I just wanted to look at the files I didn't have,
trackerd/tracker-push.[ch] first.
Fixes for all four change requests are committed and pushed in the git
branch at Codethink's git.
Let me know when/if I can bring this to Subversion tracker/trunk
On Thu, 2009-02-12 at 14:26 +, Martyn Russell wrote:
> Martyn Russell wrote:
> > Philip Van Hoof wrote:
> >> ok, fair enough.
> >
Philip Van Hoof wrote:
Fixes for all four change requests are committed and pushed in the git
branch at Codethink's git.
Let me know when/if I can bring this to Subversion tracker/trunk
When you are done with the changes, sure, go ahead.
--
Regards,
Martyn
18 matches
Mail list logo
