Re: [Tracker] Request for review of writeback branch

2009-11-28 Thread Philip Van Hoof
On Fri, 2009-11-27 at 20:44 +0100, Juan A. Suarez Romero wrote: > On Sun, 2009-11-22 at 14:45 +0100, Philip Van Hoof wrote: > > Hi guys! > > > > I have rebased the writeback branch so that each commit in it is a ~ > > sensible one by either me or Carlos. > > > Is there any way of deactivating it

Re: [Tracker] Request for review of writeback branch

2009-11-27 Thread Juan A. Suarez Romero
On Sun, 2009-11-22 at 14:45 +0100, Philip Van Hoof wrote: > Hi guys! > > I have rebased the writeback branch so that each commit in it is a ~ > sensible one by either me or Carlos. Is there any way of deactivating it when building? J.A. ___ t

Re: [Tracker] Request for review of writeback branch

2009-11-25 Thread Martyn Russell
On 25/11/09 11:58, Philip Van Hoof wrote: On Wed, 2009-11-25 at 09:14 +, Martyn Russell wrote: On 22/11/09 13:45, Philip Van Hoof wrote: Hi guys! [cut] It looks really good though Philip and Carlos. Thanks for getting started on this. I have committed some code clean ups. Are there

Re: [Tracker] Request for review of writeback branch

2009-11-25 Thread Philip Van Hoof
On Wed, 2009-11-25 at 09:14 +, Martyn Russell wrote: > On 22/11/09 13:45, Philip Van Hoof wrote: > > Hi guys! > [cut] > It looks really good though Philip and Carlos. Thanks for getting > started on this. > > I have committed some code clean ups. Are there things left to do after your cod

Re: [Tracker] Request for review of writeback branch

2009-11-25 Thread Martyn Russell
On 22/11/09 13:45, Philip Van Hoof wrote: Hi guys! Hi Philip/Carlos, I started reviewing the code. I have committed some code clean ups and listed those here. Warning, some of these are pedantic :) - Please align function declaration variables - The copyright is 2009, not 2008 - copy+paste

[Tracker] Request for review of writeback branch

2009-11-22 Thread Philip Van Hoof
Hi guys! I have rebased the writeback branch so that each commit in it is a ~ sensible one by either me or Carlos. For now the XMP and the MP3 modules are only made to write back the title of the document. If you read the code you'll notice that no fundamental changes are needed to add more such