Re: [Tracker] Review of the new Evolution/Generic E-mail metadata support for Tracker

2009-01-15 Thread Martyn Russell
On 14/01/09 18:04, Philip Van Hoof wrote: On Wed, 2009-01-14 at 15:39 +, Martyn Russell wrote: Thanks Philip. OK, so I have finished commenting on the rest of the patch. I haven't been able to build it yet because I am still building the evolution development environment. So any further

Re: [Tracker] Review of the new Evolution/Generic E-mail metadata support for Tracker

2009-01-15 Thread Philip Van Hoof
On Thu, 2009-01-15 at 11:20 +, Martyn Russell wrote: On 14/01/09 18:04, Philip Van Hoof wrote: OK, from my point of view, we can commit this patch. Carlos are you happy with this too or do you have anything further to add? Carlos's final review happened on the bug. Committed as 2794 and

Re: [Tracker] Review of the new Evolution/Generic E-mail metadata support for Tracker

2009-01-14 Thread Philip Van Hoof
On Wed, 2009-01-14 at 15:39 +, Martyn Russell wrote: Thanks Philip. OK, so I have finished commenting on the rest of the patch. I haven't been able to build it yet because I am still building the evolution development environment. So any further comments will be appended here later.

Re: [Tracker] Review of the new Evolution/Generic E-mail metadata support for Tracker

2009-01-12 Thread Martyn Russell
On 09/01/09 13:48, Philip Van Hoof wrote: As promised. Please review Hi Philip, Superb wiki page, superb patch(es) and really really good work here! Most of my comments are really pedantic, so bare that in mind - there isn't much else to pick at :) -- #1, I am not sure

Re: [Tracker] Review of the new Evolution/Generic E-mail metadata support for Tracker

2009-01-12 Thread Martyn Russell
On 12/01/09 12:36, Martyn Russell wrote: On 09/01/09 13:48, Philip Van Hoof wrote: As promised. Please review Hi Philip, Superb wiki page, superb patch(es) and really really good work here! Most of my comments are really pedantic, so bare that in mind - there isn't much else to pick at :)

Re: [Tracker] Review of the new Evolution/Generic E-mail metadata support for Tracker

2009-01-09 Thread Philip Van Hoof
As promised. Please review I also attached the two remaining bugfixes for Evolution and Evolution's Data Server as patches. This patch depends on those bugfixes: http://bugzilla.gnome.org/show_bug.cgi?id=565082 http://bugzilla.gnome.org/show_bug.cgi?id=565681 This one is solved, reviewed and

[Tracker] Review of the new Evolution/Generic E-mail metadata support for Tracker

2009-01-07 Thread Philip Van Hoof
This Friday I will post a patch that will need a review. The patch implements this proposal. The people who are interested in reviewing it should read it first: http://live.gnome.org/Evolution/Metadata Short version: Several applications on our desktop computers and mobile devices want to know