[tryton-dev] Payment Lines hide in account_invoice

2014-02-12 Thread oscar_alvarez
Hi I am seeing that the payment lines was hide in this codereview: http://codereview.tryton.org/93/diff/1/invoice.py So, I think that to see this lines although the invoice is paid, is the better option, because it allows to know all payments detailed (more explicit). Oscar Alvarez Pre

[tryton-dev] tryton: Use a pool of connection

2014-02-12 Thread Code Review - New issues: ced
(No description) URL: http://codereview.tryton.org/3471002/

[tryton-dev] tryton: Use explicit callback instead of implicit gtk main iteration in rpc calls

2014-02-12 Thread Code Review - New issues: ced
The implicit gtk main iteration leads to bad ordered processing of events. So as explicit is better than implicit, rpc calls that don't need to block until the result use a callback. URL: http://codereview.tryton.org/3461002/

[tryton-dev] trytond: Better guess "selection_change_with" attribute

2014-02-12 Thread Code Review - New issues: ced
Testing on the instance for Selection field is not enough because some field selection could come from a Function field. So it is better to use a dick typing style in this case. issue3649 URL: http://codereview.tryton.org/3451002/

[tryton-dev] tryton: Missing removal of early attribute clearing in destroy

2014-02-12 Thread Code Review - New issues: ced
This one was missing in changeset 894fb914ef79 URL: http://codereview.tryton.org/3441002/