ComboKey has 4 constructors, no-arg, SimpleKey[], String[] and String. Both
the constructors which accept String[] and String are effectively defunct,
since they call the corresponding setValue() methods, which throw
TorqueException if the key field is null. Since it was called from the
constructory, and the key field is not initialized, these two constructors
will _always_ throw an exception.

I noticed that the code which constructs SimpleKeys from String[] and String
was commented out. However, I couldn't find any log message to support this.
Since SimpleKey is an abstract class, I guess "... new SimpleKey(..)"
doesn't really make sense.

How about either
a) remove the String[] and String-arg constructors
b) create StringKeys out of the String[] and String

Can submit the patch if someone provides some light.

Regards,
Kelvin Tan

Relevanz Pte Ltd
http://www.relevanz.com

180B Bencoolen St.
The Bencoolen, #04-01
S(189648)

Tel: 238 6229
Fax: 337 4417



--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to