[ 
https://issues.apache.org/jira/browse/TUSCANY-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535539
 ] 

Simon Laws commented on TUSCANY-1855:
-------------------------------------

Thanks Mark. Am just putting some more changes into domain-impl to make the 
domain model clearer and to make it easier for the web app story to work with 
the new domain apis. I'll roll your patch in with these. 

Thanks 

Simon

> Possible incorrect comparison in SCADomainImpl in the domain-impl project
> -------------------------------------------------------------------------
>
>                 Key: TUSCANY-1855
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1855
>             Project: Tuscany
>          Issue Type: Bug
>         Environment: Tuscany SVN revision #585076
> Linux
>            Reporter: Mark Combellack
>            Assignee: Simon Laws
>            Priority: Minor
>             Fix For: Java-SCA-Next
>
>         Attachments: DomainImplComparisonFix.patch
>
>
> I think there is a possible comparison problem in the SCADomainImpl class in 
> the domain-impl project. The code currently has:
>             for (QName nodeCompositeName : nodeInfo.getCompositeNames()){
>                 if (compositeName.equals(nodeCompositeName) ) {
>                     startNode = true;
>                 }
>             }
>             
>             if (startNode = true){
> Notice that there is only one equals ('=') character in the if comparison on 
> startNode. 
> Since this is an assignment, the if statement will always be true.
> Perhaps the code should read:
>             if (startNode == true){

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to