I like option A better. It also has the advantage that others
could create alternative experimental patches and post them
so that the results could be compared.
Simon
Jean-Sebastien Delfino wrote:
[snip]
Simon Nash wrote:
Thanks for getting these performance numbers. They confirm that
[EMAIL PROTECTED]
To: tuscany-dev@ws.apache.org
Sent: Thursday, September 13, 2007 5:18 PM
Subject: Re: Optimize the reference injection for java components
Yes, I agree. The only risk of doing this for stateless
components is that an improperly coded implementation
could malfunction due to left
5:18 PM
Subject: Re: Optimize the reference injection for java components
Yes, I agree. The only risk of doing this for stateless
components is that an improperly coded implementation
could malfunction due to left over state from the previous use.
Getting a clean instance every time will cover
[snip]
Simon Nash wrote:
Thanks for getting these performance numbers. They confirm that
an optimization for this case is needed. The question is whether
the current patch is the right fix, and also whether now is the
right time to apply it.
Consider the following case, which could also be a
If I understand this correctly, it would affect the lifecycle of
the target component instance. So when A has a reference to B,
the creation of A currently involves creating and injecting a B proxy
but not a B instance. With this change, I think the creation of A
would involve creating a B
Raymond,
Raymond Feng wrote:
Hi,
We use either JDK or CGLib proxies in reference injections for java
components. It is a bit heavy and unnecessary for some cases. I now add
a simple optimization to inject the implementation instance directly if
the following criteria are met:
1) Both the
Message -
From: Simon Nash [EMAIL PROTECTED]
To: tuscany-dev@ws.apache.org
Sent: Thursday, September 13, 2007 1:42 AM
Subject: Re: Optimize the reference injection for java components
If I understand this correctly, it would affect the lifecycle of
the target component instance. So when A has
Simon,
Some comments inline
Simon Nash wrote:
If I understand this correctly, it would affect the lifecycle of
the target component instance. So when A has a reference to B,
the creation of A currently involves creating and injecting a B proxy
but not a B instance. With this change, I
, September 13, 2007 1:42 AM
Subject: Re: Optimize the reference injection for java components
If I understand this correctly, it would affect the lifecycle of
the target component instance. So when A has a reference to B,
the creation of A currently involves creating and injecting a B proxy
but not a B
Comments inline
- Original Message -
From: Mike Edwards [EMAIL PROTECTED]
To: tuscany-dev@ws.apache.org
Sent: Thursday, September 13, 2007 11:44 AM
Subject: Re: Optimize the reference injection for java components
Simon,
Some comments inline
Simon Nash wrote:
If I understand
that multiple
requests will be routed to the same instance.
Thanks,
Raymond
- Original Message -
From: scabooz [EMAIL PROTECTED]
To: tuscany-dev@ws.apache.org
Sent: Thursday, September 13, 2007 1:57 PM
Subject: Re: Optimize the reference injection for java components
Comments inline
Folks,
Comments inline...
Raymond Feng wrote:
Even for the stateless case, I would argue it's legal to do the
optimization.
The SCA java spec says:
283 1.2.4.1. Stateless scope
284 For stateless components, there is no implied correlation between
service requests.
You've picked the
Folks,
Comments inline
Mike.
Simon Nash wrote:
By changing the lifecycle of the target instance I mean that it would
be created eagerly (on source reference creation) rather than lazily
(on source reference invocation) as is done currently. From looking
at the new code I believe this is
: Thursday, September 13, 2007 5:12 PM
Subject: Re: Optimize the reference injection for java components
Even for the stateless case, I would argue it's legal to do the
optimization.
The SCA java spec says:
283 1.2.4.1. Stateless scope
284 For stateless components, there is no implied correlation
@ws.apache.org
Sent: Thursday, September 13, 2007 5:18 PM
Subject: Re: Optimize the reference injection for java components
Yes, I agree. The only risk of doing this for stateless
components is that an improperly coded implementation
could malfunction due to left over state from the previous use.
Getting
Hi,
We use either JDK or CGLib proxies in reference injections for java
components. It is a bit heavy and unnecessary for some cases. I now add a
simple optimization to inject the implementation instance directly if the
following criteria are met:
1) Both the source and target are java
16 matches
Mail list logo
