Re: svn commit: r393402 - /incubator/tuscany/java/sca/model/src/main/java/org/apache/tuscany/model/scdl/loader/impl/SCDLAssemblyModelLoaderImpl.java

2006-04-12 Thread Jeremy Boynes
Jim Marino wrote: > Hi, > > I had a quick question about this class: why does it throw > IllegalArgumentException on lines 49 and 52 as opposed to another type > of exception? > There are several classes that throw IllegalArgument as part of model initialization. I have refactored a few of the

Re: svn commit: r393402 - /incubator/tuscany/java/sca/model/src/main/java/org/apache/tuscany/model/scdl/loader/impl/SCDLAssemblyModelLoaderImpl.java

2006-04-12 Thread Jim Marino
Yea we have been trying to keep most things under TuscanyRuntimeException or TuscanyException so that we can then add context as it is propagated up the stack (as well as have an exception hierarchy in the runtime). There are a few places we throw IllegalArgumentException but that is when t

Re: svn commit: r393402 - /incubator/tuscany/java/sca/model/src/main/java/org/apache/tuscany/model/scdl/loader/impl/SCDLAssemblyModelLoaderImpl.java

2006-04-12 Thread ant elder
I don't know the history of this class but other old Tuscany code I've seen did this to turn checked exceptions into unchecked ones. I could change it to AssemblyModelLoadException which is in the same package? ...ant On 4/12/06, Jim Marino <[EMAIL PROTECTED]> wrote: > > Hi, > > I had a quick

Re: svn commit: r393402 - /incubator/tuscany/java/sca/model/src/main/java/org/apache/tuscany/model/scdl/loader/impl/SCDLAssemblyModelLoaderImpl.java

2006-04-12 Thread Jim Marino
Hi, I had a quick question about this class: why does it throw IllegalArgumentException on lines 49 and 52 as opposed to another type of exception? Jim On Apr 12, 2006, at 12:07 AM, [EMAIL PROTECTED] wrote: Author: antelder Date: Wed Apr 12 00:07:23 2006 New Revision: 393402 URL: http:

Re: svn commit: r393402 - /incubator/tuscany/java/sca/model/src/main/java/org/apache/tuscany/model/scdl/loader/impl/SCDLAssemblyModelLoaderImpl.java

2006-04-12 Thread Jim Marino
Hi, I had a quick question about this class: why does it throw IllegalArgumentException on lines 49 and 52 as opposed to another type of exception? Jim On Apr 12, 2006, at 12:07 AM, [EMAIL PROTECTED] wrote: Author: antelder Date: Wed Apr 12 00:07:23 2006 New Revision: 393402 URL: http:/