Re: svn commit: r635435 - in /incubator/tuscany/java/sca/modules: assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ assembly/src/test/java/org/apache/tuscany/sca/assembly/builder/im

2008-03-11 Thread Simon Laws
Comments inline snip... and that's OK I think :) as binding.ws and binding.jsonrpc could end up on different port numbers for example (depending on their node configuration). And they might not. Actually, I was struggling to understand why we needed this test for duplicate names

Re: svn commit: r635435 - in /incubator/tuscany/java/sca/modules: assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ assembly/src/test/java/org/apache/tuscany/sca/assembly/builder/im

2008-03-11 Thread Jean-Sebastien Delfino
Simon Laws wrote: Comments inline snip... and that's OK I think :) as binding.ws and binding.jsonrpc could end up on different port numbers for example (depending on their node configuration). And they might not. Actually, I was struggling to understand why we needed this test for

Re: svn commit: r635435 - in /incubator/tuscany/java/sca/modules: assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ assembly/src/test/java/org/apache/tuscany/sca/assembly/builder/im

2008-03-10 Thread Simon Laws
On Mon, Mar 10, 2008 at 5:43 AM, [EMAIL PROTECTED] wrote: Author: jsdelfino Date: Sun Mar 9 22:43:19 2008 New Revision: 635435 URL: http://svn.apache.org/viewvc?rev=635435view=rev Log: Fixed algorithm in CompositeConfigurationBuilder to produce correct URIs, in particular avoid adding

Re: svn commit: r635435 - in /incubator/tuscany/java/sca/modules: assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ assembly/src/test/java/org/apache/tuscany/sca/assembly/builder/im

2008-03-10 Thread Jean-Sebastien Delfino
Simon Laws wrote: Hi There is now a test in the binding name creation code that checks that two service bing types are the same before testing for duplicate names. I don't think the binding type is relevant here. We should actually be testing that the scheme that the bindings intend to use