[Twisted-Python] incomplete reviews

2011-01-23 Thread Glyph Lefkowitz
Some reviewers (you know who you are!) have gotten into the habit of doing incomplete reviews, that note one or two trivial things about a patch or branch, but don't say whether the code is ready to land after fixing just those trivial things. I've updated the review process documentation to ad

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Glyph Lefkowitz
On Jan 23, 2011, at 9:29 PM, Jason J. W. Williams wrote: > On Sun, Jan 23, 2011 at 7:27 PM, Glyph Lefkowitz > wrote: >> >> On Jan 23, 2011, at 9:21 PM, Jason J. W. Williams wrote: >> >> Would it be that bad to just use a noisy check to toggle these on and >> off until a better logging system i

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jason J. W. Williams
On Sun, Jan 23, 2011 at 7:27 PM, Glyph Lefkowitz wrote: > > On Jan 23, 2011, at 9:21 PM, Jason J. W. Williams wrote: > > Would it be that bad to just use a noisy check to toggle these on and > off until a better logging system is available? > > No, that sounds like a fine solution for the interim.

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Glyph Lefkowitz
On Jan 23, 2011, at 9:21 PM, Jason J. W. Williams wrote: > Would it be that bad to just use a noisy check to toggle these on and > off until a better logging system is available? No, that sounds like a fine solution for the interim.___ Twisted-Python m

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jason J. W. Williams
On Sun, Jan 23, 2011 at 6:39 PM, Glyph Lefkowitz wrote: > Yes, logging in Twisted is a bit of a mess. > Almost all of these chatty little messages should not be logged to disk.  If > they're logged at all, they should be logged as purely structured data for > observers to analyze later, not as te

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Glyph Lefkowitz
On Jan 23, 2011, at 7:11 PM, Jarosław Fedewicz wrote: > My 2 cents to this is that responsiveness and performance of an application > has turned out to be severely impacted even by console output, disk output of > the same data being actually faster. Various tests have consistently shown > tha

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jarosław Fedewicz
On Jan 23, 2011, at 22:45 , Angelo Dell'Aera wrote: > I really think such verbose logging should be turned off > by default because it is quite useless to the end user and produces huge > amounts of logs which are useless as well. > > Cheers, > My 2 cents to this is that responsiveness and per

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Angelo Dell'Aera
On Sun, 23 Jan 2011 13:03:23 -0700 "Jason J. W. Williams" wrote: > Hi Guys, > > I'd like to get ticket 4021 integrated in some fashion into Twisted. > Currently, the Twisted Names client issues a "starting" and "stopping" > log message on every resolution. It fills up the logs and makes seeing >

[Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jason J. W. Williams
Hi Guys, I'd like to get ticket 4021 integrated in some fashion into Twisted. Currently, the Twisted Names client issues a "starting" and "stopping" log message on every resolution. It fills up the logs and makes seeing valuable log messages really difficult in the sea of DNS requests. 150,000

Re: [Twisted-Python] Weekly Bug Summary

2011-01-23 Thread Tristan Seligmann
On Sun, Jan 23, 2011 at 7:36 AM, Tom Davis wrote: >> >> Mean open ticket age: 1032 days >> >> Mean time between ticket creation and ticket resolution: 238 days >> >> Mean time spent in review: 83 days > > > Wow. Adding "reduce these by at least one order of magnitude" to my todo > list. Gotta hav

Re: [Twisted-Python] Refactoring Documentation

2011-01-23 Thread Glyph Lefkowitz
On Jan 23, 2011, at 12:55 AM, Tom Davis wrote: > But I'm drifting now, so shall drift in the direction of bed and pick things > up tomorrow... I think this thread has reached a nice point of consensus, so rather than keep flooding everybody's inboxes with 'me too', I'm going to withdraw until