Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Glyph Lefkowitz
> On Nov 22, 2016, at 21:36, Mark Williams wrote: > > > > On Tuesday, November 22, 2016, Glyph Lefkowitz > wrote: > > Okay. So. > > The rule for reverts like this is: if you do something today, which is >

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Glyph Lefkowitz
> On Nov 22, 2016, at 21:35, John Santos wrote: > > Shouldn't this be "if you pass non-ascii text on py2, you'll get ..." ? Yes. Thanks for that catch :). -g___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread John Santos
Been lurking here, no cows in the fire, no irons in the race, or whatever, except wanting Twisted to be perfect and easy to use and being perennially confused by text encoding, but I did notice this: On 11/22/2016 9:03 PM, Glyph Lefkowitz wrote: [...] Okay. So. The rule for reverts like

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Mark Williams
On Tuesday, November 22, 2016, Glyph Lefkowitz wrote: > > > Okay. So. > > The rule for reverts like this is: if you do something today, which is > correct usage of the API and produces an observably correct result, will > that be broken in the future if we fix it? If

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Glyph Lefkowitz
> On Nov 22, 2016, at 20:27, Mark Williams wrote: > > On Tue, Nov 22, 2016 at 06:31:45PM -0500, Glyph Lefkowitz wrote: >> >> OK, this whole time I thought we were talking about a sensible application >> of text_type to the API, perhaps with some leniency for

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Mark Williams
On Tue, Nov 22, 2016 at 06:31:45PM -0500, Glyph Lefkowitz wrote: > > OK, this whole time I thought we were talking about a sensible application of > text_type to the API, perhaps with some leniency for bytes-ish-ness on python > 2. I haven't reviewed the PR, I was just responding to the

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Glyph Lefkowitz
> On Nov 22, 2016, at 18:27, Tristan Seligmann wrote: > > On Wed, 23 Nov 2016 at 01:26 Tristan Seligmann > wrote: > if PY3: > > Argh, the above should be if PY2 of course. OK, this whole time I thought we

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Tristan Seligmann
On Wed, 23 Nov 2016 at 01:14 Tristan Seligmann wrote: > On Tue, 22 Nov 2016 at 23:37 Glyph Lefkowitz > wrote: > > > This is the part that I'm worried about. It kinda seems like we're moving > toward "native string" being the type used in

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Tristan Seligmann
On Wed, 23 Nov 2016 at 01:26 Tristan Seligmann wrote: > if PY3: > Argh, the above should be if PY2 of course. ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Tristan Seligmann
On Tue, 22 Nov 2016 at 23:37 Glyph Lefkowitz wrote: > > This is the part that I'm worried about. It kinda seems like we're moving > toward "native string" being the type used in IRCClient, and *that* is > capital-W Wrong. Native strings are for Python-native types

Re: [Twisted-Python] Twisted 16.6.0rc1 Release Candidate Announcement

2016-11-22 Thread Glyph Lefkowitz
> On Nov 20, 2016, at 19:35, Mark Williams wrote: > > On Fri, Nov 18, 2016 at 05:36:16PM -0800, Glyph Lefkowitz wrote: >> >> "doesn't work" is a pretty black-and-white assessment. Are you anticipating >> a problem with the way the interface is specified that it can't