Re: [Twisted-Python] Running tests with monkeytype

> On Jun 21, 2020, at 10:18 PM, Craig Rodrigues wrote: > > > > On Sat, Jun 20, 2020 at 4:02 PM Tom Most > wrote: > > Let's definitely move to type annotations, since they are much more likely to > be correct due to validation by MyPy. > > To start, we'll need to r

Re: [Twisted-Python] Changing supported configurations regarding Unicode handling on Windows

> On Jun 19, 2020, at 4:37 AM, Amber Brown (hawkowl) > wrote: > > Hi all, > > The past week or so, I noticed failures in the Azure Pipelines CI (see > https://github.com/twisted/twisted/pull/1278 for the ticket with them, among > others) that were due to Python + Windows falling apart on mg

Re: [Twisted-Python] Changing supported configurations regarding Unicode handling on Windows

On Monday, 22 June 2020 08:06:22 BST Glyph wrote: > > On Jun 19, 2020, at 4:37 AM, Amber Brown (hawkowl) > > wrote: > > > > Hi all, > > > > The past week or so, I noticed failures in the Azure Pipelines CI (see > > https://github.com/twisted/twisted/pull/1278 for the ticket with them, > > among

[Twisted-Python] mypy integrated with CI for twisted

I have merged some more fixes for mypy to Twisted trunk branch. In trunk, you can run mypy with: *tox -e mypy* Currently this results in *171* errors, which is way down from >1000 errors a month ago. In addition, if you look at any new PR's there is a *Mypy Ubuntu* job running on Azure pipeline

Re: [Twisted-Python] Changing supported configurations regarding Unicode handling on Windows

On Mon, Jun 22, 2020 at 12:08 AM Glyph wrote: > > figure out a way to fix it after the immediate issue where folks with > non-ascii letters in their names can't submit PRs. > > Thanks so much for investigating! > > I worked with Michał Górny who helped me debug this. When Michał submits a PR fro