Re: [Twisted-Python] Black enabled in trunk

On Tue, Sep 15, 2020, at 7:26 AM, Kyle Altendorf wrote: > On 2020-09-14 13:43, Glyph wrote: > > >> On Sep 13, 2020, at 11:45 PM, Tom Most wrote: > >> To adjust the formatting: > >> > >> tox -e black-reformat > >> > >> The formatting is checked by a new GitHub Actions lint built. > > > > Could

Re: [Twisted-Python] Black enabled in trunk

On Monday, 14 September 2020 07:45:43 BST Tom Most wrote: > Hi all, > > Craig and I have been working to land a switch to The *Black* Coding Style > . It's in! > The tree has been reformatted >

Re: [Twisted-Python] doWrite on twisted.internet.tcp.Port

On Friday, 11 September 2020 19:28:13 BST Jean-Paul Calderone wrote: > On Fri, Sep 11, 2020 at 1:34 PM wrote: > > > Hey guys, > > > > > > > > Last year I hit a condition discussed in this ticket: > > https://twistedmatrix.com/trac/ticket/4759 for doWrite called on a > > twisted.internet.tcp.Port.

Re: [Twisted-Python] Black enabled in trunk

> On Sep 15, 2020, at 10:08 AM, Barry Scott wrote: > > How does this work with backwards compatibility? > There are lots of symbols are that not black right? PEP8 suggests (but does not mandate) snake_case identifiers where Twisted uses camelCase. But Black doesn't care at all about identifie

Re: [Twisted-Python] doWrite on twisted.internet.tcp.Port

> On Sep 15, 2020, at 10:05 AM, Barry Scott wrote: > > We do this so that we can open priv'ed ports that the children will share. > We drop priv's after the priv'ed ports are opened. A better way to do this might be to use something like the systemd activation endpoint, so you never need privil

Re: [Twisted-Python] Black enabled in trunk

On 2020-09-14 13:43, Glyph wrote: On Sep 13, 2020, at 11:45 PM, Tom Most wrote: To adjust the formatting: tox -e black-reformat The formatting is checked by a new GitHub Actions lint built. Could we possibly use something like this: https://github.com/cclauss/autoblack to just _do_ the fo