Re: [Twisted-Python] towncrier review policies and etiquette (and maybe releases too)

2020-10-21 Thread Glyph
I'd love to update these policy documents to have something explicitly org-wide, but until somebody has the time to go through and do that properly, this is generally a good assumption to have. > On Oct 21, 2020, at 1:59 PM, Tom Most wrote: > > I think that it's fine to fall back to the

Re: [Twisted-Python] towncrier review policies and etiquette (and maybe releases too)

2020-10-21 Thread Tom Most
I think that it's fine to fall back to the twisted/twisted policies[1] for any project in the Twisted GitHub organization. The workflow won't apply directly --- no Trac, etc. --- but the core "someone must review all changes" and "test all the things" principles are relevant. That's how I treat

[Twisted-Python] towncrier review policies and etiquette (and maybe releases too)

2020-10-21 Thread Kyle Altendorf
Where does towncrier stand on review policies and etiquette? I generally don't like to just jump into new projects and start reviewing and merging but I don't see other activity on that front nor do I see any guidance on how it should be done. If I know how to proceed properly then I might

Re: [Twisted-Python] revert / rework of "AMPv2" change?

2020-10-21 Thread Jonathan Bastien-Filiatrault
On 2020-10-20 04 h 57, adi at roiban.ro (Adi Roiban) wrote: > Just my 2 cents > I think that whether this should be reverted or reworked should be between > the person raising this issue (Glyph) and the author of the PR (Jonathan). Glyph has asked me to submit the type annotation work on AMP, I