Re: [Twisted-Python] Twisted 21.2.0 Release Announcement

Glyph, The 21.2.0 release branch is ready for review so that it can be merged back to trunk: https://github.com/twisted/twisted/pull/1514 Thanks. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-b

Re: [Twisted-Python] Klein?

I've used decorators that execute the route function and then fire a call back at the end. Here's a quick example of "metrics at the start of a request and at the end. ``` from functools import wraps from random import randint import time from klein import Klein from twisted.internet import defer

Re: [Twisted-Python] Post Release updates

On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: > > Isn't this just because incremental hasn't had a release since 17.5.0? > I added post= support way back in > https://github.com/twisted/incremental/pull/37, but that was after > 17.5.0. > > -- > Colin Watson (he/him)

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 4:47 PM Kyle Altendorf wrote: > > My point was that you missed a review and you missed running towncrier > and depending what release process you are following you missed a tag in > the branch and a post-release-version-change. You asked about how to > release but gave no

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 4:44 PM Amber Brown wrote: > > The ghost of ADHD present has smiled upon you this day! > > I added glyph, JP, and rodrigc as collaborators on the incremental project. > > Wow, thanks! Nice to see you! -- Craig ___ Twisted-Python

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On 2021-03-01 19:25, Craig Rodrigues wrote: On Mon, Mar 1, 2021 at 3:27 PM Kyle Altendorf wrote: On 2021-03-01 14:13, Craig Rodrigues wrote: On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: Isn't this just because incremental hasn't had a release since 17.5.0? I added post= support wa

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On Tue, 2 Mar 2021, at 11:35, Glyph wrote: > > > On Mar 1, 2021, at 11:13 AM, Craig Rodrigues wrote: > > > > > > > > On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: > >> > >> Isn't this just because incremental hasn't had a release since 17.5.0? > >> I added post= support way back in >

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

> On Mar 1, 2021, at 11:13 AM, Craig Rodrigues wrote: > > > > On Mon, Mar 1, 2021 at 9:13 AM Colin Watson > wrote: > > Isn't this just because incremental hasn't had a release since 17.5.0? > I added post= support way back in > https://github.com/twisted/increment

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 3:27 PM Kyle Altendorf wrote: > On 2021-03-01 14:13, Craig Rodrigues wrote: > > > On Mon, Mar 1, 2021 at 9:13 AM Colin Watson > > wrote: > > > >> Isn't this just because incremental hasn't had a release since 17.5.0? > >> I added post= support way back in > >> https://gith

Re: [Twisted-Python] Need help releasing new version of Twisted incremental

On 2021-03-01 14:13, Craig Rodrigues wrote: On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: Isn't this just because incremental hasn't had a release since 17.5.0? I added post= support way back in https://github.com/twisted/incremental/pull/37, but that was after 17.5.0. Oh wow! You ar

[Twisted-Python] Klein?

Is this the right place to ask klein questions? I'm writing a metrics plugin for Klein and I can't figure out how to inject a metrics handler so that I can get route, path, duration, and status code. What I'm doing now sucks because Klein and twisted interact in complex ways on Failure and status c

[Twisted-Python] Need help releasing new version of Twisted incremental

On Mon, Mar 1, 2021 at 9:13 AM Colin Watson wrote: > > Isn't this just because incremental hasn't had a release since 17.5.0? > I added post= support way back in > https://github.com/twisted/incremental/pull/37, but that was after > 17.5.0. > > Oh wow! You are right. Can someone help me release

Re: [Twisted-Python] Twisted 21.2.0 Release Announcement

Hurrah! Thanks to everyone who contributed! On Sun, Feb 28, 2021, at 2:27 AM, Craig Rodrigues wrote: > On behalf of Twisted Matrix Laboratories, I am honored to announce the > release of Twisted 21.2.0! > > There are two major announcements for this release: > > - *Python 2.7 support has been dr

Re: [Twisted-Python] Post Release updates

On Mon, Mar 01, 2021 at 08:57:56AM -0800, Craig Rodrigues wrote: > Unfortunately, I ran into a bug in Twisted incremental: > > File "/tmp/pip-req-build-zvf8johl/src/twisted/__init__.py", line 11, in > > from twisted._version import __version__ as version > File "/tmp/pip-req-build-z

Re: [Twisted-Python] Post Release updates

On Mon, Mar 1, 2021 at 2:38 AM Hynek Schlawack wrote: > > FWIW, I think it’s common (aka _I_ do it that way) that .post are indeed > post-releases like a documentation update that doesn’t warrant a proper > update. PEP 440 specifies it and RTD has good support for that. E.g. > https://www.attrs.o

Re: [Twisted-Python] Developer docs should be updated on wiki when steps changed in code?

On Wed, 3 Feb 2021 at 18:09, Glyph wrote: > > [snip] > > I can't quickly find the place where we agreed to this, but I think > several years ago at this point we had a discussion about moving *all* these > docs into the source tree. (If they're on the wiki, there's no review > process or even a

Re: [Twisted-Python] Post Release updates

> On 28. Feb 2021, at 21:42, Adi Roiban wrote: > > And we have not yet decided if the trunk should be using `.dev` or .post` :( > > https://twistedmatrix.com/trac/ticket/9542 > > I am +1 for .post1 ... as it has the semantic of a post release version. > while .dev0 is a pre-release. FWIW, I