> On Apr 28, 2021, at 2:43 PM, Richard van der Hoff wrote:
>
> On 28/04/2021 07:06, Glyph wrote:
>>> Is the SMTP code holding the Factory wrong? Or is it reasonable to expect
>>> the verification error to propagate into clientConnectionFailed - in which
>>> case, how could this work?
>>>
>>>
It's merged.
On Wed, Apr 28, 2021, at 3:07 AM, Adi Roiban wrote:
> Hi
>
> PR at https://github.com/twisted/twisted/pull/1592
>
> I hope we can get a quick review and make the trunk green again :)
>
> Cheeers
>
> On Wed, 28 Apr 2021 at 10:30, Adi Roiban wrote:
>> Hi,
>>
>> A quick diff to fix
On 28/04/2021 07:06, Glyph wrote:
Is the SMTP code holding the Factory
wrong? Or is it reasonable to expect the verification error to
propagate into clientConnectionFailed - in which case, how could this
work?
Thanks for your thoughts!
Hi Richard,
Sorry for the delayed response here.
Th
Hi
PR at https://github.com/twisted/twisted/pull/1592
I hope we can get a quick review and make the trunk green again :)
Cheeers
On Wed, 28 Apr 2021 at 10:30, Adi Roiban wrote:
> Hi,
>
> A quick diff to fix it... and a ticket
> https://twistedmatrix.com/trac/ticket/10187
>
> I will create a P
Hi,
A quick diff to fix it... and a ticket
https://twistedmatrix.com/trac/ticket/10187
I will create a PR and we can refine the fix during the review.
diff --git a/src/twisted/words/protocols/irc.py
b/src/twisted/words/protocols/irc.py
index 75300019b..a97abce2e 100644
--- a/src/twisted/words/p
Hi Wim,
Thanks for the report
On Tue, 27 Apr 2021 at 08:14, Wim Lewis wrote:
> TLDR: Twisted appears broken on PyPy 7.3.4 (aka "3.7.10")?
>
> I don't have time right now to set up a PyPy-capable environment and try
> to reproduce this, but perhaps someone does?
>
> Long version:
>
> Trunk has b
