Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

>> I am +0 on this change due to security reasons...but I do think that it will >> reduce a bit of the frustration for first time contributors. >> > > I'm +1; we've accepted a lot of cloud risk already, and this seems like a lot > of benefit for minimal additional risk. Is this asottile runni

Re: [Twisted-Python] Twisted 21.7.0 Pre-Release Announcement

> On Jul 15, 2021, at 9:00 AM, Richard van der Hoff wrote: > > We can't just go and add type annotations because we need to maintain > compatibility with older Twisted (to make it possible to package in Debian et > al). > > Any suggestions for keeping mypy happy? > Are you saying you need

Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

> On Jul 15, 2021, at 7:35 AM, Jean-Paul Calderone > wrote: > > Can you elaborate on this a little bit? First time contributors won't be > able to push a branch to twisted/twisted. Does giving pre-commit.ci > write access to twisted/twisted also give it write > acc

Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

> On Jul 15, 2021, at 7:25 AM, Adi Roiban wrote: > > I am +0 on this change due to security reasons...but I do think that it will > reduce a bit of the frustration for first time contributors. > I'm +1; we've accepted a lot of cloud risk already, and this seems like a lot of benefit for min

Re: [Twisted-Python] Twisted 21.7.0 Pre-Release Announcement

On Thu, 15 Jul 2021 at 17:02, Richard van der Hoff wrote: > On 11/07/2021 00:49, Glyph wrote: > > Thank you Adi! Very glad to see us collectively getting back on the > release-management horse again! And it was super encouraging to see how > quickly you were able to get this out, with all the a

Re: [Twisted-Python] Twisted 21.7.0 Pre-Release Announcement

On Thursday, 15 July 2021 17:00:06 BST Richard van der Hoff wrote: > On 11/07/2021 00:49, Glyph wrote: > > Thank you Adi! Very glad to see us collectively getting back on the > > release-management horse again! And it was super encouraging to see > > how quickly you were able to get this out, w

Re: [Twisted-Python] Twisted 21.7.0 Pre-Release Announcement

On 11/07/2021 00:49, Glyph wrote: Thank you Adi!  Very glad to see us collectively getting back on the release-management horse again!  And it was super encouraging to see how quickly you were able to get this out, with all the automation that everyone (not least of all yourself) has been build

Re: [Twisted-Python] Enable pre-commit.ci for twisted/twisted

On Thu, Jul 15, 2021 at 10:26 AM Adi Roiban wrote: > Hi, > > As part of this PR https://github.com/twisted/twisted/pull/1619 Thomas > has requested to enable the https://pre-commit.ci service for > twisted/twisted repository > > The pre-commit.ci is kind of an auto-pilot for our pre-commit > con

[Twisted-Python] Enable pre-commit.ci for twisted/twisted

Hi, As part of this PR https://github.com/twisted/twisted/pull/1619 Thomas has requested to enable the https://pre-commit.ci service for twisted/twisted repository The pre-commit.ci is kind of an auto-pilot for our pre-commit configuration. We already do post-commit checks via the pre-commit fr

Re: [Twisted-Python] Twisted 21.7.0 Pre-Release Announcement

On Sun, 11 Jul 2021 at 00:49, Glyph wrote: > Thank you Adi! Very glad to see us collectively getting back on the > release-management horse again! And it was super encouraging to see how > quickly you were able to get this out, with all the automation that > everyone (not least of all yourself)