Re: [Twisted-Python] please can haz code review -> Tor-ified Twisted Python HTTP proxy server - txtorhttpproxy

2015-08-11 Thread Aaron Gallagher
David Stainton writes: > If I get rid of this last terrible import: > from twisted.web._newclient import ResponseDone > > then I'm not sure how to detect when to call the finish() method here: > https://github.com/david415/txtorhttpproxy/blob/master/txtorhttpproxy/proxy.py#L38-L52 Fortunately, R

Re: [Twisted-Python] Call For Participation: a review rally before the race!

2014-10-09 Thread Aaron Gallagher
Glyph Lefkowitz writes: > I am looking for at least 4 volunteers for a "review rally" starting > on Monday, October 13. If each of 5 reviewers (the 4 volunteers, plus > myself) can review 2 tickets per day for one week, until Sunday, > October 19, we can clear 70 tickets, which should take care o

Re: [Twisted-Python] txsocksx 1.13.0.0 released (SOCKS clients for Twisted)

2013-10-05 Thread Aaron Gallagher
Glyph writes: > I'm super happy to see such widespread use of the endpoint API :-). It > looks like there's no endpoint string parser plugin, though; any > chance you'll be looking into adding that in a future release? Yes! This is definitely on my todo list, but it will be much more useful once

[Twisted-Python] txsocksx 1.13.0.0 released (SOCKS clients for Twisted)

2013-10-05 Thread Aaron Gallagher
Hi! txsocksx 1.13.0.0 has been released--the first stable 1.x release. This version has full implementations of client endpoints which wrap client endpoints and perform SOCKS 4, 4a, or 5 proxy negotiation. Additionally, txsocksx comes with support code to

Re: [Twisted-Python] Graceful shutdown

2013-08-28 Thread Aaron Gallagher
I didn't read over your code, but this is something that I've independently implemented. You can see my implementation at . The Site subclass does some other monitoring-related things, but you should be able to tease out just the graceful