Re: [Twisted-Python] Incremental vs. Black

2020-08-10 Thread Moshe Zadka
On Mon, Aug 10, 2020, at 07:29, Barry Scott wrote: > On Saturday, 1 August 2020 18:14:15 BST Moshe Zadka wrote: > > Hi all, > > > > I opened https://github.com/twisted/incremental/issues/55 a few days ago, > > and I'm wondering if anyone has any objecti

[Twisted-Python] Incremental vs. Black

2020-08-01 Thread Moshe Zadka
Hi all, I opened https://github.com/twisted/incremental/issues/55 a few days ago, and I'm wondering if anyone has any objection to me making a fix. I'm using incremental at work on a project that uses black, so this just means I have to run black each time there is a version update -- not the e

Re: [Twisted-Python] pydoctor 20.7.0

2020-07-03 Thread Moshe Zadka
Indeed, let me join on to the thanks! Awesome work Maarten! On Fri, Jul 3, 2020, at 16:24, Glyph wrote: > > On Jul 3, 2020, at 8:01 AM, Maarten ter Huurne > > wrote: > > > > Hi all, > > > > I'm happy to announce that a new release of pydoctor, the documentation > > extractor used by Twisted,

[Twisted-Python] Running tests with monkeytype

2020-06-19 Thread Moshe Zadka
Hi all, If you want to get a first rough draft of types for mypy, has anyone tried running the tests under monkeytype[1]? Moshe Z. [1] https://monkeytype.readthedocs.io/en/stable/___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https:/

Re: [Twisted-Python] [RFC] Drop support for Python 3.5 sometime after May 2021?

2020-05-13 Thread Moshe Zadka
May 2021 seems to be right around when Xenial (Which has 3.5) falls into ESM, so maybe we can wait? I don't have strong feelings, but it is a datapoint. Moshe Z. On Wed, May 13, 2020, at 22:13, Glyph wrote: > On May 13, 2020, at 10:04 PM, Amber Brown (hawkowl) > wrote: > > > > On 14/5/20 5:10

Re: [Twisted-Python] Running CPU bound function concurrently in twisted

2019-06-24 Thread Moshe Zadka
On Mon, Jun 24, 2019, at 17:24, Chengi Liu wrote: > How do I use more multiple CPU cores? I guess atleast the fact that twisted > app wont be blocking is good, but what would be a good way to use multiple > cores. It *really* depends on what is the function that is CPU heavy, and why it is CPU

Re: [Twisted-Python] Running CPU bound function concurrently in twisted

2019-06-24 Thread Moshe Zadka
On Mon, Jun 24, 2019, at 16:27, Chengi Liu wrote: > cpu_res *= yield *defer.*gatherResults*(cpus) Remember: This will not block the reactor (Good!) but will still limit you to one CPU core (in general, some caveats, but true.) If you are CPU bound, this is woefully underutilizing modern CPU res

Re: [Twisted-Python] Running CPU bound function concurrently in twisted

2019-06-24 Thread Moshe Zadka
Hi Cheng, deferToThread *returns* a deferred, and sends the work to a thread pool. The other two functions are useful for manipulating deferreds or other promises, but will not send work to a separate thread, so they cannot be used instead. The simple example is pretty simple, it's pretty much

[Twisted-Python] Theory and practice of Pull Requests

2017-09-28 Thread Moshe Zadka
FYI, I opened https://twistedmatrix.com/trac/ticket/9292 which seeks to realign our theory (what we say in CONTRIBUTING) and what we do in practice regarding pull requests on GitHub. Please comment on the ticket if you see any issues! Moshe Z. ___ Twiste

Re: [Twisted-Python] Changing procmon.ProcessMonitor.processes

2017-09-20 Thread Moshe Zadka
attribute, much less promise the concrete class of its contents. Objections? Ticket: https://twistedmatrix.com/trac/ticket/9287 On Wed, Sep 20, 2017 at 1:34 AM ex vito wrote: > On 2017-09-19, at 15:49, Moshe Zadka wrote: > > On Tue, Sep 19, 2017 at 3:51 AM ex vito wrote: > > &g

Re: [Twisted-Python] How to correctly run Sqlite with Twisted?

2017-09-19 Thread Moshe Zadka
The best answer is probably https://github.com/alex/alchimia On Tue, Sep 19, 2017 at 1:59 PM Goffi wrote: > Hello, > > I'm using Sqlite3 module through Twisted's enterpirse.adbapi, I create the > ConnectionPool instance like this: > >self.dbpool = ConnectionPool("sqlite3", db_filename, > che

Re: [Twisted-Python] Changing procmon.ProcessMonitor.processes

2017-09-19 Thread Moshe Zadka
On Tue, Sep 19, 2017 at 3:51 AM ex vito wrote: > Other than that, again, per that section's rules, not being a commiter > myself, I'm in no position to approve such a change. I wonder, however, how > "urgent" such a final change is to you and why a deprecation cycle does not > fit your purpose (

Re: [Twisted-Python] Changing procmon.ProcessMonitor.processes

2017-09-18 Thread Moshe Zadka
On Mon, Sep 11, 2017 at 2:44 AM ex vito wrote: > Sidenote: A quick, mostly backwards compatible, change could probably add > cwd to the existing per-process tuple in self.processes as an extra item, > couldn't it? No. Most usage of this tuple is unpacking, which makes it really really not backw

[Twisted-Python] Changing procmon.ProcessMonitor.processes

2017-09-10 Thread Moshe Zadka
Hello all, For context, please read bullet one of Glyph's comment on https://twistedmatrix.com/trac/ticket/3691#comment:9 I am in a similar situation to JP 8 years ago -- I want to add a working directory argument to addProcess, so that processes that care (usually for silly reasons) about their

Re: [Twisted-Python] Proposal -- Code of Conduct

2015-06-28 Thread Moshe Zadka
7 PM Kevin Turner wrote: > I'm generally +1 on the idea of having a CoC. > > I'm content to delegate the details to subcommittee, so maybe I should > leave it at that, but I find there's one point I want to reinforce here: > > > On Sun, Jun 21, 2015, at 08:46 A

Re: [Twisted-Python] Proposal -- Code of Conduct

2015-06-21 Thread Moshe Zadka
Some repilies to all the issues mentioned here: 1. I think we should definitely maintain our own copy. Sorry for it not being a fork, the only non-formatting changes I made are things that referrred to the Django-run events (since we don't run events -- I did replace some of this language with men

[Twisted-Python] Proposal -- Code of Conduct

2015-06-20 Thread Moshe Zadka
Hi everyone, I am sure everyone understands that the Twisted community would love more diversity. While it is hard to achieve, it should be easy to remove one of the obvious blockers -- making underrepresented groups feel more welcome. I think, and hope, that our IRC channel, our issue system and

Re: [Twisted-Python] INCOMPATIBLE CHANGE: Adding "parent" as a required attribute to IService

2015-06-04 Thread Moshe Zadka
On Thu, Jun 4, 2015 at 11:50 AM Glyph wrote: > I'm in favor of this change > ... > Other non-inheriting IService implementations have it too, at least from > what I have heard on IRC so far. > I haven't heard anything on IRC, but maybe you're thinking of Tristan's e-mail here: https://twistedm

[Twisted-Python] INCOMPATIBLE CHANGE: Adding "parent" as a required attribute to IService

2015-06-03 Thread Moshe Zadka
IService's docstrings obliquely referred to a "parent" attribute, but have not actually specified its type or existence. This change makes this attribute mandatory. It also makes the existence of the other IService attributes, running and name, enforced by verifyObject. The ticket is available her

Re: [Twisted-Python] Multiple plugins in "twistd"

2015-05-20 Thread Moshe Zadka
FYIFYI -- Patch attached. Docs are missing, but I'm sure JP/Glyph will be happy to tell me what I've done wrong otherwise :-P On Wed, May 20, 2015 at 7:40 PM Moshe Zadka wrote: > FYI, https://twistedmatrix.com/trac/ticket/7907#ticket created. > > On Wed, May 20, 2015 at

Re: [Twisted-Python] Multiple plugins in "twistd"

2015-05-20 Thread Moshe Zadka
FYI, https://twistedmatrix.com/trac/ticket/7907#ticket created. On Wed, May 20, 2015 at 7:31 PM Moshe Zadka wrote: > Hi glyph and exarkun, > > [1] The compose syntax is the least interesting part for me here, and > seems to cause the most bike-shedding, so I think I will punt on tha

Re: [Twisted-Python] Multiple plugins in "twistd"

2015-05-20 Thread Moshe Zadka
Hi glyph and exarkun, [1] The compose syntax is the least interesting part for me here, and seems to cause the most bike-shedding, so I think I will punt on that. Instead, I will write a function called "compose()" which can be used from .tac files or possibly other plug-ins, leaving the issue of

Re: [Twisted-Python] Multiple plugins in "twistd"

2015-05-19 Thread Moshe Zadka
OK, so let me once again enumerate the tickets I'm going to open, because it seems like we're reaching consensus: [1] PROVIDES (pretty much as written: exarkun -- the idea is to walk up the hierarchy and then back down, so I did mean IService -- go up until you find a root, then go down and get al

[Twisted-Python] Multiple plugins in "twistd"

2015-05-19 Thread Moshe Zadka
Background Currently, "twistd" assumes one-run-one-plugin. It would be nice to load up multiple plug-ins in Twisted, for many reasons. These include: serving the same in-memory content via separate protocols, adding manhole to other plug-ins (so the end-deployer can add it to other things, as oppo