Re: [Twisted-Python] t.test.proto_helpers.StringTransportWithDisconnection.connectionLost

2013-05-22 Thread Adi Roiban
[snip] >> I have a test which always fails when running `trial twisted.test` but >> pass if executed as an individual tests this is due to a failure >> which is only raised at garbage collection. > > > Wait, related to this problem? I would expect the test to just try and use > the thing that

Re: [Twisted-Python] t.test.proto_helpers.StringTransportWithDisconnection.connectionLost

2013-05-22 Thread Laurens Van Houtven
On Wed, May 22, 2013 at 1:47 PM, Adi Roiban wrote: > Thanks. Did that. http://twistedmatrix.com/trac/ticket/6521 > Awesome, thank you :) > I have a test which always fails when running `trial twisted.test` but > pass if executed as an individual tests this is due to a failure > which is on

Re: [Twisted-Python] t.test.proto_helpers.StringTransportWithDisconnection.connectionLost

2013-05-22 Thread Adi Roiban
On 22 May 2013 12:20, Glyph wrote: > > On May 22, 2013, at 12:01 AM, Adi Roiban wrote: > > Is this a bug in the current implementation of > StringTransportWithDisconnection? > > > Yes. Good catch. Please look to see if the ticket has already been filed, > and if not, file one (ideally with a pa

Re: [Twisted-Python] t.test.proto_helpers.StringTransportWithDisconnection.connectionLost

2013-05-22 Thread Glyph
On May 22, 2013, at 12:01 AM, Adi Roiban wrote: > Is this a bug in the current implementation of > StringTransportWithDisconnection? Yes. Good catch. Please look to see if the ticket has already been filed, and if not, file one (ideally with a patch!) -glyph_

[Twisted-Python] t.test.proto_helpers.StringTransportWithDisconnection.connectionLost

2013-05-22 Thread Adi Roiban
Hi, In proto_helpers, StringTransportWithDisconnection is implemented as: class StringTransportWithDisconnection(StringTransport): def loseConnection(self): if self.connected: self.connected = False self.protocol.connectionLost(error.ConnectionDone("Bye."))