Re: [Twisted-Python] INCOMPATIBLE CHANGE: Adding "parent" as a required attribute to IService

2015-06-04 Thread Glyph
> On Jun 4, 2015, at 7:18 PM, Moshe Zadka wrote: > > > On Thu, Jun 4, 2015 at 11:50 AM Glyph > wrote: > I'm in favor of this change > ... > Other non-inheriting IService implementations have it too, at least from > what I have heard on IRC so far. > > I have

Re: [Twisted-Python] INCOMPATIBLE CHANGE: Adding "parent" as a required attribute to IService

2015-06-04 Thread Moshe Zadka
On Thu, Jun 4, 2015 at 11:50 AM Glyph wrote: > I'm in favor of this change > ... > Other non-inheriting IService implementations have it too, at least from > what I have heard on IRC so far. > I haven't heard anything on IRC, but maybe you're thinking of Tristan's e-mail here: https://twistedm

Re: [Twisted-Python] INCOMPATIBLE CHANGE: Adding "parent" as a required attribute to IService

2015-06-04 Thread Glyph
> On Jun 3, 2015, at 10:23 PM, Moshe Zadka wrote: > > IService's docstrings obliquely referred to a "parent" attribute, but have > not actually specified its type or existence. This change makes this > attribute mandatory. It also makes the existence of the other IService > attributes, runnin

[Twisted-Python] INCOMPATIBLE CHANGE: Adding "parent" as a required attribute to IService

2015-06-03 Thread Moshe Zadka
IService's docstrings obliquely referred to a "parent" attribute, but have not actually specified its type or existence. This change makes this attribute mandatory. It also makes the existence of the other IService attributes, running and name, enforced by verifyObject. The ticket is available her