Re: [Twisted-Python] Names DNS Client too chatty

2011-01-25 Thread Jason J. W. Williams
On Mon, Jan 24, 2011 at 10:01 PM, Glyph Lefkowitz wrote: > While I agree with the general sentiment (incremental improvements that can > be done now are pretty much always better than gigantic overhauls that have > to be put off until later) the current logging system is already pretty much > des

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-24 Thread Glyph Lefkowitz
On Jan 24, 2011, at 1:18 PM, Jason J. W. Williams wrote: > In my opinion this has been a problem for a very long time, and it > would be better to have a correction that fits the majority of cases > with a small code change now rather than wait for the perfect log > system. These changes don't pr

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-24 Thread Yaroslav Fedevych
On Jan 24, 2011, at 8:09 PM, exar...@twistedmatrix.com wrote: > On 05:24 pm, jasonjwwilli...@gmail.com wrote: >> If there's no objections the rest of today, I'll make sure the 4021 >> patch still applies and see what could be done as a test. > > I think it would be sad to lose the port starting

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-24 Thread Jason J. W. Williams
In my opinion this has been a problem for a very long time, and it would be better to have a correction that fits the majority of cases with a small code change now rather than wait for the perfect log system. These changes don't preclude a better logger and way of filtering these out in the future

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-24 Thread exarkun
On 05:24 pm, jasonjwwilli...@gmail.com wrote: If there's no objections the rest of today, I'll make sure the 4021 patch still applies and see what could be done as a test. I think it would be sad to lose the port starting up log messages. Sure, they're a nuisance if you start and stop 50k port

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-24 Thread Jason J. W. Williams
If there's no objections the rest of today, I'll make sure the 4021 patch still applies and see what could be done as a test. -J On Mon, Jan 24, 2011 at 3:40 AM, Phil Mayers wrote: > On 01/24/2011 02:43 AM, Glyph Lefkowitz wrote: >> >> Personally I'd say 'false'.  This is technically a change in

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-24 Thread exarkun
On 10:40 am, p.may...@imperial.ac.uk wrote: >On 01/24/2011 02:43 AM, Glyph Lefkowitz wrote: >> >>Personally I'd say 'false'. This is technically a change in >>behavior, but I don't think that we should make guarantees about >>emitted log messages. Practically speaking, I've never seen any code >>

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-24 Thread Phil Mayers
On 01/24/2011 02:43 AM, Glyph Lefkowitz wrote: > > Personally I'd say 'false'. This is technically a change in > behavior, but I don't think that we should make guarantees about > emitted log messages. Practically speaking, I've never seen any code > which would care about an unstructured log mes

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Glyph Lefkowitz
On Jan 23, 2011, at 9:29 PM, Jason J. W. Williams wrote: > On Sun, Jan 23, 2011 at 7:27 PM, Glyph Lefkowitz > wrote: >> >> On Jan 23, 2011, at 9:21 PM, Jason J. W. Williams wrote: >> >> Would it be that bad to just use a noisy check to toggle these on and >> off until a better logging system i

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jason J. W. Williams
On Sun, Jan 23, 2011 at 7:27 PM, Glyph Lefkowitz wrote: > > On Jan 23, 2011, at 9:21 PM, Jason J. W. Williams wrote: > > Would it be that bad to just use a noisy check to toggle these on and > off until a better logging system is available? > > No, that sounds like a fine solution for the interim.

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Glyph Lefkowitz
On Jan 23, 2011, at 9:21 PM, Jason J. W. Williams wrote: > Would it be that bad to just use a noisy check to toggle these on and > off until a better logging system is available? No, that sounds like a fine solution for the interim.___ Twisted-Python m

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jason J. W. Williams
On Sun, Jan 23, 2011 at 6:39 PM, Glyph Lefkowitz wrote: > Yes, logging in Twisted is a bit of a mess. > Almost all of these chatty little messages should not be logged to disk.  If > they're logged at all, they should be logged as purely structured data for > observers to analyze later, not as te

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Glyph Lefkowitz
On Jan 23, 2011, at 7:11 PM, Jarosław Fedewicz wrote: > My 2 cents to this is that responsiveness and performance of an application > has turned out to be severely impacted even by console output, disk output of > the same data being actually faster. Various tests have consistently shown > tha

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jarosław Fedewicz
On Jan 23, 2011, at 22:45 , Angelo Dell'Aera wrote: > I really think such verbose logging should be turned off > by default because it is quite useless to the end user and produces huge > amounts of logs which are useless as well. > > Cheers, > My 2 cents to this is that responsiveness and per

Re: [Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Angelo Dell'Aera
On Sun, 23 Jan 2011 13:03:23 -0700 "Jason J. W. Williams" wrote: > Hi Guys, > > I'd like to get ticket 4021 integrated in some fashion into Twisted. > Currently, the Twisted Names client issues a "starting" and "stopping" > log message on every resolution. It fills up the logs and makes seeing >

[Twisted-Python] Names DNS Client too chatty

2011-01-23 Thread Jason J. W. Williams
Hi Guys, I'd like to get ticket 4021 integrated in some fashion into Twisted. Currently, the Twisted Names client issues a "starting" and "stopping" log message on every resolution. It fills up the logs and makes seeing valuable log messages really difficult in the sea of DNS requests. 150,000