On 11:11 am, albert.bra...@weiermayer.com wrote:
>On Fri, Mar 26, 2010 at 12:08:02PM -, exar...@twistedmatrix.com
>wrote:
>>
>>So, are you sure this is testing what you think it's testing?
>
>Yes. This test was already there, and it failed in unexpected ways, so
>I
>had to look at it quite cl
On Fri, Mar 26, 2010 at 12:08:02PM -, exar...@twistedmatrix.com wrote:
>
> So, are you sure this is testing what you think it's testing?
Yes. This test was already there, and it failed in unexpected ways, so I
had to look at it quite closely. I'm not too happy about it, since it
tests sever
exar...@twistedmatrix.com wrote:
> On 10:25 am, albert.bra...@weiermayer.com wrote:
[...]
> >There is a unittest that assumes that dataReceives still works after
> >sending in garbage:
> >
> > def test_illegal(self):
> >"""
> >Assert that illegal strings cause the transport to be
On 10:25 am, albert.bra...@weiermayer.com wrote:
>On Thu, Mar 25, 2010 at 09:22:03AM +1100, Andrew Bennetts wrote:
>>
>>No; I think once loseConnection has been called dataReceived won't be
>>called again, so there's no point checking for brokenPeer in
>>dataReceived.
>
>There is a unittest that as
On Thu, Mar 25, 2010 at 09:22:03AM +1100, Andrew Bennetts wrote:
>
> No; I think once loseConnection has been called dataReceived won't be
> called again, so there's no point checking for brokenPeer in
> dataReceived.
There is a unittest that assumes that dataReceives still works after
sending in
On 08:36 am, albert.bra...@weiermayer.com wrote:
>On Thu, Mar 25, 2010 at 09:22:03AM +1100, Andrew Bennetts wrote:
>>I'm rather confused about why you're even asking this question.
>>Exactly
>>what API are you proposing as an alternative to the existing API
>>(which
>>is subclass NetstringReceive
On Thu, Mar 25, 2010 at 09:22:03AM +1100, Andrew Bennetts wrote:
> I'm rather confused about why you're even asking this question. Exactly
> what API are you proposing as an alternative to the existing API (which
> is subclass NetstringReceiver and override stringReceived, and
> stringReceived wil
Albert Brandl wrote:
> Hi!
>
> The NetstringReceiver class does not exactly do what I'd expect - see
> issue http://twistedmatrix.com/trac/ticket/4378. Since we plan to use
> netstrings, I am trying to fix it.
>
> I am not quite sure how to handle certain problems, though, and that's
> where I
Hi!
The NetstringReceiver class does not exactly do what I'd expect - see
issue http://twistedmatrix.com/trac/ticket/4378. Since we plan to use
netstrings, I am trying to fix it.
I am not quite sure how to handle certain problems, though, and that's
where I'd appreciate help. If this is the wr
