Re: [Twisted-Python] doPoll timeout problems

2018-10-18 Thread Wim Lewis
On Wed Oct 17 08:56:46 MDT 2018, Barry Scott wrote: > Do you want a pull request for this fix or will you make this small > change? Twisted's contribution process is kind of rigid: every PR needs an accompanying Trac ticket. If you file Trac tickets for these two issues I'll make the PRs (or you c

Re: [Twisted-Python] doPoll timeout problems

2018-10-17 Thread Barry Scott
On Wednesday, 17 October 2018 06:59:07 BST Glyph wrote: > > On Oct 16, 2018, at 7:28 PM, Wim Lewis wrote: > > > > Scott, Barry wrote: > >> We are seeing a problem with poll being called very often and think that > >> the problem is in the timeout calculation.> > > I think you're right and that c

Re: [Twisted-Python] doPoll timeout problems

2018-10-16 Thread Glyph
> On Oct 16, 2018, at 7:28 PM, Wim Lewis wrote: > > Scott, Barry wrote: >> We are seeing a problem with poll being called very often and think that the >> problem is in the timeout calculation. > > I think you're right and that changing that line to use ceil() is a good fix. > It does mean t

[Twisted-Python] doPoll timeout problems

2018-10-16 Thread Wim Lewis
Scott, Barry wrote: We are seeing a problem with poll being called very often and think that the problem is in the timeout calculation. I think you're right and that changing that line to use ceil() is a good fix. It does mean that some timeouts might happen up to a millisecond later than the

[Twisted-Python] doPoll timeout problems

2018-10-02 Thread Scott, Barry
We are seeing a problem with poll being called very often and think that the problem is in the timeout calculation. The code look like this: def doPoll(self, timeout): """Poll the poller for new events.""" if timeout is not None: timeout = int(timeout * 1000) # co