Re: [Twisted-Python] log.callWithLogger not used - slows down reactor?

2020-06-07 Thread Glyph
> On Jun 3, 2020, at 2:51 AM, Barry Scott wrote: > > On Wednesday, 3 June 2020 08:07:37 BST Glyph wrote: >>> On Jun 2, 2020, at 4:54 AM, Barry Scott >>> wrote: >>> >>> I'm hunting down performance issue in our code and spotted this in >>> passing. As far I can tell nothing seems to need callWit

Re: [Twisted-Python] log.callWithLogger not used - slows down reactor?

2020-06-03 Thread Barry Scott
On Wednesday, 3 June 2020 08:07:37 BST Glyph wrote: > > On Jun 2, 2020, at 4:54 AM, Barry Scott > > wrote: > > > > I'm hunting down performance issue in our code and spotted this in > > passing. As far I can tell nothing seems to need callWithLogger. > > > > I ran our 6k+ tests with this patch a

Re: [Twisted-Python] log.callWithLogger not used - slows down reactor?

2020-06-03 Thread Glyph
> On Jun 2, 2020, at 4:54 AM, Barry Scott wrote: > > I'm hunting down performance issue in our code and spotted this in > passing. As far I can tell nothing seems to need callWithLogger. > > I ran our 6k+ tests with this patch applied and everything worked. > > Does anything in the twisted wo

[Twisted-Python] log.callWithLogger not used - slows down reactor?

2020-06-02 Thread Barry Scott
I'm hunting down performance issue in our code and spotted this in passing. As far I can tell nothing seems to need callWithLogger. I ran our 6k+ tests with this patch applied and everything worked. Does anything in the twisted world need it? Barry diff --git a/src/twisted/internet/pollreactor.