Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Dulepov
Hi! Dmitry Martynenko wrote: > But I think it is axiom: less data and shorter keys -> more speed to SELECT. Less data and good keys for executed queries -> more speed to SELECT. Just making keys short will not improve speed. If there are a lot of records and key is partial. MySQL will search da

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Dulepov
Hi! Mathias Schreiber [wmdb >] wrote: > But the "amount of combinations" issue might be interesting to calculate. > I am not sure if anyone has ever beaten the 1 billion marker, plus mysql > itself might perform rather odd with tables this big, regardles of their > content. It is not just a numbe

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Martynenko
Hi Dan, >> But I think it is axiom: less data and shorter keys -> more speed >> to SELECT. DO> Sure, but the question is by how much. It doesn't matter that the look DO> up is fast if it gives the wrong result. So its a trade off between DO> accuracy and speed - and in this case I think accuracy

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Martynenko
Hi Dmitry, >> As far as cHash is concerned instead of doing an MD5 hash you could >> simply do CRC32() in mysql. DD> Yes, crc32 function also exists in the PHP. But I doubt that 32 DD> bits is enough for many possible combinations of URLs. I think the same. Unfortunately MD5 does not guarantee

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dan Osipov
> But I think it is axiom: less data and shorter keys -> more speed to SELECT. Sure, but the question is by how much. It doesn't matter that the look up is fast if it gives the wrong result. So its a trade off between accuracy and speed - and in this case I think accuracy takes priority. Dan

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Xavier Perseguers
Hi, > Now I have tx_realurl_chashcache table like (it differs from standart > RealURL table - spurl_hash already store full MD5 value): > > CREATE TABLE `tx_realurl_chashcache` ( > `spurl_hash` VARCHAR(32) NOT NULL DEFAULT '', > `chash_string` VARCHAR(10) NOT NULL DEFAULT '', > ) > > If exte

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Martynenko
Hi Dan, DO> I think the 32 char value must be used, to prevent collisions and DO> guarantee (almost) the uniqueness. How slow does it make the table DO> seeks? And what table are we talking about - I think DO> tx_realurl_chashcache only looks up by spurl_hash. I write yesterday about it in anot

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Mathias Schreiber [wmdb >]
Dmitry Dulepov schrieb: > Hi! > > Mathias Schreiber [wmdb >] wrote: >> As far as cHash is concerned instead of doing an MD5 hash you could >> simply do CRC32() in mysql. > > Yes, crc32 function also exists in the PHP. But I doubt that 32 bits is > enough for many possible combinations of URLs.

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dan Osipov
I think the 32 char value must be used, to prevent collisions and guarantee (almost) the uniqueness. How slow does it make the table seeks? And what table are we talking about - I think tx_realurl_chashcache only looks up by spurl_hash. Dan Osipov Calkins Media http://danosipov.com/blog/ Dmitr

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dan Osipov
But is the hash unique & fast for lookups? Dan Osipov Calkins Media http://danosipov.com/blog/ Dmitry Dulepov wrote: > Hi! > > Dmitry Martynenko wrote: >> Now I have tx_realurl_chashcache table like (it differs from standart >> RealURL table - spurl_hash already store full MD5 value): >> >> CREA

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Dulepov
Hi! Mathias Schreiber [wmdb >] wrote: > As far as cHash is concerned instead of doing an MD5 hash you could > simply do CRC32() in mysql. Yes, crc32 function also exists in the PHP. But I doubt that 32 bits is enough for many possible combinations of URLs. -- Dmitry Dulepov TYPO3 core team "So

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Mathias Schreiber [wmdb >]
Dmitry Dulepov schrieb: > Hi! > > Mathias Schreiber [wmdb >] wrote: >>> md5 provides uniqueness only if it is full 32-bit value. Using 16 bit >>> will decrease probablity of conflict but will not eliminate it. >> Why not use integers anyways? > > Integer as a URL hash? As far as cHash is concern

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Dulepov
Hi! Dmitry Martynenko wrote: > Now I have tx_realurl_chashcache table like (it differs from standart > RealURL table - spurl_hash already store full MD5 value): > > CREATE TABLE `tx_realurl_chashcache` ( > `spurl_hash` VARCHAR(32) NOT NULL DEFAULT '', > `chash_string` VARCHAR(10) NOT NULL DEF

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Dulepov
Hi! Mathias Schreiber [wmdb >] wrote: >> md5 provides uniqueness only if it is full 32-bit value. Using 16 bit >> will decrease probablity of conflict but will not eliminate it. > > Why not use integers anyways? Integer as a URL hash? -- Dmitry Dulepov TYPO3 core team "Sometimes they go bad. N

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Martynenko
Hi Dmitry, >>> May be better solution is to decrease key length - for example use 16 >>> byte (binary) MD5 value, instead of 32 chars value. In any case they are >>> equal. >>> Binary comparison is always faster then text comparison. Because text >>> comparison also takes in account character set

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Martynenko
Hi Dmitry, >> May be better solution is to decrease key length - for example use 16 >> byte (binary) MD5 value, instead of 32 chars value. In any case they are >> equal. >> Binary comparison is always faster then text comparison. Because text >> comparison also takes in account character sets and

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Mathias Schreiber [wmdb >]
Dmitry Dulepov schrieb: > Hi! > > Dmitry Martynenko wrote: >> May be better solution is to decrease key length - for example use 16 >> byte (binary) MD5 value, instead of 32 chars value. In any case they are >> equal. >> Binary comparison is always faster then text comparison. Because text >> com

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Tomaž Zaman
Already placed the order :) Thanx for help On 1/19/09 10:32 AM, "Dmitry Dulepov" wrote: > Hi! Tomaž Zaman wrote: > One newbie question, if I build my own extension, > extending pibase, do I > need to use these Chashes with my links (links are > mostly in listview, > pointing to single view).

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Dulepov
Hi! Tomaž Zaman wrote: > One newbie question, if I build my own extension, extending pibase, do I > need to use these Chashes with my links (links are mostly in listview, > pointing to single view). And if yes, why? http://typo3bloke.net/post-details/linking_properly_in_your_typo3_code/ or buy t

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Dulepov
Hi! Dmitry Martynenko wrote: > May be better solution is to decrease key length - for example use 16 > byte (binary) MD5 value, instead of 32 chars value. In any case they are > equal. > Binary comparison is always faster then text comparison. Because text > comparison also takes in account chara

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Mathias Schreiber [wmdb >]
Tomaž Zaman schrieb: > One newbie question, if I build my own extension, extending pibase, do I > need to use these Chashes with my links (links are mostly in listview, > pointing to single view). And if yes, why? cHashes are used to bring a page into different "states". Example: Page 14 has an e

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Tomaž Zaman
One newbie question, if I build my own extension, extending pibase, do I need to use these Chashes with my links (links are mostly in listview, pointing to single view). And if yes, why? Thank you. Tom On 1/19/09 9:53 AM, "Dmitry Martynenko" wrote: > Hi guys! > This is an extremely seri

Re: [TYPO3-english] Duplicate cHash values

2009-01-19 Thread Dmitry Martynenko
Hi guys! >>> This is an extremely serious issue for us, so I can write a patch. I >>> don't know where to start though - so any guidance you can provide is >>> appreciated. >> >> I am guessing > >> http://www.typo3-unleashed.net/typo3apidocs/typo3api_4.2.0/html/d8/d11/class_8tslib__fe_8php-sour

Re: [TYPO3-english] Duplicate cHash values

2009-01-17 Thread Dan Osipov
Thanks! I'll look into it. Dan Osipov Calkins Media http://danosipov.com/blog/ Georg Ringer wrote: > Dan Osipov wrote: >> This is an extremely serious issue for us, so I can write a patch. I >> don't know where to start though - so any guidance you can provide is >> appreciated. > > I am gues

Re: [TYPO3-english] Duplicate cHash values

2009-01-17 Thread Georg Ringer
Dan Osipov wrote: > This is an extremely serious issue for us, so I can write a patch. I > don't know where to start though - so any guidance you can provide is > appreciated. I am guessing > http://www.typo3-unleashed.net/typo3apidocs/typo3api_4.2.0/html/d8/d11/class_8tslib__fe_8php-source.htm

Re: [TYPO3-english] Duplicate cHash values

2009-01-17 Thread Dan Osipov
This is an extremely serious issue for us, so I can write a patch. I don't know where to start though - so any guidance you can provide is appreciated. Dan Osipov Calkins Media http://danosipov.com/blog/ Dmitry Dulepov wrote: > Hi! > > Georg Ringer wrote: >> Dmitry, do you wanna do the patch?

Re: [TYPO3-english] Duplicate cHash values

2009-01-17 Thread Dmitry Dulepov
Hi! Georg Ringer wrote: > Dmitry, do you wanna do the patch? Not before February :( -- Dmitry Dulepov TYPO3 core team "Sometimes they go bad. No one knows why" (Cameron, TSCC, "Dungeons&Dragons") ___ TYPO3-english mailing list TYPO3-english@lists.netf

Re: [TYPO3-english] Duplicate cHash values

2009-01-17 Thread Georg Ringer
Dmitry Dulepov wrote: > I am +1 to using longer cHash. +1 because - if no rewrite activated until know the url will just stay ugly - if rewrite is used (cooluri, realurl, simualatestatic, whatever), nothing will change (except less errors) Dmitry, do you wanna do the patch? Georg _

Re: [TYPO3-english] Duplicate cHash values

2009-01-17 Thread Dmitry Dulepov
Hi! Dan Osipov wrote: > We have a large installation, using TYPO3 4.2.3 and RealURL 1.5.2. > > In tx_realurl_chashcache we have duplicate cHash values corresponding to > different spurl_hash values. As a result, links end up going to the > wrong page. This is a serious flaw for a CMS!! > > What

[TYPO3-english] Duplicate cHash values

2009-01-16 Thread Dan Osipov
We have a large installation, using TYPO3 4.2.3 and RealURL 1.5.2. In tx_realurl_chashcache we have duplicate cHash values corresponding to different spurl_hash values. As a result, links end up going to the wrong page. This is a serious flaw for a CMS!! What can be done to fix this? Can we i