Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-15 Thread Xavier Perseguers
Hi Lars, Lars Patrick Heß wrote: > $mergedData = array_intersect_key($mergedData, $parsedTargetData); > $parsedData = array_intersect_key($mergedData, > $parsedData); Thanks for this. But please, as you have done a code review on review.typo3.org, please, please put

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-15 Thread Lars Patrick Heß
Now i am working with this version: protected function doParsingFromRootForElement(SimpleXMLElement $root, $element) { $bodyOfFileTag = $root->data->languageKey; // Check if the source llxml file contains localized records $localiz

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-15 Thread Lars Patrick Heß
Hi Dominique, i had cleared the cache many times, the language cache too… When i replace the function t3lib_div::readLLfile with the old one from a 4.5 branch, everything works fine! The new mechanism does sometimes not load the correct translations. In my opinion it happens when you are loadi

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-15 Thread Dominique Feyer
Hi everybody, During the review of the patch available on Gerrit, I think that it's not a bug ;) but a feature. 4.6 introduce a caching mechanism for the l10n parser (based on the caching framework). Lars, can you try this procedure: Add this line in your localconf.php $GLOBALS['TYPO3_CONF_VARS

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-15 Thread Xavier Perseguers
Hi Lars, Could you please do your review in Gerrit? You just have to log on https://review.typo3.org/#change,7269, put your typo3.org credentials and put your comments rights into the patch by double-clicking. So you found a bug in your code? Because I basically took your code. No problem of cour

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-15 Thread Lars Patrick Heß
Hi Xavier, i had tested your code in a customer project and it does not work correctly, i had changed it to this: protected function doParsingFromRootForElement(SimpleXMLElement $root, $element) { $bodyOfFileTag = $root->data->languageKey; // Che

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-15 Thread Xavier Perseguers
Hi Lars, > I can imagine, that there is a better way then unset all unneeded keys… Thanks for digging into this, I just reworked your patch to prevent a manual loop over all keys and pushed it to Gerrit on behalf of yourself: https://review.typo3.org/#change,7269 We have a short Skype meeting w

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-14 Thread Lars Patrick Heß
glish-boun...@lists.typo3.org >>> [mailto:typo3-english-boun...@lists.typo3.org] On Behalf Of Lars Patrick Heß >>> Sent: Wednesday, December 14, 2011 1:11 PM >>> To: TYPO3 English >>> Subject: Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since >>

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-14 Thread Lars Patrick Heß
ember 14, 2011 1:11 PM >> To: TYPO3 English >> Subject: Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since >> TYPO3 4.6? >> >> After some debugging the question came to my mind, why the parser for XML >> files always returned all available translation f

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-14 Thread Markus Klein
typo3.org] On Behalf Of Lars Patrick Heß > Sent: Wednesday, December 14, 2011 1:11 PM > To: TYPO3 English > Subject: Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since > TYPO3 4.6? > > After some debugging the question came to my mind, why the parser for XML > files

Re: [TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-14 Thread Lars Patrick Heß
After some debugging the question came to my mind, why the parser for XML files always returned all available translation for the "default" language when it is not available inside the default-node? So i change code inside the method "t3lib_l10n_parser_Llxml::doParsingFromRootForElement":

[TYPO3-english] Bug in locallangXMLOverride mechanism since TYPO3 4.6?

2011-12-13 Thread Lars Patrick Heß
Hey all :-) i am using the "locallangXMLOverride" in TYPO3 4.6 mechanism to override XML-languagefiles, i use the following line oh php code to configure the override in a localconf-file: $GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['path/to/originalTranslationFile.xml']