-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Monday, August 10, 2009 2:00 AM
To: Prafulla Wadaskar
Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH 6/8] tools: mkimage: Making
table_entry code global
Dear
Dear Wolfgang Denk,
Applied (after editing the commit message; hope this is OK).
No problem, the change commit message describes the right thing.
best regards
Jens Scharsig
___
U-Boot mailing list
U-Boot@lists.denx.de
Thanks Dirk, and ACK for all 3
On Sat, Aug 08, 2009 at 09:30:23AM +0200, Dirk Behme wrote:
replace variable types in ctrl_structs for omap3 by those with
fixed size (u8, u16, u32).
Additional ifndef-protection is needed by examples which do not
compile when including asm/types.h
Dear Ben,
In message 4a7fb519.6040...@gmail.com you wrote:
I thought I brought this up already, but maybe not. Won't this break
PowerPC? I'm pretty sure (value) != (cpu_to_le32(value)), isn't it?
Right.
Isn't the problem that writel() and readl() aren't byte-swapped on BE ARM?
Right.
Dear Roy Zang,
In message 1249018442.19764.4.ca...@rock.ap.freescale.net you wrote:
Based on Intel PRO/1000 Network Driver 7.3.20-k2
Add Intel E1000 PCIE card support. The following cards are added:
INTEL_82571EB_COPPER
INTEL_82571EB_FIBER,
INTEL_82571EB_SERDES
Dear Prafulla Wadaskar,
In message 1247758084-12296-4-git-send-email-prafu...@marvell.com you wrote:
With these fixes, this driver works properly for multi chip
addressging mode
Bugfixes:
1. Build error fixed for function mv88e61xx_busychk_multic-fixed
2. PHY dev address error detection-
Dear Mike,
In message 1248381468-29618-1-git-send-email-vap...@gentoo.org you wrote:
While we're here, fix the broken #ifdef handling in _exports.h.
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
v3
- tweak code style
common/exports.c |8
include/_exports.h |
List command always return EXIT_SUCCESS even in case of
failure by any means.
This patch return 0 if list command is sucessful,
returns negative value reported by check_header functions
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
Change log:
v2: added code rewritten to look it
Dear Prafulla Wadaskar,
In message 1247758084-12296-4-git-send-email-prafu...@marvell.com you wrote:
With these fixes, this driver works properly for multi chip
addressging mode
Bugfixes:
1. Build error fixed for function mv88e61xx_busychk_multic-fixed
2. PHY dev address error detection-
It is recommended to define the macro CONFIG_SYS_64BIT_VSPRINTF
for NAND specific warning removal, same is done in this patch
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
include/configs/rd6281a.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
Dear Trent Piepho,
In message 1234999325-13456-1-git-send-email-tpie...@freescale.com you wrote:
A recent gcc added a new unaligned rodata section called '.rodata.str1.1',
which needs to be added the the linker script. Instead of just adding this
one section, we use a wildcard .rodata* to
-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Monday, August 10, 2009 1:39 PM
To: Prafulla Wadaskar
Cc: u-boot@lists.denx.de; Manas Saksena; Ronen Shitrit;
Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert
Buijtenhek; Ben Warren; Jean-Christophe
Hi everybody...
v2009.08-rc2 has just been released.
Please help testing, and submit fixes to the remaining problems.
Things still missing should be submitted ASAP.
v2009.08-rc2 is also be the base for the next branch which I just
created (still empty so far).
Please use the next branch
1. mv88E61xx driver compiler warnings fixed
2. idstr if-else statements changed to switch() construct
and added default case too.
This fixed idstr may be uninitialized warning
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
drivers/net/phy/mv88e61xx.c | 23
-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Monday, August 10, 2009 1:56 PM
To: Prafulla Wadaskar
Cc: Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ben Warren;
u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik;
Lennert Buijtenhek
Subject: Re:
On 10:55 Mon 10 Aug , Wolfgang Denk wrote:
Hi everybody...
v2009.08-rc2 has just been released.
Please help testing, and submit fixes to the remaining problems.
Things still missing should be submitted ASAP.
v2009.08-rc2 is also be the base for the next branch which I just
Dear Prafulla Wadaskar,
In message 1249910377-17974-1-git-send-email-prafu...@marvell.com you wrote:
List command always return EXIT_SUCCESS even in case of
failure by any means.
This patch return 0 if list command is sucessful,
returns negative value reported by check_header functions
eth_setenv_enetaddr is avaible by upper layer
using this saves 204 bytes on total image size
used Local OUI instead of Marvell OUI for
random MAC address generation logic
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
Change log
v2: updated as per feedback for v1
private MAC address
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090810085443.gi17...@game.jcrosoft.org you wrote:
* ARM and PowerPC: mostly compile clean; there are a few issues,
responsible s have been notified
nearly all ppc have warning with gcc 4
and a lots of them fail to build
I built all
Dear Prafulla Wadaskar,
In message 1249917246-20224-1-git-send-email-prafu...@marvell.com you wrote:
The tools/Makefile is sorted for all entries,
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
tools/Makefile | 50 +-
1 files
It is observed that tools/mpc86x_clk.c is not referred anywhere
the build entry was commented in Makefile,
all the references related to this file are removed
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
tools/Makefile | 10 ---
tools/mpc86x_clk.c | 218
Dear Prafulla Wadaskar,
In message 1249917879-26559-1-git-send-email-prafu...@marvell.com you wrote:
It is observed that tools/mpc86x_clk.c is not referred anywhere
the build entry was commented in Makefile,
all the references related to this file are removed
Signed-off-by: Prafulla
-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Monday, August 10, 2009 4:49 PM
To: Prafulla Wadaskar
Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] tools: unused code removal mpc86x_clk.c
Dear Prafulla Wadaskar,
Wolfgang Denk wrote:
Summary of current status:
* Many boards now throw the (expected)
#warning Ethernet driver is deprecated. Please update to use
CONFIG_NET_MULTI
messages.
I found qemu_mips_config is spotted by it:
Configuring for qemu-mips board...
eth.c:497:2: warning:
On 11:11 Mon 27 Jul , Ben Warren wrote:
Hi Mike,
Mike Frysinger wrote:
On Monday 27 July 2009 05:26:07 Wolfgang Denk wrote:
* Many boards now throw the (expected)
#warning Ethernet driver is deprecated. Please update to use
CONFIG_NET_MULTI
messages.
i see
Dear Prafulla Wadaskar,
In message 73173d32e9439e4abb5151606c3e19e202e370b...@sc-vexch1.marvell.com
you wrote:
Why are you removing this tool? Even though it does not get=20
build by default, it is still pretty useful when you have to=20
design the clock system on a MPC8xx processor.
I
On Aug 10, 2009, at 2:56 AM, Wolfgang Denk wrote:
Dear Kumar,
I cannot build the MPC8536DS board any more using the ELDK 4.2 tool
chain (gcc 4.2.2):
ppc_85xx-ld: section .bootpg [e000 - e1cb] overlaps
section .data.rel.local [efffe5d0 - e
c7b]
ppc_85xx-ld: section
I get the following compilation errors when I try to compile DaVinci DM355 on
the latest U-Boot source. I thought I saw similar issues on the mailing list
some time back. Have these been resolved?
3.2/libgcc.a(_udivsi3.o) has EABI version 5, but target u-boot has EABI version 0
Hi,
aulraj, Sandeep a écrit :
I get the following compilation errors when I try to compile DaVinci DM355 on
the latest U-Boot source. I thought I saw similar issues on the mailing list
some time back. Have these been resolved?
3.2/libgcc.a(_udivsi3.o) has EABI version 5, but target
-Original Message-
From: Eric Bénard [mailto:e...@eukrea.com]
Sent: Monday, August 10, 2009 11:26 AM
To: Paulraj, Sandeep
Cc: u-boot@lists.denx.de
Subject: Re: [U-Boot] Compilation erros while trying at compile ARM
DaVinci
Hi,
aulraj, Sandeep a écrit :
I get the following
Hi Sandeep,
try to add USE_PRIVATE_LIBGCC=yes to you make commande.
[Sandeep] It compiles. Is this some kind of a permanent solution?
I see lots of e-mails on arm not including libgcc.
It should not be a permanent solution. It is need however as long as
a) ARM on U-Boot forces the ABI to
From: Sandeep Paulraj s-paul...@ti.com
Due to recent changes to the NET support on U-boot, DM9000
is no longer detected on the DM355 EVM.
This minor update enables DM9000 on the DM355 EVM.
Tested on the DM355 EVM
Signed-off-by: Sandeep Paulraj s-paul...@ti.com
---
As with recent git head, v2009.08-rc2, all OMAP3 and Cortex A8 patches
I had in my pending patches list are in mainline now* :)
If you think your patch isn't applied yet, or you have something
depending on the patches applied now, re-base it against recent head
and please (re-) send (again).
Kumar Gala wrote:
On Aug 10, 2009, at 2:56 AM, Wolfgang Denk wrote:
Dear Kumar,
I cannot build the MPC8536DS board any more using the ELDK 4.2 tool
chain (gcc 4.2.2):
ppc_85xx-ld: section .bootpg [e000 - e1cb] overlaps
section .data.rel.local [efffe5d0 - e
c7b]
-Original Message-
From: Wolfgang Denk [mailto:w...@denx.de]
Sent: Monday, August 10, 2009 6:30 PM
To: Prafulla Wadaskar
Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] tools: unused code removal mpc86x_clk.c
Dear Prafulla Wadaskar,
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 11:11 Mon 27 Jul , Ben Warren wrote:
Hi Mike,
Mike Frysinger wrote:
On Monday 27 July 2009 05:26:07 Wolfgang Denk wrote:
* Many boards now throw the (expected)
#warning Ethernet driver is deprecated. Please update to
Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 16:35 Sat 08 Aug , Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 15:47 Sat 08 Aug , Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 12:46 Sat 08 Aug , Dirk Behme wrote:
Since there is only
Hi Shinya,
Shinya Kuribayashi wrote:
Wolfgang Denk wrote:
Summary of current status:
* Many boards now throw the (expected)
#warning Ethernet driver is deprecated. Please update to use
CONFIG_NET_MULTI
messages.
I found qemu_mips_config is spotted by it:
Configuring for
From: Sandeep Paulraj s-paul...@ti.com
This patch adds a new page parameter to all NAND read_page/read_page_raw
APIs. The read_page API for the new mode ECC_HW_OOB_FIRST requires the
page information to send the READOOB command and read the OOB area before
the data area.
This patch has been
From: Sandeep Paulraj s-paul...@ti.com
This patch adds the new mode NAND_ECC_HW_OOB_FIRST in the nand code to
support 4-bit ECC on TI DaVinci devices with large page (up to 2K) NAND
chips. This ECC mode is similar to NAND_ECC_HW, with the exception of
read_page API that first reads the OOB area,
Hi Ben,
Just ping-ing the status of these patches to u-boot.
If I have sent them badly, please let me know and I can repost.
1. 83xx: UEC: Added support for bitBang MII driver access to PHYs
Dear Kumar Gala,
In message 0e1a5eeb-51e5-488d-9457-993f95553...@kernel.crashing.org you wrote:
Could you please have a look?
The e1000 driver updates seem to contribute a bit to code bloat.
...
Not sure what we can do about it.
Allocate more space for U-Boot?
Best regards,
Wolfgang
On Aug 10, 2009, at 12:59 PM, Wolfgang Denk wrote:
Dear Kumar Gala,
In message
0e1a5eeb-51e5-488d-9457-993f95553...@kernel.crashing.org you wrote:
Could you please have a look?
The e1000 driver updates seem to contribute a bit to code bloat.
...
Not sure what we can do about it.
Dear Kumar Gala,
In message 0eb7516a-2f14-42f7-a6ed-555adfab3...@kernel.crashing.org you wrote:
Allocate more space for U-Boot?
I might turn of BEDBUG as its never been properly enabled on e500/85xx
platforms.
Is there any problem with the bigger image which I don't understand
yet?
On Aug 10, 2009, at 1:22 PM, Wolfgang Denk wrote:
Dear Kumar Gala,
In message 0EB7516A-2F14-42F7-
a6ed-555adfab3...@kernel.crashing.org you wrote:
Allocate more space for U-Boot?
I might turn of BEDBUG as its never been properly enabled on
e500/85xx
platforms.
Is there any problem
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Monday, August 10, 2009 13:41 PM
To: Wolfgang Denk
Cc: U-Boot-Users ML; Zang Roy-R61911
Subject: Re: 85xx: MPC8536DS board does not build
On Aug 10, 2009, at 1:22 PM, Wolfgang Denk wrote:
Dear
Tried it on a 8641 and seems to work fine.
- k
On Aug 8, 2009, at 8:23 AM, Aggrwal Poonam-B10812 wrote:
Kumar,
I could not test these changes on any 86xx(build I have checked),
Can u test them or can I get access to some remote setup for this.
Just
to make sure the changes do not break
I was wondering if we can see how big the NOR flash is on the XES
TQM boards.
thanks.
- k
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On Aug 10, 2009, at 1:59 PM, Zang Roy-R61911 wrote:
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Monday, August 10, 2009 13:41 PM
To: Wolfgang Denk
Cc: U-Boot-Users ML; Zang Roy-R61911
Subject: Re: 85xx: MPC8536DS board does not build
On Aug 10,
On Mon, 2009-08-10 at 14:07 -0500, Kumar Gala wrote:
I was wondering if we can see how big the NOR flash is on the XES
TQM boards.
XES's 85xx and 86xx boards should all have U-Boot located in a NOR flash
that is either 64MB or 128MB. Sector sizes are generally 128KB.
Out of curiosity, how
Kumar Gala wrote:
On Aug 10, 2009, at 1:59 PM, Zang Roy-R61911 wrote:
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Monday, August 10, 2009 13:41 PM
To: Wolfgang Denk
Cc: U-Boot-Users ML; Zang Roy-R61911
Subject: Re: 85xx: MPC8536DS board does not
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Monday, August 10, 2009 14:06 PM
To: Zang Roy-R61911
Cc: Wolfgang Denk; U-Boot-Users ML
Subject: Re: 85xx: MPC8536DS board does not build
On Aug 10, 2009, at 1:59 PM, Zang Roy-R61911 wrote:
Dear Kumar Gala,
In message f424a9e6-aff8-40f0-b134-92031a125...@kernel.crashing.org you wrote:
I was wondering if we can see how big the NOR flash is on the XES
TQM boards.
Including the old MPC8xx? They usually have 4 or 8 MB NOR.
Anything else usually has 32...128 MB.
If I remember
On Sat 8 Aug 2009 05:50, Ben Warren pondered:
Allesandro,
Alessandro Rubini wrote:
I finally fixed the defrag code, testing with NFS as well.
Didn't take performance figures, tough, for lack of time.
Checking out performance with tftp - server is Linux 2.6.27 located in
Germany, client
From: Roy Zang tie-fei.z...@freescale.com
Fix E1000 build warning on AP1000 board
Fix the build warning on AP1000 board:
e1000.c:131: warning: 'e1000_read_eeprom' used but never defined
e1000.c:2012: warning: 'e1000_set_phy_mode' defined but not used
Signed-off-by: Roy Zang
Robin Getz wrote:
On Sat 8 Aug 2009 05:50, Ben Warren pondered:
Allesandro,
Alessandro Rubini wrote:
I finally fixed the defrag code, testing with NFS as well.
Didn't take performance figures, tough, for lack of time.
Checking out performance with tftp - server is Linux
Dear Robin Getz,
In message 200908101551.52052.rg...@blackfin.uclinux.org you wrote:
Checking out performance with tftp - server is Linux 2.6.27 located in
Germany, client (U-Boot running net/next) is located in the USA. Packets
fragmented, and arriving out of order.
...
So, that is
On Mon, 2009-08-10 at 15:27 -0400, Jerry Van Baren wrote:
Kumar Gala wrote:
On Aug 10, 2009, at 1:59 PM, Zang Roy-R61911 wrote:
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Monday, August 10, 2009 13:41 PM
To: Wolfgang Denk
Cc: U-Boot-Users
On Aug 10, 2009, at 3:00 PM, Peter Tyser wrote:
On Mon, 2009-08-10 at 15:27 -0400, Jerry Van Baren wrote:
Kumar Gala wrote:
On Aug 10, 2009, at 1:59 PM, Zang Roy-R61911 wrote:
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Monday, August 10, 2009
From bca49fb5e3045bc175e924999a4015804c39c5c6 Mon Sep 17 00:00:00 2001
From: Robin Getz rg...@blackfin.uclinux.org
I was using this when I was looking at some other recent tftp performance,
and thought I would share. I really don't think it belongs, as it is
(a) trivial and (b) mostly debug...
On Mon, Aug 10, 2009 at 3:26 PM, Robin Getzrg...@blackfin.uclinux.org wrote:
From bca49fb5e3045bc175e924999a4015804c39c5c6 Mon Sep 17 00:00:00 2001
From: Robin Getz rg...@blackfin.uclinux.org
I was using this when I was looking at some other recent tftp performance,
and thought I would share.
On Mon, 10 Aug 2009, Kumar Gala wrote:
On Aug 10, 2009, at 1:22 PM, Wolfgang Denk wrote:
Dear Kumar Gala,
In message 0EB7516A-2F14-42F7-
a6ed-555adfab3...@kernel.crashing.org you wrote:
Allocate more space for U-Boot?
I might turn of BEDBUG as its never been properly enabled
Dear Kumar Gala,
In message 07da25c3-1f4f-431e-bf8a-61c11cd41...@kernel.crashing.org you wrote:
I'm asking this just see if we bump up in size if it should be to 768k
or 1M. While this doesn't directly impact the TQM or XES boards I
just wanted to get a sense of how much flash people
On Mon, 10 Aug 2009, Peter Tyser wrote:
On Mon, 2009-08-10 at 15:27 -0400, Jerry Van Baren wrote:
Kumar Gala wrote:
On Aug 10, 2009, at 1:59 PM, Zang Roy-R61911 wrote:
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Monday, August 10,
On Aug 10, 2009, at 4:25 PM, Wolfgang Denk wrote:
Dear Kumar Gala,
In message 07DA25C3-1F4F-431E-
bf8a-61c11cd41...@kernel.crashing.org you wrote:
I'm asking this just see if we bump up in size if it should be to
768k
or 1M. While this doesn't directly impact the TQM or XES boards I
For some reason the MPC8544 enabled BEDBUG if PCI was enabled and that
got copied int the MPC8536, MPC8572 and P2020 DS boards. The BEDBUG
support has never been made to work completely on e500/85xx so we
just disable it to save space and match the other FSL 85xx boards.
Signed-off-by: Kumar
The following changes since commit eb1a4d0a471505c169bef19a73a60f8641f0b875:
Wolfgang Denk (1):
Prepare 2009.08-rc2
are available in the git repository at:
git://git.denx.de/u-boot-mpc85xx.git master
Kumar Gala (1):
85xx: Removed BEDBUG support from FSL 85xx boards
Hello Po-Yu,
ratbert.chu...@gmail.com wrote:
From: Po-Yu Chuang ratb...@faraday-tech.com
This patch adds an FTMAC100 ethernet driver for Faraday A320 evaluation board.
Signed-off-by: Po-Yu Chuang ratb...@faraday-tech.com
---
Applied to net repo.
thanks,
Ben
Wolfgang,
Wolfgang Denk wrote:
tftp.c:294: warning: pointer targets in passing argument 1 of 'strlen'
differ in signedness
This was only visible for the utx8245 board which seems to have DEBUG
enabled.
Signed-off-by: Wolfgang Denk w...@denx.de
---
net/tftp.c |4 +++-
1 files
Prafulla,
Prafulla Wadaskar wrote:
1. mv88E61xx driver compiler warnings fixed
2. idstr if-else statements changed to switch() construct
and added default case too.
This fixed idstr may be uninitialized warning
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
Applied to net
Roy,
Roy Zang wrote:
From: Roy Zang tie-fei.z...@freescale.com
Fix E1000 build warning on AP1000 board
Fix the build warning on AP1000 board:
e1000.c:131: warning: 'e1000_read_eeprom' used but never defined
e1000.c:2012: warning: 'e1000_set_phy_mode' defined but not used
Wolfgang,
The following changes since commit eb1a4d0a471505c169bef19a73a60f8641f0b875:
Wolfgang Denk (1):
Prepare 2009.08-rc2
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
Po-Yu Chuang (1):
arm: A320: driver for FTMAC100 ethernet controller
Sandeep,
s-paul...@ti.com wrote:
From: Sandeep Paulraj s-paul...@ti.com
Due to recent changes to the NET support on U-boot, DM9000
is no longer detected on the DM355 EVM.
This minor update enables DM9000 on the DM355 EVM.
Tested on the DM355 EVM
Signed-off-by: Sandeep Paulraj
This patch adds support for i.MX27-LITEKIT development board from
LogicPD. This board uses i.MX27 SoC and has 2MB NOR flash, 64MB NAND
flash, FEC ethernet controller integrated into i.MX27.
Signed-off-by: Ilya Yanok ya...@emcraft.com
---
MAINTAINERS |1 +
MAKEALL
Driver for NFC NAND controller found on Freescale's MX2 and MX3
processors. Ported from Linux. Tested only with i.MX27 but should
works with other MX2 and MX3 processors too.
Signed-off-by: Ilya Yanok ya...@emcraft.com
---
drivers/mtd/nand/Makefile |1 +
drivers/mtd/nand/mxc_nand.c | 880
Prafulla,
Prafulla Wadaskar wrote:
eth_setenv_enetaddr is avaible by upper layer
using this saves 204 bytes on total image size
used Local OUI instead of Marvell OUI for
random MAC address generation logic
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
Applied to net repo.
Hi Richard,
Sorry, thought I'd taken care of these.
Richard Retanubun wrote:
Hi Ben,
Just ping-ing the status of these patches to u-boot.
If I have sent them badly, please let me know and I can repost.
1. 83xx: UEC: Added support for bitBang MII driver access to PHYs
On Mon, Aug 10, 2009 at 03:55:20PM -0500, Timur Tabi wrote:
+#ifdef CONFIG_TFTP_QUIET
+#define puts_quiet(fmt)
+#else
+#define puts_quiet(fmt) puts(fmt);
+#endif
This looks backwards to me. I would do this:
#ifdef CONFIG_TFTP_QUIET
#define puts(x) puts_quiet(x)
On Mon 10 Aug 2009 16:55, Timur Tabi pondered:
On Mon, Aug 10, 2009 at 3:26 PM, Robin Getzrg...@blackfin.uclinux.org wrote:
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -22,6 +22,16 @@
/* (for checking the image size)
*/
#define HASHES_PER_LINE
uninitialized retval variable warning fixed
crc32 api moved to crc.h(new) and build warnings fixed
Signed-off-by: Prafulla Wadaskar prafu...@marvell.com
---
include/common.h |4 +---
include/u-boot/crc.h | 33 +
tools/mkimage.c | 14 +++---
80 matches
Mail list logo
