[U-Boot] i.MX6 based board does not work if watchdog support is enabled

2013-09-28 Thread Otavio Salvador
Hello, I am trying to add support for watchdog in one board and it is not working as expected. I did add the: #define CONFIG_HW_WATCHDOG #define CONFIG_IMX_WATCHDOG into the board config file. Into the board .c file, I added: int board_late_init(void) { ... #ifdef CONFIG_HW_WATCHDOG hw_w

Re: [U-Boot] [RFC 0/3] ARM: cleanup gd init

2013-09-28 Thread Albert ARIBAUD
Hi Jeroen, On Sun, 22 Sep 2013 20:26:07 +0200, Jeroen Hofstee wrote: > Hello, > > On 08/24/2013 06:32 PM, Jeroen Hofstee wrote: > > 4) Keep the s_init in crt0.S or move it to the board_init_f? > > The disadvantage of the later is that all the different > > board_init_f's need to call system_ini

[U-Boot] [PATCH v2 5/6] status_led: Add support for inverted LEDs

2013-09-28 Thread Otavio Salvador
There're cases we want to use active-low LEDs and the 'inverted' logic needs to be added. This includes it using the STATUS_LED_INVERT macro. Signed-off-by: Otavio Salvador --- Changes in v2: - rework to keep calling __led_init doc/README.LED| 2 ++ drivers/misc/status_led.c | 22 +

[U-Boot] [PATCH v2 2/6] include/linux/fb.h: Add a missing include for 'list.h'

2013-09-28 Thread Otavio Salvador
The modelist data uses the list definition but the 'list.h' header were not being included. The build failure is bellow: , | In file included from .c:16:0: | .../u-boot/include/linux/fb.h:503:19: error: field 'modelist' has incomplete type | struct list_head modelist; /* mode list */ |

[U-Boot] [PATCH v2 4/6] status_led: Print an error when the LED id is out of range

2013-09-28 Thread Otavio Salvador
Signed-off-by: Otavio Salvador --- Changes in v2: - new patch drivers/misc/status_led.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/status_led.c b/drivers/misc/status_led.c index 6b71ad4..33148c9 100644 --- a/drivers/misc/status_led.c +++ b/drivers/misc/st

[U-Boot] [PATCH v2 3/6] doc: Fix a typo in the description in doc/README.JFFS2_NAND

2013-09-28 Thread Otavio Salvador
Signed-off-by: Otavio Salvador --- Changes in v2: None doc/README.JFFS2_NAND | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/README.JFFS2_NAND b/doc/README.JFFS2_NAND index 5018ae8..09788d5 100644 --- a/doc/README.JFFS2_NAND +++ b/doc/README.JFFS2_NAND @@ -1,6 +1,6 @@ JF

[U-Boot] [PATCH v2 6/6] cmd_led: Add support for inverted BIT leds

2013-09-28 Thread Otavio Salvador
Signed-off-by: Otavio Salvador --- Changes in v2: None common/cmd_led.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/common/cmd_led.c b/common/cmd_led.c index c48603c..d541f2f 100644 --- a/common/cmd_led.c +++ b/common/cmd_led.c @@ -18,6 +18,7

[U-Boot] [PATCH v2 1/6] mtd: Fix function description in part_validate comment

2013-09-28 Thread Otavio Salvador
The part_validate comment had a wrong description of the actions it does and referenced to non-existent functions while in fact it calls 'part_validate_eraseblock()'. Signed-off-by: Otavio Salvador --- Changes in v2: - rework commit log (Eric Benard) common/cmd_mtdparts.c | 8 1 file c

Re: [U-Boot] [PATCH 6/7] status_led: Add support for inverted LEDs

2013-09-28 Thread Otavio Salvador
On Sat, Sep 28, 2013 at 1:49 PM, Fabio Estevam wrote: > On Sat, Sep 28, 2013 at 11:17 AM, Benoît Thébaudeau > wrote: >> Dear Otavio Salvador, >> >> On Saturday, September 28, 2013 5:24:17 AM, Otavio Salvador wrote: >>> There're cases we want to use active-low LEDs and the 'inverted' logic >>> nee

Re: [U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input

2013-09-28 Thread Otavio Salvador
On Sat, Sep 28, 2013 at 1:35 PM, Fabio Estevam wrote: > On Sat, Sep 28, 2013 at 10:12 AM, Eric Bénard wrote: > >> Maybe the real fix would be to check why gpio_get_value doesn't return >> the level of the gpio when it's configured as an output. > > I agree with Eric. > > Could you please test the

Re: [U-Boot] [PATCH] gpio: mxc_gpio: Fix gpio_get_value() when the GPIO is an output

2013-09-28 Thread Otavio Salvador
On Sat, Sep 28, 2013 at 2:22 PM, Fabio Estevam wrote: > From: Fabio Estevam > > When the GPIO is configured as an output, we should return the value from the > DR > register. > > This implements the same fix as in the following kernel commit from FSL BSP: > http://git.freescale.com/git/cgit.cgi/

[U-Boot] [PATCH] buildman: Use env to pick the python from $PATH

2013-09-28 Thread Jagannadha Sutradharudu Teki
python used in buildman doesn't need to be placed in /usr/bin/python, So use env to ensure that the interpreter will pick the python from environment. Usefull with several versions of python's installed on system. Signed-off-by: Jagannadha Sutradharudu Teki --- tools/buildman/buildman.py | 2 +-

[U-Boot] : buildman error

2013-09-28 Thread Jagan Teki
Can any one encounter this! looks like some issue on python setup? $ ./tools/buildman/buildman -b master File "./tools/buildman/buildman", line 42 print result ^ SyntaxError: invalid syntax Let me know for any input, I am using Python 3.3.0 -- Thanks, Jagan. Jagann

[U-Boot] [PATCH] gpio: mxc_gpio: Fix gpio_get_value() when the GPIO is an output

2013-09-28 Thread Fabio Estevam
From: Fabio Estevam When the GPIO is configured as an output, we should return the value from the DR register. This implements the same fix as in the following kernel commit from FSL BSP: http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/commit/arch/arm/plat-mxc/gpio.c?h=imx_3.0.35_4.1

Re: [U-Boot] [PATCH 6/7] status_led: Add support for inverted LEDs

2013-09-28 Thread Fabio Estevam
On Sat, Sep 28, 2013 at 11:17 AM, Benoît Thébaudeau wrote: > Dear Otavio Salvador, > > On Saturday, September 28, 2013 5:24:17 AM, Otavio Salvador wrote: >> There're cases we want to use active-low LEDs and the 'inverted' logic >> needs to be added. This includes it using the STATUS_LED_INVERT mac

Re: [U-Boot] [PATCH 3/7] include/linux/fb.h: Add a missing include for 'list.h'

2013-09-28 Thread Fabio Estevam
On Sat, Sep 28, 2013 at 12:24 AM, Otavio Salvador wrote: > Signed-off-by: Otavio Salvador Please provide a commit log and explain which function from list.h is needed and/or what is the build error you get without this header. ___ U-Boot mailing list

Re: [U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input

2013-09-28 Thread Fabio Estevam
On Sat, Sep 28, 2013 at 10:12 AM, Eric Bénard wrote: > Maybe the real fix would be to check why gpio_get_value doesn't return > the level of the gpio when it's configured as an output. I agree with Eric. Could you please test the patch below? --- a/drivers/gpio/mxc_gpio.c +++ b/drivers/gpio/mx

Re: [U-Boot] [PATCH 6/7] status_led: Add support for inverted LEDs

2013-09-28 Thread Benoît Thébaudeau
Dear Otavio Salvador, On Saturday, September 28, 2013 5:24:17 AM, Otavio Salvador wrote: > There're cases we want to use active-low LEDs and the 'inverted' logic > needs to be added. This includes it using the STATUS_LED_INVERT macro. There is already a STATUS_LED_ACTIVE definition (though not on

Re: [U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input

2013-09-28 Thread Eric Bénard
Hi Otavio, Le Sat, 28 Sep 2013 00:24:16 -0300, Otavio Salvador a écrit : > The GPIO need to be set as input before reading its current value and > set back to output for setting it; this fixes the non-working > 'led toggle' for GPIO based LEDs. > > Signed-off-by: Otavio Salvador > --- > driv

Re: [U-Boot] [PATCH 1/7] mtd: Fix function description in part_validate comment

2013-09-28 Thread Eric Bénard
Hi Otavio, Le Sat, 28 Sep 2013 00:24:12 -0300, Otavio Salvador a écrit : > The part_validate comment had a wrong description of the actions it > does and referenced to non-existent functions while in fact it calls > 'part_validate_eraseblock()'. > > Signed-off-by: Otavio Salvador > --- > comm

[U-Boot] apparent(?) flaw in recent patch "am335x_evm: Switch to zImage as default rather

2013-09-28 Thread Robert P. J. Day
than uImage" (i already tossed the original post so i can't reply to it directly, sorry.) this recent patch by tom rini to make zImage rather than uImage the default kernel format for am335x_evm: http://lists.denx.de/pipermail/u-boot/2013-September/163365.html seems flawed as the loading wi