Re: [U-Boot] [PATCH 06/28] dm: stdio: Plumb in the new keyboard uclass

2015-10-18 Thread Simon Glass
Hi Bin, On 15 September 2015 at 00:11, Bin Meng wrote: > Hi Simon, > > On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >> When driver model is used for keyboards we must scan the available keyboards >> and register them with stdio. Add code to do this.

Re: [U-Boot] [PATCH 24/28] x86: Add an i8042 device for boards that have it

2015-10-18 Thread Simon Glass
Hi Bin, On 15 September 2015 at 00:12, Bin Meng wrote: > Hi Simon, > > On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >> Some boards have an i8042 device. Enable the driver for all x86 boards, and >> add a device tree node for those which may have

Re: [U-Boot] [PATCH 18/28] input: Support the German keymap

2015-10-18 Thread Simon Glass
Hi Bin, On 15 September 2015 at 00:12, Bin Meng wrote: > Hi Simon, > > On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >> Add support for the German keymap, taken from i8042.c. This can be selected >> when the input library it initialised. >> >>

Re: [U-Boot] [PATCH v2] dm: tpm: Drop CONFIG_DM_TPM

2015-10-18 Thread Simon Glass
On 4 October 2015 at 02:46, Christophe Ricard wrote: > Hi Simon, > > Acked-by: Christophe Ricard > > Best Regards > Christophe > Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 26/28] input: Convert i8042 to driver model

2015-10-18 Thread Simon Glass
Hi Bin, On 15 September 2015 at 00:12, Bin Meng wrote: > Hi Simon, > > On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >> Adjust this driver to support driver model. The only users are x86 boards >> so this should be safe. >> >> Signed-off-by: Simon

Re: [U-Boot] [PATCH 04/28] input: Add the keycode translation tables separately

2015-10-18 Thread Simon Glass
Hi Bin, On 15 September 2015 at 00:11, Bin Meng wrote: > Hi Simon, > > On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >> Require the caller to add the keycode translation tables separately so that >> it can select which ones to use. In a later patch

Re: [U-Boot] [PATCH 09/28] video: Drop unused console functions

2015-10-18 Thread Simon Glass
Hi Bin, On 15 September 2015 at 00:11, Bin Meng wrote: > Hi Simon, > > On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >> CONFIG_CONSOLE_CURSOR, CONFIG_SYS_CONSOLE_BLINK_COUNT and >> CONFIG_CONSOLE_TIME are not used by any board. The implementation is

Re: [U-Boot] [PATCH] dfu: dfu_sf: Use the erase sector size for erase operations

2015-10-18 Thread Fabio Estevam
Hi Lukasz, On Tue, Sep 22, 2015 at 4:46 AM, Lukasz Majewski wrote: > Hi Fabio, > >> From: Fabio Estevam >> >> SPI NOR flashes need to erase the entire sector size and we cannot >> pass any arbitrary length for the erase operation. >> >> To

Re: [U-Boot] [PATCH v2 02/13] x86: fsp: Report correct number of E820 table entries

2015-10-18 Thread Simon Glass
Hi Tom, On 18 October 2015 at 18:09, Tom Rini wrote: > On Sun, Oct 18, 2015 at 06:58:51AM -0600, Simon Glass wrote: >> Hi Tom, >> >> On 28 September 2015 at 22:52, Simon Glass wrote: >> > On 28 September 2015 at 03:11, Bin Meng wrote:

Re: [U-Boot] [PATCH 1/3] x86: ivybridge: Fix saving mrc cache and enable it

2015-10-18 Thread Bin Meng
Hi Simon, On Mon, Oct 19, 2015 at 4:27 AM, Simon Glass wrote: > Hi Bin, > > On 12 October 2015 at 02:30, Bin Meng wrote: >> Currently sdram_initialise() saves pei_data->mrc_output directly to >> gd->arch.mrc_output. This is incorrect as

Re: [U-Boot] [PATCH 2/2] rockchip: firefly: Save the environment on SD card

2015-10-18 Thread Simon Glass
On 3 October 2015 at 08:27, Simon Glass wrote: > On 18 September 2015 at 22:49, Sjoerd Simons > wrote: >> Save the environment on the SD card for Firefly in the empty space >> between the SPL and the u-boot image. >> >> Signed-off-by: Sjoerd

Re: [U-Boot] [PATCH 1/2] rockchip: Also load the initrd below 512M

2015-10-18 Thread Simon Glass
On 3 October 2015 at 08:27, Simon Glass wrote: > On 18 September 2015 at 22:49, Sjoerd Simons > wrote: >> Similar to load an fdt, when loading an initrd about the 512Mb mark >> things seem to break. For now force loading below 512Mb until the

[U-Boot] [PATCH v2 07/28] dm: tegra: Convert keyboard driver to driver model

2015-10-18 Thread Simon Glass
Adjust the tegra keyboard driver to support driver model, using the new uclass. Make this the default for all Tegra boards so that those that use a keyboard will build correctly with this driver. Signed-off-by: Simon Glass --- Changes in v2: None arch/arm/mach-tegra/Kconfig

[U-Boot] [PATCH v2 23/28] x86: Add an i8042 device for boards that have it

2015-10-18 Thread Simon Glass
Some boards have an i8042 device. Enable the driver for all x86 boards, and add a device tree node for those which may have this keyboard. Also adjust the configuration so that i8042 is always separate from the VGA, and rename the stdin driver accordingly. With this commit the keyboard will not

[U-Boot] [PATCH v2 14/28] input: Add a few more keyboard keycodes

2015-10-18 Thread Simon Glass
The slash and * are missing from the keycode tables. Add these so that these keypad keys can be used. Signed-off-by: Simon Glass --- Changes in v2: - Fix extra space in commit message drivers/input/input.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[U-Boot] [PATCH v2 09/28] video: Drop unused console functions

2015-10-18 Thread Simon Glass
CONFIG_CONSOLE_CURSOR, CONFIG_SYS_CONSOLE_BLINK_COUNT and CONFIG_CONSOLE_TIME are not used by any board. The implementation is not great and stands in the way of a refactor of i8042. Drop these for now. They can be re-introduced quite easily later, perhaps with driver-model real-time-clock (RTC)

[U-Boot] [PATCH v2 15/28] input: Add a function to add a keycode to the existing set

2015-10-18 Thread Simon Glass
Most keyboards can be scanned to produce a list of the keycodes which are depressed. With the i8042 keyboard this scanning is done internally and only the processed results are returned. In this case, when a key is pressed, a 'make' code is sent. When the key is released an 'unmake' code is sent.

[U-Boot] [PATCH v2 13/28] input: Correct keycode for Ctrl-Y

2015-10-18 Thread Simon Glass
This code is currently incorrect, perhaps due to a typo. Fix it. Signed-off-by: Simon Glass --- Changes in v2: None drivers/input/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index 82e8381..a6834cf

[U-Boot] [PATCH v2 10/28] i8042: Use functions to handle register access

2015-10-18 Thread Simon Glass
At present the register access in kbd_reset() is quite primitive. This makes it hard to follow. Create functions to read and write data, both to a single register, and via the command/data approach. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

[U-Boot] [PATCH v2 06/28] dm: stdio: Plumb in the new keyboard uclass

2015-10-18 Thread Simon Glass
When driver model is used for keyboards we must scan the available keyboards and register them with stdio. Add code to do this. At some point (once LCD/video is converted) we should be able to convert stdio to driver model and avoid these dual data structures. Signed-off-by: Simon Glass

[U-Boot] [PATCH v2 08/28] dm: cros_ec: Convert cros_ec keyboard driver to driver model

2015-10-18 Thread Simon Glass
Adjust the cros_ec keyboard driver to support driver model. Make this the default for all Exynos boards so that those that use a keyboard will build correctly with this driver. Signed-off-by: Simon Glass --- Changes in v2: None README | 5 --

[U-Boot] [PATCH v2 12/28] i8042: Adjust keyboard init to assume success

2015-10-18 Thread Simon Glass
Modify i8042_kbd_init() so that the normal pass is sucessful init and failure exits early. This will make the code easier to extend and is easier to read. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/input/i8042.c |

Re: [U-Boot] [PATCH v2 2/5] debug_uart: Support board-specific UART initialisation

2015-10-18 Thread Bin Meng
On Mon, Oct 19, 2015 at 9:51 AM, Simon Glass wrote: > Some boards need to set things up before the debug UART can be used. On > these boards a call to debug_uart_init() is insufficient. When this option > is enabled, the function board_debug_uart_init() will be called when >

Re: [U-Boot] [PATCH v2 3/5] debug_uart: Add an option to announce the debug UART

2015-10-18 Thread Bin Meng
On Mon, Oct 19, 2015 at 9:51 AM, Simon Glass wrote: > It is useful to see a message from the debug UART early during boot so that > you know things are working. Add an option to enable this. The message will > be displayed as soon as debug_uart_init() is called. > >

Re: [U-Boot] [PATCH 3/3] x86: galileo: Enable mrc cache

2015-10-18 Thread Simon Glass
On 12 October 2015 at 02:30, Bin Meng wrote: > Now that we have added MRC cache on quark support codes, > enable it on Intel Galileo board. > > Signed-off-by: Bin Meng > --- > > arch/x86/dts/galileo.dts | 4 > configs/galileo_defconfig | 1 + > 2

[U-Boot] [PATCH v2 2/2] arm: fix compile warnings when semihosting is enabled on ARMv7M target.

2015-10-18 Thread Vadzim Dambrouski
Signed-off-by: Vadzim Dambrouski --- arch/arm/lib/semihosting.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c index ed5e8e4..6541cb4 100644 --- a/arch/arm/lib/semihosting.c +++

[U-Boot] [PATCH v2 1/2] arm: add support for semihosting for ARMv7M targets

2015-10-18 Thread Vadzim Dambrouski
It is possible to enable CONFIG_SEMIHOSTING for STM32F429 target, but it would result in compile error. This patch adds support for semihosting for STM32F429 or any other ARMv7M target. Tested on STM32F429-DISCOVERY board. Signed-off-by: Vadzim Dambrouski ---

[U-Boot] [PATCH 4/9] x86: ivybridge: Use 'ret' instead of 'rcode'

2015-10-18 Thread Simon Glass
For consistency, use 'ret' to handle a return value. Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/sdram.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/x86/cpu/ivybridge/sdram.c b/arch/x86/cpu/ivybridge/sdram.c index

[U-Boot] [PATCH 3/9] dm: rtc: Correct rtc_read32() return value

2015-10-18 Thread Simon Glass
The current check is incorrect and will fail when any non-zero byte is read. Fix it. Signed-off-by: Simon Glass --- drivers/rtc/rtc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-uclass.c b/drivers/rtc/rtc-uclass.c index

[U-Boot] [PATCH 7/9] x86: ivybridge: Fix car_uninit() to correctly set run state

2015-10-18 Thread Simon Glass
At present a missing $ causes this code to hang when using the MRC cache/ Fix it. Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/car.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/cpu/ivybridge/car.S b/arch/x86/cpu/ivybridge/car.S index

[U-Boot] [PATCH 2/9] rtc: mc146818: Use probe() to set up the device

2015-10-18 Thread Simon Glass
At present this driver uses bind() to set up the device. The bind() method should not touch the hardware, so move the init code to probe(). Signed-off-by: Simon Glass --- drivers/rtc/mc146818.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[U-Boot] [PATCH 0/9] x86: Fix up the MRC cache on ivybridge

2015-10-18 Thread Simon Glass
At present the MRC cache on ivybridge is disabled due to a bug which was unknown. This has now been located and a fix is included in this series. In addition, the RTC functions have a few problems which prevent the checksum from being read correctly. This series fixes these and adds a few other

[U-Boot] [PATCH 5/9] x86: ivybridge: Check the RTC return value

2015-10-18 Thread Simon Glass
The RTC can fail, so check the return value for reads. Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/sdram.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/x86/cpu/ivybridge/sdram.c b/arch/x86/cpu/ivybridge/sdram.c index

[U-Boot] [PATCH 8/9] x86: ivybridge: Measure the MRC code execution time

2015-10-18 Thread Simon Glass
This code takes about 450ms without the MRC cache and about 27ms with the cache. Add a debug timer so that this time can be displayed. Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/sdram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[U-Boot] [PATCH 6/9] x86: ivybridge: Use CONFIG_ENABLE_MRC_CACHE option

2015-10-18 Thread Simon Glass
Use this option instead of a private CONFIG_CACHE_MRC_BIN option. Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/Kconfig | 6 -- arch/x86/cpu/ivybridge/car.S | 4 ++-- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/x86/cpu/ivybridge/Kconfig

[U-Boot] [PATCH 9/9] x86: ivybridge: Enable the MRC cache

2015-10-18 Thread Simon Glass
From: Bin Meng This works correctly now, so enable it. Signed-off-by: Bin Meng Dropped malloc() and adjusted commit message: Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/sdram.c | 10 ++ 1 file changed, 2

[U-Boot] [PATCH 1/9] rtc: mc146818: Add a comment to the #endif

2015-10-18 Thread Simon Glass
Add a comment to make it clear to which block the #endif relates. Signed-off-by: Simon Glass --- drivers/rtc/mc146818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/mc146818.c b/drivers/rtc/mc146818.c index 363ade3..9e94a80 100644 ---

Re: [U-Boot] [PATCH v6] nios2: convert dma_alloc_coherent to use malloc_cache_aligned

2015-10-18 Thread Thomas Chou
On 10/16/2015 04:29 PM, Thomas Chou wrote: Convert dma_alloc_coherent to use memalign. Signed-off-by: Thomas Chou --- v2 use memalign. v3 check memalign() return for out of memory. v4 use malloc_cache_aligned(). v5 use invalidate_dcache_range() as Marek

Re: [U-Boot] [PATCH 11/13] x86: baytrail: Issue full system reset in reset_cpu()

2015-10-18 Thread Bin Meng
Hi Simon, On Mon, Oct 19, 2015 at 4:27 AM, Simon Glass wrote: > Hi Bin, > > On 11 October 2015 at 22:37, Bin Meng wrote: >> With MRC cache enabled, when typing 'reset' in the U-Boot shell, >> BayTrail FSP initialization hangs at "Configuring Memory Start":

Re: [U-Boot] [PATCH 7/9] x86: ivybridge: Fix car_uninit() to correctly set run state

2015-10-18 Thread Simon Glass
Hi Bin, On 18 October 2015 at 20:23, Bin Meng wrote: > Hi Simon, > > On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass wrote: >> At present a missing $ causes this code to hang when using the MRC cache/ >> Fix it. >> >> Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 2/9] rtc: mc146818: Use probe() to set up the device

2015-10-18 Thread Simon Glass
Hi Bin, On 18 October 2015 at 20:22, Bin Meng wrote: > Hi Simon, > > On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass wrote: >> At present this driver uses bind() to set up the device. The bind() method >> should not touch the hardware, so move the init code

[U-Boot] [PATCH] net: convert altera_tse to driver model and phylib

2015-10-18 Thread Thomas Chou
Convert altera_tse to driver model and phylib. Signed-off-by: Thomas Chou --- configs/nios2-generic_defconfig | 2 + doc/device-tree-bindings/net/altera_tse.txt | 112 drivers/net/Kconfig | 9 + drivers/net/altera_tse.c

Re: [U-Boot] [PATCH v4 00/21] sf: Tunning spi-flash layer

2015-10-18 Thread Simon Glass
Hi Jagan, On 12 October 2015 at 09:00, Jagan Teki wrote: > Previous version link: > http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/233262 > > spi-flash layer need to tune a lot for better code handling and > to sync with Linux spi-nor. So below areas got updated in

Re: [U-Boot] [PATCH 09/13] x86: baytrail: Save mrc cache to spi flash

2015-10-18 Thread Simon Glass
On 11 October 2015 at 22:37, Bin Meng wrote: > Save MRC cache to SPI flash in arch_misc_init(). > > Signed-off-by: Bin Meng > --- > > arch/x86/cpu/baytrail/valleyview.c | 19 +++ > 1 file changed, 19 insertions(+) Acked-by: Simon Glass

Re: [U-Boot] [PATCH 00/13] x86: Provide a common MRC cache library and enable it for FSP

2015-10-18 Thread Simon Glass
Hi Bin, On 12 October 2015 at 02:30, Bin Meng wrote: > Hi Simon, > > On Mon, Oct 12, 2015 at 12:37 PM, Bin Meng wrote: >> This series moves existing MRC cache codes in the ivybridge cpu >> diretory to a common place and makes some changes so that every >>

Re: [U-Boot] [PATCH 10/13] x86: Enable mrc cache for bayleybay and minnowmax

2015-10-18 Thread Simon Glass
On 11 October 2015 at 22:37, Bin Meng wrote: > Now that we have added MRC cache for Intel FSP and BayTrail codes, > enable it for all BayTrail boards (Bayley Bay and Minnow Max). > > Note it turns out that FSP for Intel Atom E6xx does not produce > the HOB for NV storage, so

Re: [U-Boot] [PATCH 11/13] x86: baytrail: Issue full system reset in reset_cpu()

2015-10-18 Thread Simon Glass
Hi Bin, On 11 October 2015 at 22:37, Bin Meng wrote: > With MRC cache enabled, when typing 'reset' in the U-Boot shell, > BayTrail FSP initialization hangs at "Configuring Memory Start": > > Setting BootMode to 0 > Install PPI: 1F4C6F90-B06B-48D8-A201-BAE5F1CD7D56 >

Re: [U-Boot] [PATCH 12/13] x86: Remove unused rw-mrc-cache properties in the link and panther dts files

2015-10-18 Thread Simon Glass
Hi Bin, On 11 October 2015 at 22:37, Bin Meng wrote: > "type" and "wipe-value" are never used by the mrccache codes. > Remove them to avoid confusion. This also removes the alignment > comment in the panther dts file. > > Signed-off-by: Bin Meng > --- > >

Re: [U-Boot] [PATCH 13/13] x86: ivybridge: Correct two typos for MRC

2015-10-18 Thread Simon Glass
On 11 October 2015 at 22:37, Bin Meng wrote: > It should be MRC, not MCR. > > Signed-off-by: Bin Meng > > --- > > arch/x86/cpu/ivybridge/sdram.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Simon Glass

Re: [U-Boot] [PATCH 1/3] x86: ivybridge: Fix saving mrc cache and enable it

2015-10-18 Thread Simon Glass
Hi Bin, On 12 October 2015 at 02:30, Bin Meng wrote: > Currently sdram_initialise() saves pei_data->mrc_output directly to > gd->arch.mrc_output. This is incorrect as pei_data->mrc_output points > to an address on the stack whose content is no longer valid when we > call

Re: [U-Boot] [PATCH 2/3] x86: quark: Implement mrc cache

2015-10-18 Thread Simon Glass
On 12 October 2015 at 02:30, Bin Meng wrote: > Using existing mrccache library to implement mrc cache support > for Intel Quark. > > Signed-off-by: Bin Meng > --- > > arch/x86/cpu/quark/dram.c | 52 > +++--- >

Re: [U-Boot] [PATCH v3 08/12] cmd: bootvx: Pass netmask and gatewayip to VxWorks bootline

2015-10-18 Thread Simon Glass
On 8 October 2015 at 10:09, Simon Glass wrote: > On 8 October 2015 at 04:19, Bin Meng wrote: >> There are fields in VxWorks bootline for netmask and gatewayip. >> We can get these from U-Boot environment variables and pass them >> to VxWorks, just like

Re: [U-Boot] [PATCH v3 07/12] cmd: bootvx: Avoid strlen() calls when constructing VxWorks bootline

2015-10-18 Thread Simon Glass
On 8 October 2015 at 10:09, Simon Glass wrote: > On 8 October 2015 at 04:19, Bin Meng wrote: >> Remember the position in the VxWorks bootline buffer to avoid the call >> to strlen() each time. >> >> Signed-off-by: Bin Meng >> >> --- >>

Re: [U-Boot] [PATCH v3 01/12] x86: Initialize GDT entry 1 to be the 32-bit CS as well

2015-10-18 Thread Simon Glass
On 7 October 2015 at 21:19, Bin Meng wrote: > Some OS (like VxWorks) requires GDT entry 1 to be the 32-bit CS. > > Signed-off-by: Bin Meng > Acked-by: Simon Glass > Tested-by: Jian Luo > --- > > Changes in

Re: [U-Boot] [PATCH v3 03/12] x86: Remove quotation mark in CONFIG_HOSTNAME

2015-10-18 Thread Simon Glass
On 7 October 2015 at 21:19, Bin Meng wrote: > CONFIG_HOSTNAME is an environment varible, so that quotation mark > is not needed. > > Signed-off-by: Bin Meng > Acked-by: Simon Glass > > --- > > Changes in v3: None > Changes in v2: > -

Re: [U-Boot] [PATCH v3 02/12] x86: Move install_e820_map() out of zimage.c

2015-10-18 Thread Simon Glass
On 7 October 2015 at 21:19, Bin Meng wrote: > install_e820_map() has nothing to do with zimage related codes. > Move it to a dedicated place. > > Signed-off-by: Bin Meng > Acked-by: Simon Glass > > --- > > Changes in v3: None > Changes

Re: [U-Boot] [PATCH v3 04/12] cmd: Convert CONFIG_CMD_ELF to Kconfig

2015-10-18 Thread Simon Glass
On 7 October 2015 at 21:19, Bin Meng wrote: > Convert CONFIG_CMD_ELF to Kconfig and tidy up affected boards. > > Signed-off-by: Bin Meng > > --- > > Changes in v3: None > Changes in v2: > - Split the defconfig reorder to another patch, making this patch >

Re: [U-Boot] [PATCH 6/6] x86: Allow disabling IGD on Intel Queensbay

2015-10-18 Thread Simon Glass
On 3 October 2015 at 08:29, Simon Glass wrote: > Hi Bin, > > On 1 October 2015 at 08:36, Bin Meng wrote: >> Add a Kconfig option to disable the Integrated Graphics Device (IGD) >> so that it does not show in the PCI configuration space as a VGA >> disaplay

Re: [U-Boot] [PATCH 4/6] dm: pci: Enable VGA address forwarding on bridges

2015-10-18 Thread Simon Glass
On 3 October 2015 at 08:29, Simon Glass wrote: > On 1 October 2015 at 08:36, Bin Meng wrote: >> To support graphics card behind a PCI bridge, the bridge control >> register (offset 0x3e) in the configuration space must turn on >> VGA address forwarding. >>

Re: [U-Boot] [PATCH 5/6] x86: ivybridge: Remove the dead codes that programs pci bridge

2015-10-18 Thread Simon Glass
On 3 October 2015 at 08:29, Simon Glass wrote: > On 1 October 2015 at 08:36, Bin Meng wrote: >> Remove bd82x6x_pci_bus_enable_resources() that is not called anywhere. >> >> Signed-off-by: Bin Meng >> --- >> >>

Re: [U-Boot] [PATCH v3 06/12] cmd: elf: Reorder load_elf_image_phdr() and load_elf_image_shdr()

2015-10-18 Thread Simon Glass
On 7 October 2015 at 21:19, Bin Meng wrote: > Move load_elf_image_phdr() and load_elf_image_shdr() to the beginning > of the cmd_elf.c so that forward declaration is not needed. > > Signed-off-by: Bin Meng > Reviewed-by: Tom Rini > ---

Re: [U-Boot] [PATCH 3/6] dm: pci: Fix pci_last_busno() to return the real last bus no

2015-10-18 Thread Simon Glass
On 3 October 2015 at 08:29, Simon Glass wrote: > On 1 October 2015 at 08:36, Bin Meng wrote: >> Currently pci_last_busno() only checks the last bridge device >> under the first UCLASS_PCI device. This is not the case when >> there are multiple bridge

Re: [U-Boot] [PATCH v3 05/12] cmd: Clean up cmd_elf a little bit

2015-10-18 Thread Simon Glass
On 7 October 2015 at 21:19, Bin Meng wrote: > This commit cleans up cmd_elf.c per U-Boot coding convention, > and removes the unnecessary DECLARE_GLOBAL_DATA_PTR and out-of-date > powerpc comments (it actually supports not only powerpc targets). > > Signed-off-by: Bin Meng

Re: [U-Boot] [PATCH 2/6] dm: core: Adjust device.h header file order

2015-10-18 Thread Simon Glass
On 28 September 2015 at 23:32, Simon Glass wrote: > Move a few functions around so that the ordering is consistent. > > Signed-off-by: Simon Glass > --- > > include/dm/device.h | 26 +- > 1 file changed, 13 insertions(+), 13

Re: [U-Boot] [PATCH v3] common: Fix load and entry addresses in FIT image

2015-10-18 Thread Simon Glass
Hi, On 18 October 2015 at 06:18, Simon Glass wrote: > On 9 September 2015 at 12:07, Simon Glass wrote: >> >> On Friday, 4 September 2015, York Sun wrote: >> > >> > FIT image supports more than 32 bits in addresses by using

Re: [U-Boot] [PATCH 1/6] dm: Rename dev_get_parentdata() to dev_get_parent_priv()

2015-10-18 Thread Simon Glass
On 29 September 2015 at 11:45, Joe Hershberger wrote: > Hi Simon, > > On Tue, Sep 29, 2015 at 12:32 AM, Simon Glass wrote: >> The current name is inconsistent with other driver model data access >> functions. Rename it and fix up all users. >> >>

Re: [U-Boot] [PATCH 3/6] dm: core: Fix device flag whitespace

2015-10-18 Thread Simon Glass
On 28 September 2015 at 23:32, Simon Glass wrote: > Line up the flag values in the code for easier readability. > > Signed-off-by: Simon Glass > --- > > include/dm/device.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied to

Re: [U-Boot] [PATCH 5/6] dm: core: Remove a comment about dropping per_child_auto_alloc_size

2015-10-18 Thread Simon Glass
On 28 September 2015 at 23:32, Simon Glass wrote: > This has proven useful and we no-longer intend to remove it. Drop the > comment. > > Signed-off-by: Simon Glass > --- > > include/dm/device.h | 4 > 1 file changed, 4 deletions(-) > Applied to

Re: [U-Boot] [PATCH] nios2: zap nios2-generic board dir

2015-10-18 Thread Marek Vasut
On Monday, October 19, 2015 at 01:41:48 AM, Thomas Chou wrote: > Hi Marek, Hi, > On 10/18/2015 11:35 PM, Marek Vasut wrote: > >> +config SYS_CONFIG_NAME > >> + string "Board header file" > >> + help > >> +This option should contain the base name of board header file. > >> +The header

Re: [U-Boot] usb start crashing on arndale

2015-10-18 Thread Simon Glass
Hi, On 5 April 2014 at 06:50, armdev wrote: > Dear batao / Inderpal, > > ping works only a few times after a number of usb reset / start attempts. > We are using linux 3.13 (exynos_defconfig) and rootfs linaro saucy server. > > Upon linux boot there is only lo in ifconfig.

Re: [U-Boot] [PATCH 3/4] x86: fsp: Make hob command a sub-command to fsp

2015-10-18 Thread Simon Glass
On 10 October 2015 at 02:47, Bin Meng wrote: > Introduce a new fsp command and make the existing hob command a > sub-command to fsp for future extension. Also move cmd_hob.c to > the dedicated fsp sub-directory in arch/x86/lib. > > Signed-off-by: Bin Meng

Re: [U-Boot] [PATCH 1/4] x86: fsp: Compact the output of hob command

2015-10-18 Thread Simon Glass
Hi Bin, On 10 October 2015 at 05:01, Bin Meng wrote: > On Sat, Oct 10, 2015 at 4:47 PM, Bin Meng wrote: >> Compact hob command output, especially by making hob type string a >> little bit shorter so that we can leave room for future extension. >> >>

Re: [U-Boot] [PATCH v2 02/13] x86: fsp: Report correct number of E820 table entries

2015-10-18 Thread Simon Glass
Hi Tom, On 18 October 2015 at 09:55, Tom Rini wrote: > On Sun, Oct 18, 2015 at 06:58:51AM -0600, Simon Glass wrote: >> Hi Tom, >> >> On 28 September 2015 at 22:52, Simon Glass wrote: >> > On 28 September 2015 at 03:11, Bin Meng wrote:

Re: [U-Boot] [PATCH 1/4] x86: fsp: Compact the output of hob command

2015-10-18 Thread Simon Glass
On 10 October 2015 at 02:47, Bin Meng wrote: > Compact hob command output, especially by making hob type string a > little bit shorter so that we can leave room for future extension. > > Signed-off-by: Bin Meng > --- > > arch/x86/lib/cmd_hob.c | 28

Re: [U-Boot] [PATCH v3 2/8] board_init_f_mem(): Don't require memset()

2015-10-18 Thread Simon Glass
Hi Albert, On 18 October 2015 at 10:28, Albert ARIBAUD wrote: > Hello Simon, > > On Sat, 17 Oct 2015 15:06:55 -0600, Simon Glass > wrote: >> Unfortunately memset() is not always available, so provide a substitute when >> needed. >> >> Signed-off-by:

Re: [U-Boot] [PATCH v3 7/8] zynq: Move SPL console init out of board_init_f()

2015-10-18 Thread Simon Glass
Hi Albert, On 18 October 2015 at 10:36, Albert ARIBAUD wrote: > Hello Simon, > > On Sat, 17 Oct 2015 15:07:00 -0600, Simon Glass > wrote: >> We should not init the console this early and there is no need to. If we want >> to do early init it can be

Re: [U-Boot] [PATCH 26/28] input: Convert i8042 to driver model

2015-10-18 Thread Simon Glass
Hi Bin, On 18 October 2015 at 17:17, Simon Glass wrote: > Hi Bin, > > On 15 September 2015 at 00:12, Bin Meng wrote: >> Hi Simon, >> >> On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >>> Adjust this driver to support driver model.

Re: [U-Boot] [PATCH 26/28] input: Convert i8042 to driver model

2015-10-18 Thread Bin Meng
Hi Simon, On Mon, Oct 19, 2015 at 7:17 AM, Simon Glass wrote: > Hi Bin, > > On 15 September 2015 at 00:12, Bin Meng wrote: >> Hi Simon, >> >> On Wed, Sep 9, 2015 at 12:32 PM, Simon Glass wrote: >>> Adjust this driver to support driver

Re: [U-Boot] [PATCH 2/6] video: vesa_fb: Fix wrong return value check of pci_find_class()

2015-10-18 Thread Simon Glass
On 7 October 2015 at 12:40, Anatolij Gustschin wrote: > On Thu, 1 Oct 2015 00:36:00 -0700 > Bin Meng wrote: > >> When pci_find_class() fails to find a device, it returns -ENODEV. >> But now we check the return value against -1. Fix it. >> >> Signed-off-by: Bin

Re: [U-Boot] Remove sparc archiecture?

2015-10-18 Thread Daniel Hellstrom
On 10/18/2015 05:20 PM, Masahiro Yamada wrote: (+CC Francois) 2015-10-18 21:24 GMT+09:00 Tom Rini : On Sun, Oct 18, 2015 at 06:19:16AM -0600, Simon Glass wrote: Hi, It looks like sparc has no maintainer and has not been converted to generic board. Should we remove it?

Re: [U-Boot] [PATCH 1/6] pci: Set PCI_COMMAND_IO bit for VGA device

2015-10-18 Thread Simon Glass
On 3 October 2015 at 08:29, Simon Glass wrote: > On 1 October 2015 at 08:35, Bin Meng wrote: >> PCI_COMMAND_IO bit must be set for VGA device as it needs to respond >> to legacy VGA IO address. >> >> Signed-off-by: Bin Meng >> --- >> >>

Re: [U-Boot] [PATCH v2 2/3] x86: spi: Add support for Wildcat Point

2015-10-18 Thread Simon Glass
On 12 October 2015 at 15:18, George McCollister wrote: > Add the Wildcat Point ID so Broadwell U based boards can use SPI. > > Signed-off-by: George McCollister > Reviewed-by: Bin Meng > --- > Changes for V2: > Add

Re: [U-Boot] [PATCH v2 1/3] x86: pci: Add PCI IDs for Wildcat Point

2015-10-18 Thread Simon Glass
On 12 October 2015 at 15:18, George McCollister wrote: > Add Wildcat Point AHCI and LPC PCI IDs which are present on Broadwell U > based (and possibly other) boards. > > Signed-off-by: George McCollister > Reviewed-by: Bin Meng

Re: [U-Boot] [PATCH] pci: Fix expansion ROM programming for multi-function devices

2015-10-18 Thread Simon Glass
On 8 October 2015 at 18:30, Bin Meng wrote: > Hi Simon, > > On Fri, Oct 9, 2015 at 2:10 AM, Simon Glass wrote: >> Hi Bin, >> >> On 8 October 2015 at 19:07, Simon Glass wrote: >>> On 7 October 2015 at 10:13, Bin Meng

Re: [U-Boot] [PATCH 2/9] rtc: mc146818: Use probe() to set up the device

2015-10-18 Thread Bin Meng
Hi Simon, On Mon, Oct 19, 2015 at 10:26 AM, Simon Glass wrote: > Hi Bin, > > On 18 October 2015 at 20:22, Bin Meng wrote: >> Hi Simon, >> >> On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass wrote: >>> At present this driver uses bind() to

Re: [U-Boot] [PATCH 11/13] x86: baytrail: Issue full system reset in reset_cpu()

2015-10-18 Thread Bin Meng
Hi Simon, On Mon, Oct 19, 2015 at 10:24 AM, Simon Glass wrote: > Hi Bin, > > On 18 October 2015 at 20:01, Bin Meng wrote: >> Hi Simon, >> >> On Mon, Oct 19, 2015 at 4:27 AM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 11 October 2015 at

Re: [U-Boot] [RFC PATCH] x86: Support booting SeaBIOS

2015-10-18 Thread Simon Glass
Hi Bin, On 10 October 2015 at 02:57, Bin Meng wrote: > Hi Simon, > > On Sat, Oct 3, 2015 at 10:29 PM, Simon Glass wrote: >> Hi Bin, >> >> On 29 September 2015 at 11:17, Bin Meng wrote: >>> SeaBIOS is an open source implementation of a

Re: [U-Boot] [PATCH 1/3] x86: ivybridge: Fix saving mrc cache and enable it

2015-10-18 Thread Simon Glass
Hi Bin, On 18 October 2015 at 20:44, Bin Meng wrote: > Hi Simon, > > On Mon, Oct 19, 2015 at 4:27 AM, Simon Glass wrote: >> Hi Bin, >> >> On 12 October 2015 at 02:30, Bin Meng wrote: >>> Currently sdram_initialise() saves

[U-Boot] [PATCH v2 04/28] input: Add the keycode translation tables separately

2015-10-18 Thread Simon Glass
Require the caller to add the keycode translation tables separately so that it can select which ones to use. In a later patch we will add the option to add German tables. Signed-off-by: Simon Glass --- Changes in v2: - Add error checking to input_add_tables()

[U-Boot] [PATCH v2 01/28] dm: input: Create a keyboard uclass

2015-10-18 Thread Simon Glass
Add a uclass for keyboard input, mirroring the existing stdio methods. This is enabled by a new CONFIG_DM_KEYBOARD option. Signed-off-by: Simon Glass Reviewed-by: Marek Vasut --- Changes in v2: - Add more debug info to input_init() for when it fails - Support

[U-Boot] [PATCH v2 00/28] dm: input: Move keyboard drivers to driver model

2015-10-18 Thread Simon Glass
This series adds a new uclass for keyboards and converts some drivers over to use it. This series includes some work to remove code duplication in the keyboard drivers by updating them to use the input library (input.c). This unifies the keycode decoding logic in one place. In order to do this

[U-Boot] [PATCH v2 05/28] cros_ec: Use udevice instead of cros_ec_dev for keyboard functions

2015-10-18 Thread Simon Glass
In preparation for converting the cros_ec keyboard driver to driver model, adjust the cros_ec functions it will use to use a normal struct udevice. Signed-off-by: Simon Glass --- Changes in v2: None drivers/input/cros_ec_keyb.c | 4 ++-- drivers/misc/cros_ec.c | 14

[U-Boot] [PATCH v2 02/28] input: Add a device pointer to the input config

2015-10-18 Thread Simon Glass
The read_keys() method in input is passed a struct input_config. Add a device pointer there so that we can find out the device that is referred to with driver model. Once all drivers are converted we can update the input structure to use driver model instead. Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH v2 1/5] debug_uart: Adjust the declaration of debug_uart_init()

2015-10-18 Thread Bin Meng
Hi Simon, On Mon, Oct 19, 2015 at 9:51 AM, Simon Glass wrote: > We want to be able to add other common code to this function. So change the > driver's version to have an underscore before it, just like > _debug_uart_putc(). Define debug_uart_init() to call this version. > >

[U-Boot] [PATCH v2 11/28] i8042: Adjust kbd_reset() to collect all failures

2015-10-18 Thread Simon Glass
Rather than lots of 'return' statements, use goto to a single return. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/input/i8042.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[U-Boot] [PATCH v2 03/28] input: Return -ENOSPC when there is not space

2015-10-18 Thread Simon Glass
Return a useful error instead of -1 when something goes wrong. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None drivers/input/input.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/input.c

Re: [U-Boot] [PATCH 4/4] x86: fsp: Add a hdr sub-command to show header information

2015-10-18 Thread Simon Glass
On 18 October 2015 at 14:26, Simon Glass wrote: > On 10 October 2015 at 02:47, Bin Meng wrote: >> It would be helpful to have a command to show FSP header. So far >> it only supports FSP header which conforms to FSP spec 1.0. >> >> Signed-off-by: Bin Meng

Re: [U-Boot] [PATCH 01/13] x86: Add ENABLE_MRC_CACHE Kconfig option

2015-10-18 Thread Simon Glass
On 18 October 2015 at 14:26, Simon Glass wrote: > On 11 October 2015 at 22:37, Bin Meng wrote: >> Create a Kconfig option for enabling MRC cache. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/Kconfig | 8 >> 1 file

Re: [U-Boot] [PATCH 2/4] x86: fsp: Print GUID whenever applicable in the hob command output

2015-10-18 Thread Simon Glass
On 18 October 2015 at 14:26, Simon Glass wrote: > On 10 October 2015 at 02:47, Bin Meng wrote: >> When examining a HOB, it's useful to see which GUID this HOB >> belongs to. Add GUID output in the hob command to aid this. >> >> Signed-off-by: Bin Meng

Re: [U-Boot] [PATCH 02/13] x86: Move mrccache.[c|h] to a common place

2015-10-18 Thread Simon Glass
On 18 October 2015 at 14:26, Simon Glass wrote: > On 11 October 2015 at 22:37, Bin Meng wrote: >> mrccache implementation can be common for all boards. Move it >> from ivybridge cpu directory to the common lib directory. >> >> Signed-off-by: Bin Meng

  1   2   3   >