Re: [U-Boot] [PATCH v5] arm: Add sata support on Layerscape ARMv8 board

2015-12-06 Thread Sinan Akman
Hi Yuantian On 07/12/15 02:04 AM, Yuantian Tang wrote: [...] They are in the same file but different functions. OK I think uboot know that and choice to not fix it because for uboot supporting two sata port is not that significant. [...] Please point out what's wrong with this patch.

Re: [U-Boot] [PATCH v5] arm: Add sata support on Layerscape ARMv8 board

2015-12-06 Thread Yuantian Tang
Hi Sinan, > -Original Message- > From: Sinan Akman [mailto:si...@writeme.com] > Sent: Monday, December 07, 2015 2:04 PM > To: Tang Yuantian-B29983 ; Sun York-R58495 > > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH v5] arm: Add sata support on Layerscape > ARMv8 board > > >

Re: [U-Boot] [PATCH v2] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Masahiro Yamada
2015-12-07 15:54 GMT+09:00 Jagan Teki : > Used quite different name's and e-mail address, all of > them mapped to standard name and e-mail address. > > Cc: Tom Rini > Cc: Masahiro Yamada > Signed-off-by: Jagan Teki > --- > Changes for v2: > - Use simple mapping > > .mailmap | 6 +- >

Re: [U-Boot] [PATCH 2/7] arm: socfpga: socrates: Add missing PHY skew config

2015-12-06 Thread Chin Liang See
On Sat, 2015-12-05 at 21:41 +0100, Marek Vasut wrote: > Add missing KSZ9021 PHY skew configuration for the EBV socrates > board. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Chin Liang See > Cc: Dinh Nguyen > --- > arch/arm/dts/socfpga_cyclone5_socrates.dts | 9 + > 1 fi

Re: [U-Boot] [PATCH] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Jagan Teki
On 7 December 2015 at 12:13, Masahiro Yamada wrote: > 2015-12-07 15:33 GMT+09:00 Jagan Teki : >> On Monday 07 December 2015 11:45 AM, Masahiro Yamada wrote: >>> >>> 2015-12-07 15:10 GMT+09:00 Jagan Teki : Hi Masahiro, On Monday 07 December 2015 11:36 AM, Masahiro Yamada wr

[U-Boot] [PATCH v2] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Jagan Teki
Used quite different name's and e-mail address, all of them mapped to standard name and e-mail address. Cc: Tom Rini Cc: Masahiro Yamada Signed-off-by: Jagan Teki --- Changes for v2: - Use simple mapping .mailmap | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a

Re: [U-Boot] [PATCH] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Masahiro Yamada
2015-12-07 15:33 GMT+09:00 Jagan Teki : > On Monday 07 December 2015 11:45 AM, Masahiro Yamada wrote: >> >> 2015-12-07 15:10 GMT+09:00 Jagan Teki : >>> >>> Hi Masahiro, >>> >>> >>> On Monday 07 December 2015 11:36 AM, Masahiro Yamada wrote: Hi Jagan, 2015-12-07 14:54 GMT+09

Re: [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig

2015-12-06 Thread Thomas Chou
HI Marek, On 2015年12月07日 02:52, Marek Vasut wrote: On Sunday, December 06, 2015 at 02:19:56 PM, Thomas Chou wrote: Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files. This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected. Repor

Re: [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig

2015-12-06 Thread Thomas Chou
Hi Bin, On 2015年12月07日 09:50, Bin Meng wrote: Hi Thomas, On Sun, Dec 6, 2015 at 9:19 PM, Thomas Chou wrote: Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB from legacy board header files. This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE are selected. Reported-b

Re: [U-Boot] [PATCH v5] arm: Add sata support on Layerscape ARMv8 board

2015-12-06 Thread Sinan Akman
Hi Yuantian On 06/12/15 10:09 PM, Yuantian Tang wrote: Hi York, Please see explanation inline. [...] I was trying to use one function for all, but I found separating them is better. Take ls1043a and ls2080a as an example, ls2080a has two controllers, while ls1043a has one. Ls2080a has two r

Re: [U-Boot] [PATCH] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Jagan Teki
On Monday 07 December 2015 11:45 AM, Masahiro Yamada wrote: 2015-12-07 15:10 GMT+09:00 Jagan Teki : Hi Masahiro, On Monday 07 December 2015 11:36 AM, Masahiro Yamada wrote: Hi Jagan, 2015-12-07 14:54 GMT+09:00 Jagan Teki : Used quite different name's and e-mail address, all of them mapped

Re: [U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-06 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > I think your change would causes non-standard shell behaviour. > > > > If you want to evaluate variables, you have to do so as part of a > > "run" command... > > I find the recursive behaviour much more useful. In particular we have > to jump through all

Re: [U-Boot] [PATCH 4/6] arm: socfpga: Switch CONFIG_HOSTNAME to CONFIG_SYS_BOARD

2015-12-06 Thread Chin Liang See
On Sat, 2015-12-05 at 21:44 +0100, Marek Vasut wrote: > We already have the CONFIG_SYS_BOARD variable, which defines the name > of the board. The value in CONFIG_HOSTNAME is exactly the same and is > thus just a duplicity, so switch it to reuse CONFIG_SYS_BOARD . > > Signed-off-by: Marek Vasut >

Re: [U-Boot] u-boot retries with fallback to other images

2015-12-06 Thread Wolfgang Denk
Dear Brendan, In message <5663b74e.7000...@etrix.com.au> you wrote: > > Is there any documentation or u-boot support for having a list of boot > images to try, starting with the first in the list, trying 1, 2 or 3 > times, then trying the next in the list. > > e.g. boot kernel at mmcblk0p3, then

Re: [U-Boot] [PATCH 3/6] arm: socfpga: Switch CONFIG_G_DNL_MANUFACTURER to CONFIG_SYS_VENDOR

2015-12-06 Thread Chin Liang See
On Sat, 2015-12-05 at 21:44 +0100, Marek Vasut wrote: > We already have the CONFIG_SYS_VENDOR variable, which defines the > manufacturer of the board. The value in CONFIG_G_DNL_MANUFACTURER > is just a duplicity, so switch it to reuse CONFIG_SYS_VENDOR . > > Signed-off-by: Marek Vasut > Cc: Chin

Re: [U-Boot] [PATCH] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Masahiro Yamada
2015-12-07 15:10 GMT+09:00 Jagan Teki : > Hi Masahiro, > > > On Monday 07 December 2015 11:36 AM, Masahiro Yamada wrote: >> >> Hi Jagan, >> >> 2015-12-07 14:54 GMT+09:00 Jagan Teki : >>> >>> Used quite different name's and e-mail address, all of >>> them mapped to standard name and e-mail address.

Re: [U-Boot] [PATCH 2/6] arm: socfpga: sockit: Zap VIRTUAL_TARGET

2015-12-06 Thread Chin Liang See
On Sat, 2015-12-05 at 21:44 +0100, Marek Vasut wrote: > There is no VT for this board, so remove this incorrect macro. > > Signed-off-by: Marek Vasut > Cc: Chin Liang See > Cc: Dinh Nguyen > --- > include/configs/socfpga_sockit.h | 4 > 1 file changed, 4 deletions(-) > Reviewed-by: Chin

Re: [U-Boot] [PATCH 1/6] arm: socfpga: de0_nano: Zap VIRTUAL_TARGET

2015-12-06 Thread Chin Liang See
On Sat, 2015-12-05 at 21:44 +0100, Marek Vasut wrote: > There is no VT for this board, so remove this incorrect macro. > > Signed-off-by: Marek Vasut > Cc: Chin Liang See > Cc: Dinh Nguyen > --- > include/configs/socfpga_de0_nano_soc.h | 4 > 1 file changed, 4 deletions(-) > Reviewed-by

Re: [U-Boot] [PATCH] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Jagan Teki
Hi Masahiro, On Monday 07 December 2015 11:36 AM, Masahiro Yamada wrote: Hi Jagan, 2015-12-07 14:54 GMT+09:00 Jagan Teki : Used quite different name's and e-mail address, all of them mapped to standard name and e-mail address. Cc: Tom Rini Cc: Masahiro Yamada Signed-off-by: Jagan Teki ---

Re: [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig

2015-12-06 Thread Chin Liang See
On Sun, 2015-12-06 at 21:19 +0800, Thomas Chou wrote: > Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB > from legacy board header files. > > This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE > are selected. > > Reported-by: Pavel Machek > Signed-off-by: Thomas Chou

Re: [U-Boot] [PATCH] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Masahiro Yamada
Hi Jagan, 2015-12-07 14:54 GMT+09:00 Jagan Teki : > Used quite different name's and e-mail address, all of > them mapped to standard name and e-mail address. > > Cc: Tom Rini > Cc: Masahiro Yamada > Signed-off-by: Jagan Teki > --- > .mailmap | 6 +- > 1 file changed, 5 insertions(+), 1 del

[U-Boot] [PATCH] mailmap: Update Jagan Teki's name and email address

2015-12-06 Thread Jagan Teki
Used quite different name's and e-mail address, all of them mapped to standard name and e-mail address. Cc: Tom Rini Cc: Masahiro Yamada Signed-off-by: Jagan Teki --- .mailmap | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index e1c6663..2ec05ed 10

Re: [U-Boot] [PATCH 1/2] i2c: cmd: Relocate subcommands when MANUAL_RELOC

2015-12-06 Thread Heiko Schocher
Hello Michal, Am 04.12.2015 um 17:05 schrieb Michal Simek: Subcommands contain pointers to functions which are not updated when MANUAL_REALOC is enabled. This patch fix it. Signed-off-by: Michal Simek --- common/cmd_i2c.c | 16 1 file changed, 12 insertions(+), 4 deletions

Re: [U-Boot] [PATCH] mkimage : Fix generating multi and script images

2015-12-06 Thread Simon Glass
Hi Philippe, On 3 December 2015 at 14:11, Philippe De Swert wrote: > Seems 92a655c3 broke creating multi and script type images. > Since the file1:file2:file3 string does not get split up, > it fails on trying to open an non-existing file. > > mkimage -A arm -O linux -T multi -C none -d zImage:sp

Re: [U-Boot] [PATCH 001/159] LCD: Add an option to skip registration as an stdio output

2015-12-06 Thread Lin Huang
Hi all, i am sorry send wrong patch, please ignore these patchs. 2015-12-07 11:04 GMT+08:00 Lin Huang : > From: Stephane Ayotte > > This patch adds an option to skip the registration of LCD stdio output for > boards that want to show different text on LCD than on serial output (or >

Re: [U-Boot] [PATCH v5] arm: Add sata support on Layerscape ARMv8 board

2015-12-06 Thread Yuantian Tang
Hi York, Please see explanation inline. > -Original Message- > From: York Sun [mailto:york...@freescale.com] > Sent: Saturday, December 05, 2015 1:25 AM > To: Tang Yuantian-B29983 > Cc: u-boot@lists.denx.de; si...@writeme.com > Subject: Re: [PATCH v5] arm: Add sata support on Layerscape

[U-Boot] [PATCH 2/2] rockchip: Add basic support for kylin board

2015-12-06 Thread Lin Huang
kylin board use rk3036 SOC, 512M sdram, 8G emmc. This add some basic files required to allow the board to output serial message and can run command(mmc info etc). Signed-off-by: Lin Huang --- arch/arm/mach-rockchip/rk3036/Kconfig | 4 +++ board/kylin/kylin_rk3036/Kconfig| 15 +

[U-Boot] [PATCH 1/2] rockchip: rk3036 sdram setting cs1_row when rank larger than 1

2015-12-06 Thread Lin Huang
only rank large than 1, we will use cs1_row, so check rank, when rank larger than 1, we set the cs1_row. Signed-off-by: Lin Huang --- arch/arm/mach-rockchip/rk3036/sdram_rk3036.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/rk3036/sdram_rk3036.c

[U-Boot] [PATCH 001/159] LCD: Add an option to skip registration as an stdio output

2015-12-06 Thread Lin Huang
From: Stephane Ayotte This patch adds an option to skip the registration of LCD stdio output for boards that want to show different text on LCD than on serial output (or the active stdout selected by the environment variable). Signed-off-by: Stephane Ayotte --- common/lcd.c | 13 +

[U-Boot] [PATCH 003/159] cgtqmx6eval: Add SPI NOR flash support

2015-12-06 Thread Lin Huang
From: Otavio Salvador Add SPI NOR support: => sf probe SF: Detected SST25VF032B with page size 256 Bytes, erase size 4 KiB, total 4 MiB Signed-off-by: Otavio Salvador Reviewed-by: Fabio Estevam --- board/congatec/cgtqmx6eval/cgtqmx6eval.c | 29 + include/configs/c

[U-Boot] [PATCH 002/159] arm: mx6: Reduce SPL malloc pool size

2015-12-06 Thread Lin Huang
From: Marek Vasut Using 50 MiB malloc pool in SPL is nonsense. Since the caches are not enabled in SPL, it takes 2 seconds to init the pool and has no obvious benefit. Reduce the size to 1 MiB. Signed-off-by: Marek Vasut Cc: Stefano Babic Cc: Tim Harvey Tested-by: Stefano Babic Acked-by: Tim

Re: [U-Boot] [PATCH v3 1/2] fdt: Deprecate "usbethaddr" usage in fdt_fixup_ethernet()

2015-12-06 Thread Bin Meng
Hi Joe, On Tue, Nov 3, 2015 at 8:24 PM, Bin Meng wrote: > In fdt_fixup_ethernet() only "usbethaddr" is handled to fix up the > first usb ethernet port MAC address. Other additional usb ethernet > ports are ignored as there is no logic to handle "usbeth%daddr". > > It is suggested we should use "e

Re: [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig

2015-12-06 Thread Bin Meng
Hi Thomas, On Sun, Dec 6, 2015 at 9:19 PM, Thomas Chou wrote: > Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB > from legacy board header files. > > This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE > are selected. > > Reported-by: Pavel Machek > Signed-off-by: Thom

Re: [U-Boot] mmc erase fails from U-Boot command line

2015-12-06 Thread Fabio Estevam
Hi Eric, On Fri, Dec 4, 2015 at 8:42 PM, Eric Nelson wrote: > I've figured out a way to repeat this on my machine. > > If I write 0xff's to the eMMC blocks, then issue an erase for the same, > I get the problem with each MMC_ERASE command. > > I've also found something that fixes the issue in my

[U-Boot] [PULL] u-boot-usb/master

2015-12-06 Thread Marek Vasut
The following changes since commit 75507d5d5496a691aecb731f87d4d8d5cdf62b77: am33xx: Update serial pdata (2015-12-06 16:38:05 -0500) are available in the git repository at: git://git.denx.de/u-boot-usb.git for you to fetch changes up to 6af4e2782d1300015ab1c3c28e9faa5c96d93f19: usb: xhc

[U-Boot] [PULL] u-boot-socfpga/master

2015-12-06 Thread Marek Vasut
The following changes since commit 75507d5d5496a691aecb731f87d4d8d5cdf62b77: am33xx: Update serial pdata (2015-12-06 16:38:05 -0500) are available in the git repository at: git://git.denx.de/u-boot-socfpga.git for you to fetch changes up to 540fcbca7e960b2855e7666fff8f11a7119341ee: arm:

Re: [U-Boot] [PATCH] am33xx: Update serial pdata

2015-12-06 Thread Tom Rini
On Sun, Dec 06, 2015 at 08:43:36AM -0800, Simon Glass wrote: > Hi Tom, > > On 6 December 2015 at 08:10, Tom Rini wrote: > > We now want to make sure that we have the platform data for NS16550 when > > we do not have OF_CONTROL set. > > > > Signed-off-by: Tom Rini > > --- > > arch/arm/cpu/armv7

Re: [U-Boot] [U-Boot,3/3] rpi: add support for Raspberry Pi Zero

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 10:07:46PM -0700, Stephen Warren wrote: > For U-Boot's purposes, at present all we care about is ensuring there's > a model table entry. > > Signed-off-by: Stephen Warren Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot,2/3] rpi: fix revision scheme parsing

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 10:07:45PM -0700, Stephen Warren wrote: > The RPi has two different schemes for encoding board revision values. > When adding RPi 2 support, I thought that the conflicting type field > values were to be interpreted based on bcm2835-vs-bcm2836. In fact, the > scheme bit dete

Re: [U-Boot] [U-Boot, 1/3] rpi: get rid of BCM2835_BOARD_REV_* macros

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 10:07:44PM -0700, Stephen Warren wrote: > There are two numbering schemes for the RPi revision values; old and new > scheme. The values within each scheme overlap. Hence, it doesn't make > sense to have absolute/global names for the revision IDs. Get rid of the > names and

Re: [U-Boot] [U-Boot, 2/4] dm: serial: ns16550: Add pre-reloc flag to the driver

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 08:58:38AM -0700, Simon Glass wrote: > For platforms that don't use device tree in SPL the only way to mark this > driver as 'required by relocation' is with the DM_FLAG_PRE_RELOC flag. Add > this to ensure that the driver is bound. > > Fixes: fde7e18938d8 ("dm: tegra: pci

Re: [U-Boot] [U-Boot, 3/4] dm: tegra: Provide serial platform data for SPL

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 08:58:39AM -0700, Simon Glass wrote: > At present an incorrect #if term is preventing this data from being compiled > in. All tegra boards use driver model for serial, so we can just drop this. > > Fixes: fde7e18938d8 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig") >

Re: [U-Boot] [U-Boot, 1/4] tegra: Remove merge markers in some Kconfig files

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 08:58:37AM -0700, Simon Glass wrote: > These were added by mistake in commit fde7e189. They cause a warning when > configuring the boards. Remove them. > > Fixes: fde7e18938d8 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig") > Signed-off-by: Simon Glass > Reported-by:

Re: [U-Boot] [U-Boot, 1/3] rpi: get rid of BCM2835_BOARD_REV_* macros

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 10:07:44PM -0700, Stephen Warren wrote: > There are two numbering schemes for the RPi revision values; old and new > scheme. The values within each scheme overlap. Hence, it doesn't make > sense to have absolute/global names for the revision IDs. Get rid of the > names and

Re: [U-Boot] [U-Boot, v4] common: board: Dont relocate FDT incase of CONFIG_OF_EMBED

2015-12-06 Thread Tom Rini
On Thu, Dec 03, 2015 at 03:46:03PM +0100, Michal Simek wrote: > From: Siva Durga Prasad Paladugu > > Don't relocate fdt in case of CONFIG_OF EMBED as the fdt is > already embedded with u-boot image. > Update fdt_blob after relocation as the fdt will be copied > during u-boot relocation. > > Sig

Re: [U-Boot] mkimage : Fix generating multi and script images

2015-12-06 Thread Tom Rini
On Fri, Dec 04, 2015 at 12:11:23AM +0200, Philippe De Swert wrote: > Seems 92a655c3 broke creating multi and script type images. > Since the file1:file2:file3 string does not get split up, > it fails on trying to open an non-existing file. > > mkimage -A arm -O linux -T multi -C none -d zImage:s

Re: [U-Boot] [U-Boot, v3, 2/3] spl: mmc: Rename 'mmc' variable to 'mmcp'

2015-12-06 Thread Tom Rini
On Wed, Dec 02, 2015 at 10:59:12AM -0700, Simon Glass wrote: > The 'p' suffix makes it more obvious that we are dealing with a pointer > to a (pointer) value that will be returned to its caller. > > Signed-off-by: Simon Glass > Acked-by: Nikita Kiryanov > Tested-by: Michal Simek Applied to u-

Re: [U-Boot] [U-Boot, v3, 3/3] spl: mmc: Unify non/driver model spl_mmc_find_device()

2015-12-06 Thread Tom Rini
On Wed, Dec 02, 2015 at 10:59:13AM -0700, Simon Glass wrote: > It is risky to have two different functions with much the same code. Future > authors may update one but not the other. It is hard to see which parts are > the same and which are different. > > Unify the functions and drop the differe

Re: [U-Boot] [U-Boot, v3, 1/3] spl: mmc: Fix compiler warning with CONFIG_DM_MMC

2015-12-06 Thread Tom Rini
On Wed, Dec 02, 2015 at 10:59:11AM -0700, Simon Glass wrote: > Since commit 4188ba3 we get the following warning on rockchip boards: > > common/spl/spl_mmc.c:31:24: warning: ‘mmc’ may be used uninitialized in this > function [-Wmaybe-uninitialized] > count = mmc->block_dev.block_read(0, sector

Re: [U-Boot] drivers: remoteproc: rproc-uclass: Fix check for NULL pointers

2015-12-06 Thread Tom Rini
On Mon, Nov 30, 2015 at 10:05:58PM -0600, Nishanth Menon wrote: > Neither uc_pdata->name nor check_name are supposed to be NULL in > _rproc_name_is_unique(). if uc_pdata->name is NULL, we are not > intialized yet, however if check_data is NULL, we do not have > proper data. Further, if either were

Re: [U-Boot] [U-Boot,1/1] Change e-mail address of Kamil Lulko

2015-12-06 Thread Tom Rini
On Sun, Nov 29, 2015 at 11:50:53AM +0100, Kamil Lulko wrote: > Signed-off-by: Kamil Lulko Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailma

Re: [U-Boot] common/Makefile: Compile fdt_support is enabled in SPL

2015-12-06 Thread Tom Rini
On Thu, Nov 26, 2015 at 01:38:15PM +0100, Stefan Roese wrote: > When CONFIG_SPL_OF_TRANSLATE is enabled fdt_support.c needs to get > compiled. Otherwise fdt_translate_address() is missing which is needed > in dev_get_addr(). > > Signed-off-by: Stefan Roese > Cc: Simon Glass > Acked-by: Simon Gl

Re: [U-Boot] ns16550: change reg-shift property default to zero

2015-12-06 Thread Tom Rini
On Sun, Nov 29, 2015 at 02:01:03PM +0800, Thomas Chou wrote: > Change reg-shift property default to zero. When the integer property > is missing, it should be taken as zero. This is consistent to Linux > drivers/tty/serial/of_serial.c. > > The x86 and most powerpc use reg-shift of 0. Most others

Re: [U-Boot] [U-Boot, 4/4] arch/arm/cpu/arm920t/ep93xx/led.c: Mark inline functions as static inline

2015-12-06 Thread Tom Rini
On Sat, Nov 28, 2015 at 08:04:43AM -0500, Tom Rini wrote: > With gcc-5.x we get warning about inline non-static functions referring to > static elements. > > Signed-off-by: Tom Rini > Reviewed-by: Bin Meng Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signatur

Re: [U-Boot] [U-Boot,V2] common: cli_hush: avoid memory leak

2015-12-06 Thread Tom Rini
On Fri, Nov 27, 2015 at 10:12:02AM +0800, Peng Fan wrote: > Need to free memory avoid memory leak, when error. > > Signed-off-by: Peng Fan > Reviewed-by: Simon Glass > Cc: Simon Glass > Cc: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] common: miiphyutil: avoid memory leak

2015-12-06 Thread Tom Rini
On Thu, Nov 26, 2015 at 10:26:59AM +0800, Peng Fan wrote: > The following code will alloc memory for new_dev and ldev: > " > new_dev = mdio_alloc(); > ldev = malloc(sizeof(*ldev)); > " > Either new_dev or ldev is NULL, directly return, but this may leak memory. > So before return, using free(ldev)

Re: [U-Boot] [U-Boot, 1/2] arm: dts: dra7-evm: add chosen node to specify serial console device

2015-12-06 Thread Tom Rini
On Thu, Nov 26, 2015 at 05:25:41PM +0530, Mugunthan V N wrote: > Introduce chosen node and specify uart0 to be used as serial console. > > Signed-off-by: Mugunthan V N > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [U-Boot, 2/2] defconfig: dra74_evm: enable serial driver model

2015-12-06 Thread Tom Rini
On Thu, Nov 26, 2015 at 05:25:42PM +0530, Mugunthan V N wrote: > Enable serial driver model for dra74_evm as ns16550 supports > driver model. > > Signed-off-by: Mugunthan V N > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] arm: dts: omap: add reg-shift to serial device tree node

2015-12-06 Thread Tom Rini
On Thu, Nov 26, 2015 at 02:49:10PM +0530, Mugunthan V N wrote: > With the commit 'c7b9686d5d48 ("ns16550: unify serial_omap")' all > TI platforms are broken with DM/DT boot as ns16550 driver expects > reg-shift from DT which is not populated for TI platforms. > Earlier it worked as it was hard cod

Re: [U-Boot] common: mmc: unsigned char compared against 0

2015-12-06 Thread Tom Rini
On Wed, Nov 25, 2015 at 05:16:21PM +0800, Peng Fan wrote: > "enable" is unsigned char type and its value will not be > negative, so discard "enable < 0". > > Signed-off-by: Peng Fan > Cc: Diego Santa Cruz > Cc: Pantelis Antoniou > Cc: Andrew Gabbasov > Cc: Simon Glass > Cc: Stefano Babic >

Re: [U-Boot] Fix typo: firstly -> first.

2015-12-06 Thread Tom Rini
On Tue, Nov 24, 2015 at 02:46:24PM -0800, Vagrant Cascadian wrote: > Signed-off-by: Vagrant Cascadian > Acked-by: Marek Vasut Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@list

Re: [U-Boot] eeprom: Zap CONFIG_SYS_I2C_MULTI_EEPROMS

2015-12-06 Thread Tom Rini
On Wed, Nov 25, 2015 at 12:37:44AM +0100, Marek Vasut wrote: > This symbol is no longer used anywhere, remove it. > > Signed-off-by: Marek Vasut > Cc: Heiko Schocher > Cc: Tom Rini > Acked-by: Heiko Schocher Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital sign

Re: [U-Boot] Fix typo: commmand -> command.

2015-12-06 Thread Tom Rini
On Tue, Nov 24, 2015 at 02:45:02PM -0800, Vagrant Cascadian wrote: > Signed-off-by: Vagrant Cascadian > Reviewed-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Bo

Re: [U-Boot] [U-Boot,1/2] mpc8xx: remove stale "lwmon" files

2015-12-06 Thread Tom Rini
On Tue, Nov 24, 2015 at 02:03:00PM +0100, Wolfgang Denk wrote: > Commit acc2372d "mpc8xx: remove lwmon board support" removed support > for the MPC823 based "lwmon" board, but left some board specific POST > files. This patch cleans up and removes the now unused files. > > Signed-off-by: Wolfgan

Re: [U-Boot] common: miiphyutil: no need to check name of mii_dev

2015-12-06 Thread Tom Rini
On Tue, Nov 24, 2015 at 05:03:47PM +0800, Peng Fan wrote: > The entry name of mii_dev is an array not pointer, so > no need to check. > > Signed-off-by: Peng Fan > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Bin Meng > Reviewed-by: Simon Glass > Acked-by: Joe Hershberger > Reviewed-by: Bin

Re: [U-Boot] common: image-fdt: correct fdt_blob for IMAGE_FORMAT_LEGACY

2015-12-06 Thread Tom Rini
On Tue, Nov 24, 2015 at 04:54:22PM +0800, Peng Fan wrote: > If condition of "(load == image_start || load == image_data)" is true, > should use "fdt_addr = load;", but not "fdt_blob = (char *)image_data;", > or fdt_blob will be overridden by "fdt_blob = map_sysmem(fdt_addr, 0);" > at the end of th

Re: [U-Boot] [U-Boot,RFC] common: cli_hush: avoid dead code

2015-12-06 Thread Tom Rini
On Tue, Nov 24, 2015 at 04:54:21PM +0800, Peng Fan wrote: > Condition "(value == NULL && ++value == NULL)" actully will > always return false. > > Instead, use condition "(value == NULL || *(value + 1) == 0)" to detect > such expression "c=". To "c=", *(value + 1) is 0, so directly return -1, > b

Re: [U-Boot] common: bootm: check return value of strict_strtoul

2015-12-06 Thread Tom Rini
On Tue, Nov 24, 2015 at 04:54:20PM +0800, Peng Fan wrote: > Before continue, check return value of strict_strtoul. > > Signed-off-by: Peng Fan > Cc: Albert Aribaud > Cc: Simon Glass > Cc: Jan Kiszka > Cc: Joe Hershberger > Cc: Hans de Goede > Cc: York Sun > Cc: Tom Rini > Reviewed-by: Sim

Re: [U-Boot] [PATCH] net: eth_designware: select PHYLIB in Kconfig

2015-12-06 Thread Marek Vasut
On Sunday, December 06, 2015 at 02:19:56 PM, Thomas Chou wrote: > Select PHYLIB in drivers/net/Kconfig. And remove CONFIG_PHYLIB > from legacy board header files. > > This fixed the warnings when both ALTERA_TSE and ETH_DESIGNWARE > are selected. > > Reported-by: Pavel Machek > Signed-off-by: Th

[U-Boot] [PATCH v8 13/14] sf: Use static for file-scope functions

2015-12-06 Thread Jagan Teki
Used static for file-scope functions in sf_probe.c Cc: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_probe.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c index bf53eef..0cafc29 100644 --- a/

[U-Boot] [PATCH v8 12/14] sf: sf_probe: Remove spi_slave pointer argument

2015-12-06 Thread Jagan Teki
Since spi_slave is a spi pointer in spi_flash{} then assign spi_slave{} pointer to flash->spi and remove spi_slave pointer argument to - spi_flash_probe_slave - spi_flash_scan Cc: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_internal.h | 3 +-- drivers/mtd/spi/sf_ops.c |

[U-Boot] [PATCH v8 14/14] sf: Rename sf_ops.c to spi-flash.c

2015-12-06 Thread Jagan Teki
Since all spi-flash core operations are moved into sf_ops.c then it's better to renamed as spi-flash.c Signed-off-by: Jagan Teki --- drivers/mtd/spi/Makefile | 2 +- drivers/mtd/spi/{sf_ops.c => spi-flash.c} | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) rename d

[U-Boot] [PATCH v8 07/14] sf: Use simple name for register access functions

2015-12-06 Thread Jagan Teki
Most of the register access function are static, so used simple name to represent each. Reviewed-by: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_ops.c | 52 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/

[U-Boot] [PATCH v8 09/14] sf: Remove unneeded header includes

2015-12-06 Thread Jagan Teki
Removed unneeded header includes in sf_ops and sf_probe Reviewed-by: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_ops.c | 2 -- drivers/mtd/spi/sf_probe.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c index e5514ab..

[U-Boot] [PATCH v8 11/14] sf: ops: Fix missing break on spansion read_bar

2015-12-06 Thread Jagan Teki
For assigning read_bar commands in spansion case, break is missing this patch add that break. Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c index ef45fc1..68f191b 100644 --- a/drivers

[U-Boot] [PATCH v8 10/14] sf: Remove unneeded SST_BP and SST_WP

2015-12-06 Thread Jagan Teki
SST parts added on sf_params.c supports both SST_WR which consits of both BP and WP and there is a spi controller ich which supports only BP so the relevent _write hook set based on "slave->op_mode_tx" hence there is no respective change required from flash side hance removed these. Cc: Bin Meng

[U-Boot] [PATCH v8 06/14] sf: Fix Makefile

2015-12-06 Thread Jagan Teki
This patch removes unneeded ifdef and fixed accordingly. Reviewed-by: Bin Meng Reviewed-by: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/Makefile | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index cf4e

[U-Boot] [PATCH v8 08/14] sf: Flash power up read-only based on idcode0

2015-12-06 Thread Jagan Teki
Using macro's for flash power up read-only access code leads wrong behaviour hence use idcode0 for runtime detection, hence the flash which require this functionality gets detected at runtime. Reviewed-by: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_internal.h | 1 + drivers/mt

[U-Boot] [PATCH v8 05/14] sf: Use static for file-scope functions

2015-12-06 Thread Jagan Teki
Use static for file-scope functions and removed them from header files. Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_internal.h | 18 -- drivers/mtd/spi/sf_ops.c | 11 ++- 2 files changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/mtd/spi/sf_internal

[U-Boot] [PATCH v8 03/14] sf: Move read_id code to sf_ops

2015-12-06 Thread Jagan Teki
read_id code is related to spi_flash stuff hence moved to sf_ops. Reviewed-by: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_internal.h | 3 +-- drivers/mtd/spi/sf_ops.c | 21 ++--- drivers/mtd/spi/sf_probe.c| 15 +-- 3 files changed, 20 inse

[U-Boot] [PATCH v8 04/14] sf: probe: Code cleanup

2015-12-06 Thread Jagan Teki
- Move bar read code below the bar write hance both at once place, hence it easy for #ifdef macro only once and readable. - Move read_cmd_array at top Reviewed-by: Simon Glass Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_ops.c | 80 +++- 1 fil

[U-Boot] [PATCH v8 02/14] sf: Move spi_flash_scan code to sf_ops

2015-12-06 Thread Jagan Teki
Intension is that sf_ops should deals all spi_flash related stuff and sf_probe (which should renamed future) should be an interface layer for spi_flash versus spi drivers. sf_ops => spi_flash interface sf_probe => interface layer vs spi_flash(sf_probe) to spi drivers Reviewed-by: Simon Glass Sig

[U-Boot] [PATCH v8 00/14] sf: Tuning spi-flash layer

2015-12-06 Thread Jagan Teki
This series bypasses MTD changes from previous series[1][2] and entire series tunned spi-flash layer for better code handling. Changes in v8: - Rebase to master - PATCH v8 12/14, 13/14, 14/14 added newly. Changes in v7: - Rebase to master - Few patch bisectable separations Changes in v6, v5, v4

[U-Boot] [PATCH v8 01/14] sf: spi_flash_validate_params => spi_flash_scan

2015-12-06 Thread Jagan Teki
Rename spi_flash_validate_params to spi_flash_scan as this code not only deals with params setup but also configure all spi_flash attributes. And also moved all flash related code into spi_flash_scan for future functionality addition. Reviewed-by: Simon Glass Signed-off-by: Jagan Teki --- driv

[U-Boot] [PATCH v2 1/4] tegra: Remove merge markers in some Kconfig files

2015-12-06 Thread Simon Glass
These were added by mistake in commit fde7e189. They cause a warning when configuring the boards. Remove them. Signed-off-by: Simon Glass Reported-by: Stephen Warren Reported-by: Kevin Hilman Tested-by: Stephen Warren Fixes: fde7e18938d8 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig") ---

[U-Boot] [PATCH v2 4/4] dm: omap: Fix serial UART on beaglebone black (vboot only)

2015-12-06 Thread Simon Glass
This is currently broken since it does not have the reg-shift property for the UART in the device tree. Fix it. Reported-by: Yegor Yefremov Signed-off-by: Simon Glass --- This patch does not fix the non-vboot boards. I haven't added this to the series in v2 as Tom has already sent a patch. Chan

[U-Boot] [PATCH v2 2/4] dm: serial: ns16550: Add pre-reloc flag to the driver

2015-12-06 Thread Simon Glass
For platforms that don't use device tree in SPL the only way to mark this driver as 'required by relocation' is with the DM_FLAG_PRE_RELOC flag. Add this to ensure that the driver is bound. Signed-off-by: Simon Glass Reported-by: Stephen Warren Tested-by: Stephen Warren Acked-by: Thomas Chou F

[U-Boot] [PATCH v2 3/4] dm: tegra: Provide serial platform data for SPL

2015-12-06 Thread Simon Glass
At present an incorrect #if term is preventing this data from being compiled in. All tegra boards use driver model for serial, so we can just drop this. Signed-off-by: Simon Glass Reported-by: Stephen Warren Tested-by: Stephen Warren Acked-by: Thomas Chou Fixes: 1874626b (ns16550: unify serial

[U-Boot] [PATCH] m68k: add private libgcc

2015-12-06 Thread Angelo Dureghello
Add private libgcc Signed-off-by: Angelo Dureghello --- arch/Kconfig| 1 + arch/m68k/lib/Makefile | 4 +++ arch/m68k/lib/ashldi3.c | 50 ++ arch/m68k/lib/lshrdi3.c | 50 ++ arch/m68k/lib/muldi3.c | 71 +++

Re: [U-Boot] [PATCH 2/7] spl: mmc: Explicitly init mmc struct

2015-12-06 Thread Simon Glass
Hi Sjoerd, On 4 December 2015 at 15:27, Sjoerd Simons wrote: > gcc fails to work out that the mmc variable will only ever be used if it > has been initialized by spl_mmc_get_device_index and throws the > following error: > > common/spl/spl_mmc.c: In function ‘spl_mmc_load_image’: > common/spl/spl

Re: [U-Boot] [PATCH 1/7] spl: use panic_str instead of panic

2015-12-06 Thread Simon Glass
On 4 December 2015 at 15:27, Sjoerd Simons wrote: > For a simple static string, use panic_str() which prevents calling > printf needlessly. > > Signed-off-by: Sjoerd Simons > --- > > common/spl/spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass _

Re: [U-Boot] [PATCH 2/2] dm: cmd: Relocate subcommands when MANUAL_RELOC

2015-12-06 Thread Simon Glass
On 4 December 2015 at 09:05, Michal Simek wrote: > Subcommands contain pointers to functions which are not updated when > MANUAL_REALOC is enabled. This patch fix it. > > Signed-off-by: Michal Simek > --- > > test/dm/cmd_dm.c | 14 ++ > 1 file changed, 14 insertions(+) Reviewed-by:

Re: [U-Boot] [PATCH 1/2] i2c: cmd: Relocate subcommands when MANUAL_RELOC

2015-12-06 Thread Simon Glass
On 4 December 2015 at 09:05, Michal Simek wrote: > Subcommands contain pointers to functions which are not updated when > MANUAL_REALOC is enabled. This patch fix it. > > Signed-off-by: Michal Simek > --- > > common/cmd_i2c.c | 16 > 1 file changed, 12 insertions(+), 4 deletions

Re: [U-Boot] [PATCH] common: cli_hush: Fix up simple typo

2015-12-06 Thread Simon Glass
On 4 December 2015 at 12:02, Nishanth Menon wrote: > Correct the spelling for character.. > > Signed-off-by: Nishanth Menon > --- > > common/cli_hush.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass ___ U-Boot ma

Re: [U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-06 Thread Simon Glass
Hi, On 4 December 2015 at 13:20, Wolfgang Denk wrote: > Dear Nishanth Menon, > > In message <1449255744-25787-1-git-send-email...@ti.com> you wrote: >> When we use the following in bootargs: >> v1=abc >> v2=123-${v1} >> echo ${v2} >> we get 123-${v1} >> when we should have got >> 123-abc >> This

Re: [U-Boot] [PATCH] am33xx: Update serial pdata

2015-12-06 Thread Simon Glass
Hi Tom, On 6 December 2015 at 08:10, Tom Rini wrote: > We now want to make sure that we have the platform data for NS16550 when > we do not have OF_CONTROL set. > > Signed-off-by: Tom Rini > --- > arch/arm/cpu/armv7/am33xx/board.c | 18 +++--- > 1 file changed, 7 insertions(+), 11

Re: [U-Boot] [PATCH 4/4] dm: omap: Fix serial UART on beaglebone black

2015-12-06 Thread Simon Glass
Hi Tom, On 6 December 2015 at 06:17, Tom Rini wrote: > > On Fri, Dec 04, 2015 at 08:58:40AM -0700, Simon Glass wrote: > > > This is currently broken since it does not have the reg-shift property for > > the UART in the device tree. Fix it. > > > > Reported-by: Yegor Yefremov > > Signed-off-by: S

[U-Boot] [PATCH] am33xx: Update serial pdata

2015-12-06 Thread Tom Rini
We now want to make sure that we have the platform data for NS16550 when we do not have OF_CONTROL set. Signed-off-by: Tom Rini --- arch/arm/cpu/armv7/am33xx/board.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arc

Re: [U-Boot] [PATCH v5 2/3] cfi_flash: convert to driver model

2015-12-06 Thread Jagan Teki
On 6 December 2015 at 19:05, Thomas Chou wrote: > Hi Jagan, > > On 2015年12月06日 21:10, Jagan Teki wrote: >>> >>> This probing is not specific to CFI flash. It will probe all flash >>> variants >>> of MTD uclass. >> >> >> This is something I'm unclear, suppose if I need to use MTD uclass in >> spi-f

Re: [U-Boot] dm: Introduce SPI-NOR framework

2015-12-06 Thread Jagan Teki
+ Bin On 3 December 2015 at 15:40, Jagan Teki wrote: > Hi Simon, > > I re-phrase all the question from previous thread and continue in this for > more discussion on spi-nor development. > >> Is it intended that SPI flash should be a driver for the MTD uclass? >> Others would be NAND and CFI. From

  1   2   >