Re: [U-Boot] BayTrail I2C support

2016-03-12 Thread Simon Glass
Hi Stefan, On 11 March 2016 at 10:33, Stefan Roese wrote: > Hi Simon, Hi Bin, > > could you please let me know, what the status of I2C support for > BayTrail in U-Boot is? Is this driver generic enough to handle > BayTrail / Minnowboard MAX as well (I haven't looked in depth yet)?

Re: [U-Boot] [PATCH 1/3] drivers: block: Kconfig: set default n to CONFIG_DISK

2016-03-12 Thread Simon Glass
Hi Mugunthan, On 7 March 2016 at 23:30, Mugunthan V N wrote: > Hi Simon > > On Monday 07 March 2016 08:09 AM, Simon Glass wrote: >> Hi Mugunthan, >> >> On 2 March 2016 at 22:06, Mugunthan V N wrote: >>> > When a platform is converted to support DM and

Re: [U-Boot] [PATCH] usb: Add new command to regress USB devices

2016-03-12 Thread Simon Glass
Hi, On 9 March 2016 at 21:52, Rajesh Bhagat wrote: > > >> -Original Message- >> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass >> Sent: Thursday, March 10, 2016 3:09 AM >> To: Rajat Srivastava >> Cc: U-Boot

Re: [U-Boot] buildman for sandbox

2016-03-12 Thread Simon Glass
Hi Tom, On 9 March 2016 at 13:39, Tom Rini wrote: > On Wed, Mar 09, 2016 at 10:43:58AM -0700, Simon Glass wrote: >> Hi Tom, >> >> On 8 March 2016 at 16:42, Tom Rini wrote: >> > On Sun, Mar 06, 2016 at 07:39:30PM -0700, Simon Glass wrote: >> >> Hi Joe, >>

Re: [U-Boot] [PATCH] spl: add a new stub spl_early_board_init() for early SoC-specific setup

2016-03-12 Thread Simon Glass
Hi Masahiro, On 9 March 2016 at 02:49, Masahiro Yamada wrote: > Hi Simon, > > > 2016-03-09 8:33 GMT+09:00 Simon Glass : >> Hi Masahiro, >> >> On 8 March 2016 at 04:37, Masahiro Yamada >> wrote: >>> We are

Re: [U-Boot] [PATCH] dm: core: device: set pinctrl state for pinctrl device

2016-03-12 Thread Simon Glass
+Masahiro On 11 March 2016 at 22:17, Peng Fan wrote: > We may have pinmux settings for pinctrl device, like the following > example: > " > { > pinctrl-names = "default"; > pinctrl-0 = <_hog_1>; > imx6ul-evk { > pinctrl_hog_1:

Re: [U-Boot] [PATCH 2/2] fsl: esdhc: support driver model

2016-03-12 Thread Simon Glass
Hi Peng, On 11 March 2016 at 21:21, Peng Fan wrote: > Hi Simon, > > On Fri, Mar 11, 2016 at 05:33:05PM -0700, Simon Glass wrote: >>Hi Peng, >> >>On 10 March 2016 at 01:57, Peng Fan wrote: >>> Support Driver Model for fsl esdhc driver. >>> >>> In

Re: [U-Boot] [PATCH] power: regulator: fixed: set gpio direction before set value

2016-03-12 Thread Simon Glass
Hi Peng, On 11 March 2016 at 22:19, Peng Fan wrote: > Before set value for a gpio, need to set its direction to > output first. > > Signed-off-by: Peng Fan > Cc: Przemyslaw Marczak > Cc: Simon Glass > ---

Re: [U-Boot] [PATCH v2 09/12] rockchip: rock2: dts: use status = "okay" not ok

2016-03-12 Thread Simon Glass
On 29 February 2016 at 19:03, Simon Glass wrote: > On 28 February 2016 at 14:25, Sjoerd Simons > wrote: >> u-boot only recognize okay to enable a node (Linux seems to be more >> lenient here). So use okay instead. >> >> Signed-off-by: Sjoerd

Re: [U-Boot] [PATCH v2 08/12] rockchip: rk3288-firefly: Add gmac definition

2016-03-12 Thread Simon Glass
On 28 February 2016 at 14:25, Sjoerd Simons wrote: > Add a definition for the gmac interface to the firefly device-tree. > Copied verbatim from the linux kernel. > > Signed-off-by: Sjoerd Simons > Acked-by: Simon Glass

Re: [U-Boot] [PATCH v2 05/12] rockchip: rk3288: Add clock support for the gmac ethernet interface

2016-03-12 Thread Simon Glass
On 29 February 2016 at 19:03, Simon Glass wrote: > On 28 February 2016 at 14:24, Sjoerd Simons > wrote: >> Setup the clocks for the gmac ethernet interface. This assumes the mac >> clock is fed by an external clock which is common on RK3288 based

Re: [U-Boot] [PATCH v2 06/12] rockchip: rk3288: grf: Define GRF_SOC_CON1 and GRF_SOC_CON3

2016-03-12 Thread Simon Glass
On 29 February 2016 at 19:03, Simon Glass wrote: > On 28 February 2016 at 14:25, Sjoerd Simons > wrote: >> Add definitions for GRF_SOC_CON1 and GRF_SOC_CON3 which contain various >> GMAC related fields. >> >> Signed-off-by: Sjoerd Simons

Re: [U-Boot] [PATCH v2 04/12] rockchip: rk3288: pinctrl: support more pins

2016-03-12 Thread Simon Glass
On 29 February 2016 at 19:03, Simon Glass wrote: > On 28 February 2016 at 14:24, Sjoerd Simons > wrote: >> The rgmii_pins node in rk3288.dtsi configures 15 pins. Increase the size >> of the cell array to accomedate that, otherwise only the first

Re: [U-Boot] [PATCH 5/5] doc: dt-bindings: Describe rockchip LVDS interface

2016-03-12 Thread Simon Glass
On 12 March 2016 at 06:13, Jacob Chen wrote: > I didn't have a common board to enable LVDS. > So add this dcocument to help others who want to enable LVDS in their board. > > Signed-off-by: Jacob Chen > Signed-off-by: jacob >

Re: [U-Boot] [PATCH 4/5] rockchip: video: Add LVDS support in vop driver

2016-03-12 Thread Simon Glass
On 12 March 2016 at 06:13, Jacob Chen wrote: > LVDS have a different display out mode, add code to get right flag. > > The vop_ip decied display device and the remote_vop_id decied which vop was > being used. > So we should use the remote_vop_id to set DCLK_VOP. > >

Re: [U-Boot] [PATCH 3/5] rockchip: dts: Add LVDS support

2016-03-12 Thread Simon Glass
On 12 March 2016 at 06:13, Jacob Chen wrote: > Add these node to be used in rockchip LVDS and VOP driver. > > Signed-off-by: Jacob Chen > Signed-off-by: jacob > --- > > arch/arm/dts/rk3288.dtsi | 46

Re: [U-Boot] [PATCH 1/5] dm: video: Add a operation to display uclass

2016-03-12 Thread Simon Glass
On 12 March 2016 at 06:13, Jacob Chen wrote: > The current display class only allow to get timing from edid. > So add a operation to get timing directly from driver. > In driver, I will use fdtdec_decode_display_timing to get timing. > > Signed-off-by: Jacob Chen

Re: [U-Boot] [PATCH 0/5] Add LVDS support for rk3288.

2016-03-12 Thread Simon Glass
Hi Jacob, On 12 March 2016 at 06:13, Jacob Chen wrote: > From: jacob > > This series patches add LVDS support for rk3288. > I'm a newbie in submiting patches. > If there are something wrong, hope to get help. It looks very tidy! > > > > Jacob Chen

Re: [U-Boot] [PATCH 2/5] rockchip: video: Add a display driver for rockchip LVDS

2016-03-12 Thread Simon Glass
Hi Jacob, On 12 March 2016 at 06:13, Jacob Chen wrote: > Some Rockchip SoCs support LVDS output. Add a display driver for this so > that these displays can be used on supported boards. > > Signed-off-by: Jacob Chen > Signed-off-by: jacob

Re: [U-Boot] [PATCH] ls102xa: dm: serial: Disable CONFIG_DM_STDIO for LCD/HDMI display

2016-03-12 Thread Simon Glass
Hi Alison, On 1 March 2016 at 02:06, Alison Wang wrote: > When LCD/HDMI is connected to LS1021ATWR or LS1021AQDS, the console > output should be shown on the monitor. > > If CONFIG_DM_SERIAL and CONFIG_DM_STDIO are both enabled, serial device > is registered and added to

Re: [U-Boot] [PATCH v2 01/12] net: designware: support phy reset device-tree bindings

2016-03-12 Thread Simon Glass
On 29 February 2016 at 19:03, Simon Glass wrote: > On 28 February 2016 at 14:24, Sjoerd Simons > wrote: >> Add support for the snps,reset-gpio, snps,reset-active-low (optional) and >> snps,reset-delays-us device-tree bindings. The combination of

Re: [U-Boot] [PATCH v2 07/12] net: gmac_rk3288: Add RK3288 GMAC driver

2016-03-12 Thread Simon Glass
Hi Sjeord, On 11 March 2016 at 14:56, Sjoerd Simons wrote: > On Mon, 2016-02-29 at 19:03 -0700, Simon Glass wrote: >> Hi Sjoerd, >> >> On 28 February 2016 at 14:25, Sjoerd Simons >> wrote: >> > >> > >> > diff --git

Re: [U-Boot] [PATCH 2/2] Revert "fdt: fix address cell count checking in fdt_translate_address()"

2016-03-12 Thread Simon Glass
On 14 January 2016 at 10:17, Simon Glass wrote: > On 12 January 2016 at 07:40, Przemyslaw Marczak wrote: >> This reverts commit 71105f50fedddfa5b0535d102c3d5078671721ad. >> >> The reverted commit was applied for a temporary to unbreak >> few Exynos

Re: [U-Boot] [PATCH] dm: ns16550: Add support for reg-offset property

2016-03-12 Thread Simon Glass
Hi, On 28 February 2016 at 15:39, Alexander Graf wrote: > > > On 02/25/2016 02:38 PM, Derald D. Woods wrote: >> >> On Thu, Feb 25, 2016 at 09:11:24AM +0100, Michal Simek wrote: >>> >>> On 25.2.2016 05:47, Derald D. Woods wrote: On Wed, Feb 24, 2016 at 12:26:09PM +0100,

Re: [U-Boot] [PATCH] fdt: Try to read #address-cells/size-cells from parent

2016-03-12 Thread Simon Glass
Hi Michal, On 16 February 2016 at 09:10, Michal Simek wrote: > Hi Simon, > > On 16.2.2016 17:00, Simon Glass wrote: >> Hi Michal, >> >> On 15 February 2016 at 02:58, Michal Simek wrote: >>> Hi Simon, >>> >>> On 10.2.2016 13:04, Michal Simek

Re: [U-Boot] [PATCH 1/2] dts:exynos:update pinctrl size-cells and fix child regs

2016-03-12 Thread Simon Glass
On 15 January 2016 at 02:31, Minkyu Kang wrote: > On 15/01/16 02:17, Simon Glass wrote: >> On 12 January 2016 at 07:40, Przemyslaw Marczak >> wrote: >>> This change is required to avoid warnings about invalid >>> size-cells defined in device-tree

Re: [U-Boot] [PATCH v2 32/32] Drop CONFIG_CRAMFS_CMDLINE

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:26, Simon Glass wrote: > This option doesn't do anything. Drop it. > > Signed-off-by: Simon Glass > Suggested-by: Bin Meng > --- > > Changes in v2: None > > cmd/cramfs.c| 5 - >

Re: [U-Boot] [PATCH v2 31/32] part: Rename test_part_xx() and print_part_xx()

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:26, Simon Glass wrote: > Rename these functions so that part_ is at the start. This more clearly > identifies these functions as partition functions. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to

Re: [U-Boot] [PATCH v2 29/32] dm: usb: Clean up USB after each test

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:26, Simon Glass wrote: > The USB subsystem has a few counters that need to be reset since they are > stored in static variables rather than driver-model data. An example is > usb_max_devs. Ultimately we should move this data into the USB uclass. > >

Re: [U-Boot] [PATCH v2 25/32] dm: usb: Convert USB storage to use driver-model for block devs

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Update this code to support CONFIG_BLK. Each USB storage device can have > one or more block devices as children, each one representing a LUN > (logical unit) of the USB device. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH v2 25/32] dm: usb: Convert USB storage to use driver-model for block devs

2016-03-12 Thread Simon Glass
Hi Marek, On 29 February 2016 at 16:04, Marek Vasut wrote: > On 02/29/2016 11:25 PM, Simon Glass wrote: >> Update this code to support CONFIG_BLK. Each USB storage device can have >> one or more block devices as children, each one representing a LUN >> (logical unit) of the USB

Re: [U-Boot] [PATCH v2 24/32] dm: sandbox: Add driver-model block-device support for sandbox

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Update the host driver to support driver model for block devices. A future > commit will remove the old code, but for now it is useful to be able to use > it both with and without CONFIG_BLK. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH v2 21/32] dm: usb: Tidy up storage code ready for driver model conversion

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Adjust a few things so that the addition of driver-models support involved > adding code rather than also changing it. This makes the patches easier to > review. > > Signed-off-by: Simon Glass > --- > >

Re: [U-Boot] [PATCH v2 23/32] dm: sandbox: Prepare block driver for driver-model conversion

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Make a few minor changes to make it easier to add driver-model support. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > drivers/block/sandbox.c | 30 ++ > 1 file

Re: [U-Boot] [PATCH v2 22/32] dm: blk: Add a block-device uclass

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Add a uclass for block devices. These provide block-oriented data access, > supporting reading, writing and erasing of whole blocks. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng

Re: [U-Boot] [PATCH v2 20/32] dm: usb: Avoid exceeding available array size for storage devices

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > The limit on storage devices is USB_MAX_STOR_DEV but we use one extra > element while probing to see if a device is a storage device. Avoid this, > since it causes memory corruption. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH v2 19/32] dm: block: Adjust device calls to go through helpers function

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > To ease conversion to driver model, add helper functions which deal with > calling each block device method. With driver model we can reimplement these > functions with the same arguments. > > Use inline functions to avoid

Re: [U-Boot] [PATCH v2 18/32] dm: block: Rename device number member dev to devnum

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > This is a device number, and we want to use 'dev' to mean a driver model > device. Rename the member. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: > -

Re: [U-Boot] [PATCH v2 17/32] dm: sandbox: Enable cbfs and cramfs

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Enable these two filesystems to provide better build coverage in sandbox. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 16/32] dm: cbfs: Fix handling of invalid type

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > The comment for file_cbfs_type() says that it returns 0 for an invalid type. > The code appears to check for -1, except that it uses an unsigned variable > to store the type. This results in a warning on 64-bit machines. > >

Re: [U-Boot] [PATCH v2 15/32] dm: part: Rename some partition functions

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Rename three partition functions so that they start with part_. This makes > it clear what they relate to. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > board/cm5200/fwupdate.c | 2 +-

Re: [U-Boot] [PATCH v2 14/32] dm: part: Convert partition API use to linker lists

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > We can use linker lists instead of explicitly declaring each function. > This makes the code shorter by avoiding switch() statements and lots of > header file declarations. > > While this does clean up the code it introduces a

Re: [U-Boot] [PATCH v2 13/32] dm: sandbox: Enable all partition types

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > It is useful to have sandbox build as much code as possible to avoid having > to build every board to detect build errors. Also we may add tests for some > more partition types at some point. > > Enable all partition types in

Re: [U-Boot] [PATCH v2 11/32] dm: blk: Rename get_device_and_partition()

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Rename this function to blk_get_device_part_str(). This is a better name > because it makes it clear that the function returns a block device and > parses a string. > > Signed-off-by: Simon Glass >

Re: [U-Boot] [PATCH v2 12/32] dm: part: Add a cast to avoid a compiler warning

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > In part_amiga.c the name is unsigned but bcpl_strcpy() requires a signed > pointer. Add a cast to fix the warning. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > >

Re: [U-Boot] [PATCH v2 07/32] dm: blk: Convert interface type to an enum

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Since these are sequentially numbered it makes sense to use an enum. It > avoids having to maintain the maximum value, and provides a type we can use > if it is useful. > > In fact the maximum value is not used. Rename it to

Re: [U-Boot] [PATCH v2 10/32] dm: blk: Rename get_device() to blk_get_device_by_str()

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > The current name is too generic. The function returns a block device based > on a provided string. Rename it to aid searching and make its purpose > clearer. Also add a few comments. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH v2 09/32] dm: blk: Rename get_dev() to blk_get_dev()

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > The current name is too generic. Add a 'blk_' prefix to aid searching and > make its purpose clearer. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None

Re: [U-Boot] [PATCH v2 08/32] dm: blk: Add comments to a few functions

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > The block interface is not well documented in the code. Pick two important > functions and add comments. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2:

Re: [U-Boot] [PATCH v2 05/32] dm: part: Drop the common.h header

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > We should not include in header files. Each C file should include > it if needed. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 06/32] dm: Add a new header for block devices

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > At present block devices are tied up with partitions. But not all block > devices have partitions within them. They are in fact separate concepts. > > Create a separate blk.h header file for block devices. > > Signed-off-by:

Re: [U-Boot] [PATCH v2 04/32] dm: fdtdec: Correct a sandbox build warning

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Adjust the cast to avoid a warning when stdint.h is used. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > lib/fdtdec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Applied

Re: [U-Boot] [PATCH v2 01/32] dm: Drop the block_dev_desc_t typedef

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Use 'struct' instead of a typdef. Also since 'struct block_dev_desc' is long > and causes 80-column violations, rename it to struct blk_desc. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng

Re: [U-Boot] [PATCH v2 02/32] dm: pci: Break out the common region display code

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Each region is displayed in almost the same way. Break out this common code > into its own function. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Fix use of pci_mem instead of pci_prefetch > -

Re: [U-Boot] [PATCH v2 03/32] dm: part: Correct a sandbox build warning

2016-03-12 Thread Simon Glass
On 29 February 2016 at 15:25, Simon Glass wrote: > Adjust the cast to avoid a warning when stdint.h is used. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > disk/part_efi.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-)

Re: [U-Boot] [PATCH 2/8] patman: Add a missing space in GetMetaDataForList()

2016-03-12 Thread Simon Glass
On 7 March 2016 at 09:43, Joe Hershberger wrote: > On Sun, Mar 6, 2016 at 8:45 PM, Simon Glass wrote: >> Fix this nit to keep the code consistent. >> >> Signed-off-by: Simon Glass > > Reviewed-by: Joe Hershberger

Re: [U-Boot] [PATCH 7/8] buildman: Allow the toolchain architecture to be specified

2016-03-12 Thread Simon Glass
On 7 March 2016 at 09:58, Joe Hershberger wrote: > On Sun, Mar 6, 2016 at 8:45 PM, Simon Glass wrote: >> At present the architecture is deduced from the toolchain filename. Allow it >> to be specified by the caller. >> >> Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 3/8] buildman: patman: Fix -H when installed as a symlink

2016-03-12 Thread Simon Glass
On 7 March 2016 at 09:44, Joe Hershberger wrote: > On Sun, Mar 6, 2016 at 8:45 PM, Simon Glass wrote: >> It is convenient to install symlinks to buildman and patman in the search >> patch, such as /usr/local/bin. But when this is done, the -H option

Re: [U-Boot] [PATCH 6/8] buildman: Allow the toolchain priority to be specified

2016-03-12 Thread Simon Glass
On 7 March 2016 at 09:50, Joe Hershberger wrote: > On Sun, Mar 6, 2016 at 8:45 PM, Simon Glass wrote: >> At present the priority of a toolchain is calculated from its filename based >> on hard-coded rules. Allow it to be specified by the caller. We

Re: [U-Boot] [PATCH 3/3] dm: serial: Remove duplicated carriage return character

2016-03-12 Thread Simon Glass
On 1 March 2016 at 20:37, Bin Meng wrote: > On Wed, Mar 2, 2016 at 11:00 AM, Alison Wang wrote: >> As the handling for carriage return and line feed is done in the common >> DM driver serial-uclass.c, such handling in some serial DM drivers is >>

Re: [U-Boot] [PATCH 4/8] buildman: Fix up a few code inconsistencies in toolchain.py

2016-03-12 Thread Simon Glass
On 7 March 2016 at 09:45, Joe Hershberger wrote: > On Sun, Mar 6, 2016 at 8:45 PM, Simon Glass wrote: >> Normally we use a single quote for strings unless there is a reason not to >> (such as an embedded single quote). Fix a few counter-examples in

Re: [U-Boot] [PATCH 1/8] fdtgrep: Improve error handling with invalid device tree

2016-03-12 Thread Simon Glass
On 7 March 2016 at 11:26, Simon Glass wrote: > Hi Joe, > > On 7 March 2016 at 09:42, Joe Hershberger wrote: >> On Mon, Mar 7, 2016 at 10:37 AM, Masahiro Yamada >> wrote: >>> 2016-03-07 12:31 GMT+09:00 Simon Glass

Re: [U-Boot] [PATCH 1/3] dm: serial-uclass: Move a carriage return before a line feed

2016-03-12 Thread Simon Glass
On 1 March 2016 at 20:36, Bin Meng wrote: > On Wed, Mar 2, 2016 at 11:00 AM, Alison Wang wrote: >> In general, a carriage return needs to execute before a line feed. The >> patch is to change serial DM driver serial-uclass.c based on this rule. >> >>

Re: [U-Boot] [PATCH] dm: core: make simple-bus compatible to simple-mfd

2016-03-12 Thread Simon Glass
On 6 March 2016 at 19:39, Simon Glass wrote: > On 29 February 2016 at 19:51, Masahiro Yamada > wrote: >> >> Simple MFD devices can bind children without special bus configuration. >> Like Linux, let's handle "simple-mfd" in the same way as

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

2016-03-12 Thread Simon Glass
On 8 March 2016 at 16:33, Simon Glass wrote: > On 8 March 2016 at 02:19, Masahiro Yamada > wrote: >> >> The serial output from the debug UART carries on going far to the >> right in the console. >> >> Signed-off-by: Masahiro Yamada

Re: [U-Boot] [PATCH 2/3] serial: Move carriage return before line feed for some serial drivers

2016-03-12 Thread Simon Glass
On 1 March 2016 at 20:36, Bin Meng wrote: > On Wed, Mar 2, 2016 at 11:00 AM, Alison Wang wrote: >> In general, a carriage return needs to execute before a line feed. >> The patch is to change some serial drivers based on this rule, such >> as

Re: [U-Boot] [PATCH 2/2] dm: Use uclass_first_device_err() where it is useful

2016-03-12 Thread Simon Glass
On 11 February 2016 at 13:23, Simon Glass wrote: > Use this new function in places where it simplifies the code. > > Signed-off-by: Simon Glass > --- > > arch/arm/mach-rockchip/rk3288/sdram_rk3288.c | 2 +- > arch/nios2/cpu/cpu.c |

[U-Boot] [PATCH v2 2/3] buildman: Add a way to specific a full toolchain prefix

2016-03-12 Thread Simon Glass
At present buildman allows you to specify the directory containing the toolchain, but not the actual toolchain prefix. If there are multiple toolchains in a single directory, this can be inconvenient. Add a new 'toolchain-prefix' setting to the settings file, which allows the full prefix (or path

Re: [U-Boot] [PATCH 1/2] dm: core: Add uclass_first_device_err() to return a valid device

2016-03-12 Thread Simon Glass
On 22 February 2016 at 23:38, Simon Glass wrote: > Hi Bin, > > On 16 February 2016 at 02:31, Bin Meng wrote: >> Hi Simon, >> >> On Fri, Feb 12, 2016 at 4:23 AM, Simon Glass wrote: >>> A common pattern is to call uclass_first_device() and

Re: [U-Boot] [PATCH 8/8] buildman: Add a way to specific a full toolchain prefix

2016-03-12 Thread Simon Glass
Hi Stephen, On 7 March 2016 at 14:08, Stephen Warren wrote: > On 03/06/2016 07:45 PM, Simon Glass wrote: >> >> At present buildman allows you to specify the directory containing the >> toolchain, but not the actual toolchain prefix. If there are multiple >> toolchains in a

[U-Boot] [PATCH v2 1/3] buildman: Allow branch names which conflict with directories

2016-03-12 Thread Simon Glass
At present if you try to use buildman with the branch 'test' it will complain that it is unsure whether you mean the branch or the directory. This is a feature of the 'git log' command that buildman uses. Fix it by resolving the ambiguity. Signed-off-by: Simon Glass

[U-Boot] [PATCH v2 3/3] buildman: Clarify the use of -V

2016-03-12 Thread Simon Glass
This option outputs to the log file, not to the terminal. Clarify that in the help, and add a mention of it in the README. Signed-off-by: Simon Glass Reported-by: Stephen Warren --- Changes in v2: None tools/buildman/README | 3 ++-

Re: [U-Boot] [RFC PATCH v2 1/4] arm: iproc: add NAND driver

2016-03-12 Thread Steve Rae
On Fri, Mar 11, 2016 at 4:52 PM, Steve Rae wrote: > From: Jiandong Zheng > > Add support for the iproc NAND, and enable on Cygnus and NSP boards. > > Signed-off-by: Jiandong Zheng > Signed-off-by: Steve Rae > ---

[U-Boot] [RFC PATCH v3 4/4] arm: bcm: configure NAND device and environment

2016-03-12 Thread Steve Rae
Configure the NAND device, define partition sizes, and create the environment space for Cygnus and NSP boards. Signed-off-by: Steve Rae --- Changes in v3: None Changes in v2: None arch/arm/include/asm/arch-bcmcygnus/configs.h | 33 +++

[U-Boot] [RFC PATCH v3 3/4] arm: bcm: enable MTD support

2016-03-12 Thread Steve Rae
Enable MTD support on Cygnus and NSP boards. Signed-off-by: Steve Rae --- Changes in v3: None Changes in v2: None arch/arm/include/asm/arch-bcmcygnus/configs.h | 6 ++ arch/arm/include/asm/arch-bcmnsp/configs.h| 6 ++ 2 files changed, 12 insertions(+) diff

[U-Boot] [RFC PATCH v3 2/4] mtd: fix compiler warnings

2016-03-12 Thread Steve Rae
- add missing declaration - update debug output format specifiers Signed-off-by: Steve Rae --- the checkpatch warning: warning: cmd/mtdparts.c,1494: quoted string split across lines is for the existing code; it is not introduced with this change... Changes in v3: None

[U-Boot] [RFC PATCH v3 1/4] arm: iproc: add NAND driver

2016-03-12 Thread Steve Rae
From: Jiandong Zheng Add support for the iproc NAND, and enable on Cygnus and NSP boards. Signed-off-by: Jiandong Zheng Signed-off-by: Steve Rae --- There was a previous attempt to implement this "iproc NAND" (see:

Re: [U-Boot] [PATCH v2 17/18] board: Add Qualcomm Dragonboard 410C support

2016-03-12 Thread Mateusz Kulikowski
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Daniel, Thanks for the hints! On 12.03.2016 00:58, Daniel Glöckner wrote: > On Sun, Feb 07, 2016 at 09:57:37PM +0100, Mateusz Kulikowski wrote: [...] >> +.global _fastboot_header >> +_fastboot_header: >> +b _start >> +add x13, x18,

[U-Boot] Pull request: u-boot-spi/master

2016-03-12 Thread Jagan Teki
Hi Tom, Please take these two fixes for this release. thanks! Jagan. The following changes since commit 76aab9eb8b4618891914e41fa1ea84441f8c53fd: exynos5: common: Enable CONFIG_USB_ETHER_RTL8152 ethernet support (2016-03-11 10:59:51 +0900) are available in the git repository at:

Re: [U-Boot] [PATCH] sf: Correct data types in stm_is_locked_sr()

2016-03-12 Thread Jagan Teki
On 12 March 2016 at 20:07, Jagan Teki wrote: > Hi Marek, > > On 12 March 2016 at 00:29, Marek Vasut wrote: >> On 03/11/2016 07:44 PM, Jagan Teki wrote: >>> On 12 March 2016 at 00:03, Marek Vasut wrote: On 03/11/2016 07:07 PM, Jagan

Re: [U-Boot] [PATCH] sf: Correct data types in stm_is_locked_sr()

2016-03-12 Thread Jagan Teki
Hi Marek, On 12 March 2016 at 00:29, Marek Vasut wrote: > On 03/11/2016 07:44 PM, Jagan Teki wrote: >> On 12 March 2016 at 00:03, Marek Vasut wrote: >>> On 03/11/2016 07:07 PM, Jagan Teki wrote: On 11 March 2016 at 23:32, Marek Vasut wrote:

Re: [U-Boot] [PATCH] sf: Correct data types in stm_is_locked_sr()

2016-03-12 Thread Jagan Teki
Hi Albert, On 12 March 2016 at 01:04, Albert ARIBAUD wrote: > Hello Jagan, > > On Sat, 12 Mar 2016 00:41:25 +0530, Jagan Teki > wrote: >> Hi Albert, >> >> On 12 March 2016 at 00:17, Albert ARIBAUD wrote: >> > Hello

Re: [U-Boot] [PATCH v2] ti_armv7_common: env: Add NFS loading support to default enviroment

2016-03-12 Thread Lokesh Vutla
On Saturday 12 March 2016 02:34 AM, Andrew F. Davis wrote: > NFS loading is similar to net loading except initial files are loaded > over NFS instead of TFTP, this removes the need for multiple different > protocol servers running on the host and allows the use of a single > network file system