Re: [U-Boot] [PATCH] LS2081ARDB: Enable CONFIG_SPI_FLASH_BAR option

2017-05-14 Thread Suresh Gupta
> -Original Message- > From: York Sun [mailto:york@nxp.com] > Sent: Friday, May 12, 2017 11:51 PM > To: Yogesh Narayan Gaur ; Suresh Gupta > > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH] LS2081ARDB: Enable CONFIG_SPI_FLASH_BAR option > > On 05/11/2017 01:36 AM, Yogesh Gaur wrote

Re: [U-Boot] [PATCH] sf: Fix s25fs512s erase size and remove SECT_4K flag

2017-05-14 Thread Suresh Gupta
> -Original Message- > From: York Sun [mailto:york@nxp.com] > Sent: Friday, May 12, 2017 11:23 PM > To: Suresh Gupta ; Jagan Teki > > Cc: u-boot@lists.denx.de; Jagan Teki ; Yao Yuan > > Subject: Re: [U-Boot] [PATCH] sf: Fix s25fs512s erase size and remove SECT_4K > flag > > On 04/2

[U-Boot] [PATCH 32/33] dts: rk3399: change the maximum eMMC clock frequency to 150MHz

2017-05-14 Thread Ziyuan Xu
The rockchip mmc controllers don't support _the _odd__ divider, otherwise probably cause unpredictable error. The driver originally select gpll(594M) as the clock source, and we set div to 3 at 200MHz. We have to change the maximum eMMC clock frequency to 150MHz in U-Boot stage, so that the div wi

Re: [U-Boot] [linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-14 Thread Maxime Ripard
On Sat, May 13, 2017 at 11:14:00PM +0800, Chen-Yu Tsai wrote: > >>> +static int sunxi_tve_get_plug_in_status(void) > >>> +{ > >>> + struct sunxi_tve_reg * const tve = > >>> + (struct sunxi_tve_reg *)SUNXI_TVE0_BASE; > >>> + u32 status; > >>> + > >>> + status = readl(

[U-Boot] [PATCH 19/33] mmc: dw_mmc: rockchip: implement tuning with clock phase framework

2017-05-14 Thread Ziyuan Xu
This algorithm will try 1 degree increment, since there's no way to tell what resolution the underlying phase code uses. As an added bonus, doing many tunings yields better results since some tests are run more than once (ex: if the underlying driver use 45 degree increments, the tuning code will t

Re: [U-Boot] [GIT PULL] Please pull u-boot-mmc master

2017-05-14 Thread Jaehoon Chung
Dear Tom, On 05/15/2017 02:06 PM, Jaehoon Chung wrote: > Dear Tom, > > Could you pull these patches into u-boot/master? > If there are problems, let me knows. Discard this PR..When i checked some patches, there are problem..So i will resend the PR. Best Regards, Jaehoon Chung > > > The fol

[U-Boot] [PATCH 25/33] mmc: sdhci: update host->clock after clock setting

2017-05-14 Thread Ziyuan Xu
Overwrite host->clock after clock setting to avoid repetitive reset clock. Signed-off-by: Ziyuan Xu --- drivers/mmc/sdhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 48bac04..ad86278 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/

[U-Boot] [PATCH 24/33] mmc: sdhci: rockchip: fix bus width setting

2017-05-14 Thread Ziyuan Xu
Rockchip sdhci controller capable of 8-bit transfer. The original can only run at 4 bit mode. Signed-off-by: Ziyuan Xu --- drivers/mmc/rockchip_sdhci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index bdde831.

[U-Boot] [PATCH 22/33] mmc: dw_mmc: rockchip: fix data crc error on ddr52 8bit mode

2017-05-14 Thread Ziyuan Xu
The clk_divider must be set to 1 on ddr52 8bit mode for rockchip platform. Otherwise we will get a data crc error during data transmission. Signed-off-by: Ziyuan Xu --- drivers/mmc/dw_mmc.c | 2 +- drivers/mmc/rockchip_dw_mmc.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(

[U-Boot] [PATCH 23/33] mmc: dw_mmc: fix bus width setting

2017-05-14 Thread Ziyuan Xu
Hosts capable of 8-bit transfers can also do 4 bits. Signed-off-by: Ziyuan Xu --- drivers/mmc/dw_mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index dcd7fba..3b89e7a 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_

[U-Boot] [PATCH 06/33] mmc: add card_busy to query card status

2017-05-14 Thread Ziyuan Xu
Card devices get into busy status since host request speed mode switch, if host controller is able to query whether the device is busy, try it instead of sending cmd13. Signed-off-by: Ziyuan Xu --- drivers/mmc/mmc-uclass.c | 16 drivers/mmc/mmc.c| 13 + incl

Re: [U-Boot] [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-14 Thread Maxime Ripard
On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote: > Hi, > > On 12 May 2017 at 10:06, Maxime Ripard > wrote: > > Hi Jernej, > > > > The patch content looks fine, but there's a few things that would need > > to be addressed. > > > > On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrab

[U-Boot] [PATCH 33/33] SPL: tiny-printf: add "X" modifier

2017-05-14 Thread Ziyuan Xu
tiny-printf does not know about the "X" modifier so far, which print all zero. The mmc driver use '0x%08X' to print command argument and response. Signed-off-by: Ziyuan Xu --- lib/tiny-printf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c index 0b048

[U-Boot] [PATCH 01/33] mmc: select the available type from host_caps and card_caps

2017-05-14 Thread Ziyuan Xu
The original implementation select HS timing by default, add available type selection for higher speed mode compatibility, such as hs200, hs400, hs400es. By the way, we assume that card run at 1.8V or 1.2V I/O when its timing is ddr52/hs200/hs400(es). Signed-off-by: Ziyuan Xu --- drivers/mmc/m

[U-Boot] [PATCH 26/33] mmc: sdhci: add support for UHS timing

2017-05-14 Thread Ziyuan Xu
To support UHS speed mode, controller should enable 1.8V signaling and select one of UHS modes. Signed-off-by: Ziyuan Xu --- drivers/mmc/sdhci.c | 40 include/mmc.h | 1 + include/sdhci.h | 17 + 3 files changed, 58 insertions(

[U-Boot] [PATCH 10/33] mmc: add support for HS200 mode of eMMC4.5

2017-05-14 Thread Ziyuan Xu
Add the support of the HS200 mode for eMMC 4.5 devices. The eMMC 4.5 device has support up to 200MHz bus speed, it can speed up the boot speed. We can enable this feature via MMC_MODE_HS200 if the host controller has the ability to support HS200 timing. Also the tuning feature required when the HS

[U-Boot] [PATCH 11/33] mmc: rework ddr mode judgement with timing

2017-05-14 Thread Ziyuan Xu
Since the card device is set the proper timing after speed mode switch is completed, host driver can get ddr_mode from timing parameter. So drop the antiquated ddr_mode. Signed-off-by: Ziyuan Xu --- cmd/mmc.c | 2 +- drivers/mmc/dw_mmc.c | 2 +- drivers/mmc/fsl_esdhc.c |

[U-Boot] [PATCH 15/33] rockchip: clk: rk3288: fix mmc clock setting

2017-05-14 Thread Ziyuan Xu
Mmc clock automatically divide 2 in internal. Before this: gpll = 594MHz, clock = 148.5MHz div = 594/148.5-1 = 3 output clock is 99MHz After this: gpll = 594MHz, clock = 148.5MHz div = 297+148.5-1/148.5 = 2 output clock is 148.5Mhz Signed-off-by: Ziyuan Xu --- drivers/clk/rockchip/clk_rk3288.

[U-Boot] [PATCH 31/33] mmc: add support for HS400 mode of eMMC5.0

2017-05-14 Thread Ziyuan Xu
This patch adds HS400 mode support for eMMC5.0 device. HS400 mode is high speed DDR interface timing from HS200. Clock frequency is up to 200MHz and only 8-bit bus width is supported. In addition, tuning process of HS200 is required to synchronize the command response on the CMD line because CMD in

[U-Boot] [PATCH 29/33] mmc: sdhci: rockchip: add phy support

2017-05-14 Thread Ziyuan Xu
This patch gets phy phandle from dt-binding, and power cycle/re-configure phy whilst changing card clock. Signed-off-by: Ziyuan Xu --- drivers/mmc/rockchip_sdhci.c | 147 +++ 1 file changed, 147 insertions(+) diff --git a/drivers/mmc/rockchip_sdhci.c b/d

[U-Boot] [PATCH 16/33] rockchip: clk: rk3288: add support for the clock phase

2017-05-14 Thread Ziyuan Xu
This patch adds phase adjustment for mmc clock(ciu_sample), which is used to select the optimal sampling point of a data input. The phase shift is achieved through 255 delay elements(40-80 picoseconds), and calculate the number of delay element via clock frequency. Signed-off-by: Ziyuan Xu ---

[U-Boot] [PATCH 21/33] mmc: add DDR52 support for eMMC card

2017-05-14 Thread Ziyuan Xu
4.41+ eMMC card devices can run at 52MHz on DDR 8-bit mode, it can improve write/read performance. Host driver can set MMC_MODE_DDR_52Mhz to enable this feature. Signed-off-by: Ziyuan Xu --- drivers/mmc/mmc.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff

[U-Boot] [PATCH 27/33] mmc: sdhci: rename set_clock callback

2017-05-14 Thread Ziyuan Xu
In fact, the original name is unsuitable for its behavior. It's better to rename to set_clock_ext. Signed-off-by: Ziyuan Xu --- drivers/mmc/s5p_sdhci.c | 4 ++-- drivers/mmc/sdhci.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mm

[U-Boot] [PATCH 14/33] clk: introduce clk_phase get/set function & callback

2017-05-14 Thread Ziyuan Xu
A common operation for a clock signal generator is to shift the phase of that signal. This patch introduces a new function to the clk.h API to dynamically adjust the phase of a clock signal. Additionally this patch introduces support for the new function in the clock framework via the .set_phase &

[U-Boot] [PATCH 28/33] mmc: sdhci: export sdhci_set_clock()

2017-05-14 Thread Ziyuan Xu
For arasan-rk3399-sdhci controller, we should make sure the phy is in poweroff status before we configure the clock stuff. So that we need to export it for phy configuration. Signed-off-by: Ziyuan Xu --- drivers/mmc/sdhci.c | 16 +++- include/sdhci.h | 5 - 2 files changed,

[U-Boot] [PATCH 30/33] mmc: sdhci: add the support for tuning

2017-05-14 Thread Ziyuan Xu
MMC framework has already implemented hs200 mode for eMMC devices, moreover the standard SDHC3.0 controller support tuning. We can set the corresponding flag in host->host_cpas. Host driver issue tuning command repeatedly until the host controller resets Execute Tuning to 0. Host controller resets

[U-Boot] [PATCH 20/33] mmc: dw_mmc: reset controller after data error

2017-05-14 Thread Ziyuan Xu
Per dw_mmc databook, it's recommend that reset the host contoller if some data-related error occurre during tuning progress. Signed-off-by: Ziyuan Xu --- drivers/mmc/dw_mmc.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/m

[U-Boot] [PATCH 17/33] rockchip: clk: rk3399: fix emmc clock setting

2017-05-14 Thread Ziyuan Xu
Before this: gpll = 594MHz, set_clock = 200MHz div = 594/200 = 2 real clock is 297MHz After this: gpll = 594MHz, clock = 148.5MHz div = 594+200-1/200 = 3 real clock is 198Mhz Signed-off-by: Ziyuan Xu --- drivers/clk/rockchip/clk_rk3399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[U-Boot] [PATCH 02/33] mmc: add set_timing entry for timing selection

2017-05-14 Thread Ziyuan Xu
Some controller should do some configuration according to the selected timing. Signed-off-by: Ziyuan Xu --- drivers/mmc/mmc.c | 7 +++ include/mmc.h | 49 + 2 files changed, 56 insertions(+) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/m

[U-Boot] [PATCH 12/33] mmc: remove tran_speed from struct mmc

2017-05-14 Thread Ziyuan Xu
The clock element is updated by mmc_set_clock every time, it denotes the current transfer speed. Signed-off-by: Ziyuan Xu --- cmd/mmc.c | 2 +- drivers/mmc/mmc.c | 10 +- drivers/mmc/xenon_sdhci.c | 2 +- include/mmc.h | 1 - 4 files changed, 7 ins

[U-Boot] [PATCH 18/33] mmc: dw_mmc: add the support for the tuning scheme

2017-05-14 Thread Ziyuan Xu
For the HS200/HS400/SDR104, tuning is needed to determine the optimal sampling point. Actual tuning procedure is provided by specific host controller driver. Signed-off-by: Ziyuan Xu --- drivers/mmc/dw_mmc.c | 18 ++ include/dwmmc.h | 1 + 2 files changed, 19 insertions(+)

[U-Boot] [PATCH 07/33] mmc: dw_mmc: implement card_busy detection

2017-05-14 Thread Ziyuan Xu
Signed-off-by: Ziyuan Xu --- drivers/mmc/dw_mmc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 700f764..baf2280 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -384,6 +384,26 @@ static int dwmci_setu

[U-Boot] [PATCH 04/33] mmc: rework high speed mode selection

2017-05-14 Thread Ziyuan Xu
Select timing parameter for the host since HS mode switch is completed. Signed-off-by: Ziyuan Xu --- drivers/mmc/mmc.c | 16 ++-- include/mmc.h | 6 ++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 1b3652a..0b301

[U-Boot] [PATCH 13/33] cmd: mmc: show the current speed mode

2017-05-14 Thread Ziyuan Xu
So far mmc framework had support speed mode switch, it good to show the current speed mode from 'mmc info'. Signed-off-by: Ziyuan Xu --- cmd/mmc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cmd/mmc.c b/cmd/mmc.c index 6ead27a..832eeb0 100644 --- a/cmd/mmc.c +++ b/cmd/mmc.c @@ -15,

[U-Boot] [PATCH 09/33] mmc: rework mmc_switch for non-send_status scenario

2017-05-14 Thread Ziyuan Xu
Per JEDEC spec, it is not recommended to use cmd13 to get card status after speed mode switch. CMD13 can't be guaranteed due to the asynchronous operation. Besieds, if the host controller supports busy detection in HW, we use it instead of cmd13. Signed-off-by: Ziyuan Xu --- drivers/mmc/mmc.c

[U-Boot] [PATCH 03/33] mmc: xenon_sdhci: drop redundant timing definitions

2017-05-14 Thread Ziyuan Xu
Remove the redundant mmc timing definitions which have defined in mmc.h. Signed-off-by: Ziyuan Xu --- drivers/mmc/xenon_sdhci.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/mmc/xenon_sdhci.c b/drivers/mmc/xenon_sdhci.c index 2a0d8b4..f0a33c1 100644 --- a/drivers/mmc/

[U-Boot] [PATCH 08/33] mmc: sdhci: implement card_busy detection

2017-05-14 Thread Ziyuan Xu
Signed-off-by: Ziyuan Xu --- drivers/mmc/sdhci.c | 19 +++ include/sdhci.h | 1 + 2 files changed, 20 insertions(+) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 58cc0ab..48bac04 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -424,6 +424,23 @@

[U-Boot] [PATCH 05/33] mmc: sdhci: fix HISPD bit setting

2017-05-14 Thread Ziyuan Xu
Configure HISPD bit field according to the timing parameter instead of the card clock frequency. Signed-off-by: Ziyuan Xu --- drivers/mmc/sdhci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index b745977..58cc0ab 100644 ---

[U-Boot] [PATCH 05/33] mmc: sdhci: fix HISPD bit setting

2017-05-14 Thread Ziyuan Xu
Configure HISPD bit field according to the timing parameter instead of the card clock frequency. Signed-off-by: Ziyuan Xu --- drivers/mmc/sdhci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index b745977..58cc0ab 100644 ---

[U-Boot] [PATCH 02/33] mmc: add set_timing entry for timing selection

2017-05-14 Thread Ziyuan Xu
Some controller should do some configuration according to the selected timing. Signed-off-by: Ziyuan Xu --- drivers/mmc/mmc.c | 7 +++ include/mmc.h | 49 + 2 files changed, 56 insertions(+) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/m

[U-Boot] [PATCH 04/33] mmc: rework high speed mode selection

2017-05-14 Thread Ziyuan Xu
Select timing parameter for the host since HS mode switch is completed. Signed-off-by: Ziyuan Xu --- drivers/mmc/mmc.c | 16 ++-- include/mmc.h | 6 ++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 1b3652a..0b301

[U-Boot] [PATCH 03/33] mmc: xenon_sdhci: drop redundant timing definitions

2017-05-14 Thread Ziyuan Xu
Remove the redundant mmc timing definitions which have defined in mmc.h. Signed-off-by: Ziyuan Xu --- drivers/mmc/xenon_sdhci.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/mmc/xenon_sdhci.c b/drivers/mmc/xenon_sdhci.c index 2a0d8b4..f0a33c1 100644 --- a/drivers/mmc/

[U-Boot] [PATCH 01/33] mmc: select the available type from host_caps and card_caps

2017-05-14 Thread Ziyuan Xu
The original implementation select HS timing by default, add available type selection for higher speed mode compatibility, such as hs200, hs400, hs400es. By the way, we assume that card run at 1.8V or 1.2V I/O when its timing is ddr52/hs200/hs400(es). Signed-off-by: Ziyuan Xu --- drivers/mmc/m

[U-Boot] [PATCH] ARM: dts: uniphier: sync DT with Linux

2017-05-14 Thread Masahiro Yamada
Fix the following DTC warnings: Warning (simple_bus_reg): Node /soc/system-bus@58c0/support_card@1,1f0/ethernet@ simple-bus unit address format error, expected "0" Warning (simple_bus_reg): Node /soc/system-bus@58c0/support_card@1,1f0/uart@000b simple-bus unit addres

[U-Boot] [GIT PULL] Please pull u-boot-mmc master

2017-05-14 Thread Jaehoon Chung
Dear Tom, Could you pull these patches into u-boot/master? If there are problems, let me knows. The following changes since commit 22f3368e71321db1e0e15dfbf54b052367890ec7: Merge branch 'master' of git://git.denx.de/u-boot-mips (2017-05-13 16:45:35 -0400) are available in the git repository

Re: [U-Boot] [PATCH v2] mmc: sdhci-cadence: import updates from Linux 4.12

2017-05-14 Thread Jaehoon Chung
On 05/09/2017 03:52 PM, Masahiro Yamada wrote: > This driver is a counterpart of drivers/mmc/host/sdhci-cadence.c > from Linux. Some updates for v4.12-rc1 can be imported to U-Boot. > > - Fix value of SDHCI_CDNS_HRS04_RDATA_SHIFT > - Add polling for ACK bit to be sure that data are written to >

Re: [U-Boot] [PATCH 2/2][v5] armv8: ls2080aqds: Add support for SD boot

2017-05-14 Thread Santan Kumar
> -Original Message- > From: York Sun [mailto:york@nxp.com] > Sent: Friday, May 12, 2017 9:31 PM > To: Santan Kumar ; u-boot@lists.denx.de > Cc: Priyanka Jain ; Abhimanyu Saini > > Subject: Re: [PATCH 2/2][v5] armv8: ls2080aqds: Add support for SD boot > > On 05/05/2017 03:10 AM, Sa

Re: [U-Boot] [PATCH v3 11/12] Drop CONFIG_I2CFAST

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: This option is not used in U-Boot. Drop it. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None README | 6 -- common/board_r.c | 17 - scripts/config_whitel

Re: [U-Boot] [PATCH v3 10/12] i2c: Drop CONFIG_SYS_I2C_BOARD_LATE_INIT

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: This option is not used by any boards. Drop it. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None README | 11 --- drivers/i2c/fsl_i2c.c| 9 - drivers/i2c/fti2c010

Re: [U-Boot] [PATCH v3 09/12] i2c: README: Drop CONFIG_SYS_I2C_INIT_MPC5XXX

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: This option is not used in U-Boot. Drop it. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None README | 2 -- 1 file changed, 2 deletions(-) Thanks! Applied to u-boot-i2c.git master u-boot-i2c master just tes

Re: [U-Boot] [PATCH v3 06/12] i2c: mxc_i2c: Drop use of CONFIG_I2C_HARD

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: Drop use of this long-deprecated option. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/i2c/mxc_i2c.c | 4 1 file changed, 4 deletions(-) Thanks! Applied to u-boot-i2c.git master u-boot-i2c m

Re: [U-Boot] [PATCH v3 07/12] i2c: omap: Modify code to work without CONFIG_I2C_HARD

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: Drop use of this long-deprecated option. Signed-off-by: Simon Glass Suggested-by: Lokesh Vutla --- Changes in v3: None Changes in v2: - Add new patch to adjust omap boards to not need CONFIG_I2C_HARD board/ti/am335x/board.c | 3 ++-

Re: [U-Boot] [PATCH v3 12/12] Drop use of CONFIG_I2C_SOFT

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:10 schrieb Simon Glass: This option is not used in U-Boot. Drop it. Signed-off-by: Simon Glass --- Changes in v3: - Rebase to master Changes in v2: - Rebase to master README | 32 +--- 1 file changed, 1 insertion(+), 31 deletio

Re: [U-Boot] [PATCH v3 05/12] i2c: keymile: Drop use of CONFIG_I2C_HARD

2017-05-14 Thread Heiko Schocher
Hello simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: Drop use of this long-deprecated option. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None board/keymile/km82xx/km82xx.c | 5 - board/keymile/km_arm/km_arm.c | 4 2 files changed, 9 deletions(-) Than

Re: [U-Boot] [PATCH v3 08/12] i2c: Finish dropping use of CONFIG_I2C_HARD

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: Drop use of this long-deprecated option. Signed-off-by: Simon Glass --- Changes in v3: - Update commit message so that it is unique in the series - Fix up #ifdef in cmd/eeprom.c - Drop changes to include/config headers Changes in v2: -

Re: [U-Boot] [PATCH v3 03/12] i2c: cm5200: Drop use of CONFIG_I2C_HARD

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: Drop use of this long-deprecated option. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None board/cm5200/cm5200.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Thanks! Applied to u-boot-i2c.git m

Re: [U-Boot] [PATCH v3 04/12] i2c: pdm360ng: Drop use of CONFIG_I2C_HARD

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: Drop use of this long-deprecated option. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None board/pdm360ng/pdm360ng.c | 30 -- 1 file changed, 30 deletions(-) Thanks! Applied to u-b

Re: [U-Boot] [PATCH v3 02/12] i2c: powerpc: Remove use of CONFIG_HARD_I2C

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: Drop use of this long-deprecated option for powerpc. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None arch/powerpc/cpu/mpc512x/Makefile | 1 - arch/powerpc/cpu/mpc512x/i2c.c | 386 ---

Re: [U-Boot] [PATCH v3 01/12] i2c: Drop use of CONFIG_I2C_HARD

2017-05-14 Thread Heiko Schocher
Hello Simon, Am 13.05.2017 um 05:09 schrieb Simon Glass: This option is pretty old. It predates CONFIG_SYS_I2C which is itself deprecated in favour of driver model. Disable it for all boards. Also drop I2C options which depend on this. Signed-off-by: Simon Glass --- Thanks! Applied to u-bo

[U-Boot] [USB]USB2.0 device timeout issue.

2017-05-14 Thread Terry Zhou
+ Nadav Haklai. Best Regards, Terry From: Terry Zhou Sent: 2017年5月11日 9:02 To: 'u-boot@lists.denx.de' ; 'ma...@denx.de' Cc: 'Stefan Roese' ; 'Simon Glass' ; 'ma...@denx.de' Subject: [U-boot][USB]]USB2.0 device timeout issue. + Marek Vasut Best Regards, Terry From: Terry Zhou Sent: 2017年5月1

Re: [U-Boot] [PATCH 02/17] omap24xx_i2c.c: Drop references to CONFIG_OMAP243X

2017-05-14 Thread Heiko Schocher
Hello Tom, Am 13.05.2017 um 04:33 schrieb Tom Rini: We have nothing defining CONFIG_OMAP243X since we dropped the omap243x platforms, drop these tests. Signed-off-by: Tom Rini --- drivers/i2c/omap24xx_i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) as you have delegated

Re: [U-Boot] [PATCH 18/22] mmc: add HS200 support in MMC core

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > Add HS200 to the list of supported modes and introduce tuning in the MMC > startup process. > > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c | 22 -- > include/mmc.h

Re: [U-Boot] [PATCH 10/22] mmc: refactor MMC startup to make it easier to support new modes

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > The MMC startup process currently handles 4 modes. To make it easier to > add support for more modes, let's make the process more generic and use a > list of the modes to try. > The major functional change is that when a mode fails we try the n

Re: [U-Boot] [PATCH 05/22] mmc: introduces mmc modes.

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: Subject: drop the period at the end Also I think 'mmc: Introduce MMC modes' is better (imperative tense) > no functionnal changes. > In order to add the support for the high speed SD and MMC modes, it is > useful to track this information. > >

Re: [U-Boot] [PATCH 14/22] mmc: add power cyle support in mmc core

2017-05-14 Thread Simon Glass
Hi, On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > mmc/sd specification requires vdd to be disabled for 1 ms > and then enabled again during power cycle. Add a > function in mmc core to perform power cycle and set > the io signal to it's initial state. > > Signed-off-by: Kishon Vijay Abrah

Re: [U-Boot] [PATCH 15/22] mmc: add a new mmc parameter to disable mmc clock

2017-05-14 Thread Simon Glass
Hi, On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > mmc clock has to be disabled in certain cases like during > the voltage switch sequence. Modify mmc_set_clock function > to take disable as an argument that signifies if the > clock has to be enabled or disabled. > > Signed-off-by: Kishon

Re: [U-Boot] [PATCH 11/22] mmc: make mmc_set_ios() return status

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > set_ios callback has a return value of 'int' but the mmc_set_ios() > function ignore this. Modify mmc_set_ios() and the callers of mmc_set_ios() to > to return the error status. > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c

Re: [U-Boot] [PATCH 20/22] mmc: Add support for UHS modes

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > Add UHS modes to the list of supported modes, get the UHS capabilites of > the SDcard and implement the procedure to switch the voltage (UHS modes > use 1v8 IO lines) > During the voltage switch procedure, DAT0 is used by the card to signal > w

Re: [U-Boot] [PATCH 13/22] mmc: Add a new callback function to enable/disable vdd

2017-05-14 Thread Simon Glass
Hi, On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > From: Kishon Vijay Abraham I > > Add a new callback function *set_vdd* which can be used > by the platform mmc driver to enable or disable vdd. > The mmc core can use *mmc_set_vdd* in order to invoke > the callback function. This will be

Re: [U-Boot] [PATCH 19/22] mmc: Add a new callback function to check if the card is busy

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > Add a new callback function *card_busy* which can be used to check if the > card is busy. This is useful during UHS voltage switching to check if the > switch was successful. Not all controllers may support this, so it's > optional and when not

Re: [U-Boot] [PATCH 06/22] mmc: Add a fonction to dump the mmc capabilities

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > This adds a simple helper function to display information (bus width and > mode) based on a capability mask. Useful for debug. > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c | 17 + > include/mmc.h | 1 +

Re: [U-Boot] [PATCH 16/22] mmc: disable the mmc clock during power off

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > From: Kishon Vijay Abraham I > > There is no point in having the mmc clock enabled during > power off. Disable the mmc clock. This is similar to how it's > programmed in Linux Kernel. > > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by:

Re: [U-Boot] [PATCH 03/22] mmc: make ext_csd part of struct mmc

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > The ext csd is used for comparison many times. Keep a reference content > of the ext csd in the struct mmc to avoid reading multiple times > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c | 22 +- > include

Re: [U-Boot] [PATCH 22/22] mmc: Retry some MMC cmds on failure

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > From: Vignesh R > > With certain SD cards like Kingston 8GB/16GB UHS card, it is seen that > MMC_CMD_ALL_SEND_CID cmd fails on first attempt, but succeeds > subsequently. Therefore, retry MMC_CMD_ALL_SEND_CID cmd at least thrice > as done in L

Re: [U-Boot] [PATCH 08/22] cmd: mmc: display the mode name and current bus speed in the mmc info

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > Display the mode name when the user execute 'mmc info'. Also instead of > displaying tran_speed, display the actual bus speed. > > Signed-off-by: Jean-Jacques Hiblot > --- > cmd/mmc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [U-Boot] [PATCH 17/22] mmc: Add a execute_tuning() callback to the mmc operations.

2017-05-14 Thread Simon Glass
Hi, On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > Tuning is a mandatory step in the initialization of SDR104 and HS200 modes. > This callback execute the tuning process. > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc-uclass.c | 14 ++ > drivers/mmc/mmc.c

Re: [U-Boot] [PATCH 12/22] mmc: Enable signal voltage to be selected from mmc core

2017-05-14 Thread Simon Glass
Hi Jen-Jacques, On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > From: Kishon Vijay Abraham I > > Add a new function *mmc_set_signal_voltage* in mmc core > which can be used during mmc initialization to select the > signal voltage. Platform driver should use the set_ios > callback function

Re: [U-Boot] [PATCH 07/22] mmc: use mmc modes to select the correct bus speed

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: Please add commit message which what is happening and motivation. > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c | 40 +--- > 1 file changed, 29 insertions(+), 11 deletions(-) Reviewed-by:

Re: [U-Boot] [PATCH v2 5/5] usb: host: extend generic OHCI with CLOCK, RESET and PHY

2017-05-14 Thread Simon Glass
On 12 May 2017 at 11:27, wrote: > From: Patrice Chotard > > Add CLOCK, RESET and generic PHY frameworks support > > Signed-off-by: Patrice Chotard > --- > > v2: _ add error path management > _ add .remove callback > > drivers/usb/host/ohci-generic.c | 99 >

Re: [U-Boot] [PATCH 04/22] mmc: add a function to read and test the ext csd (mmc >= 4)

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > This will be reused later in the selection of high speed and ddr modes. > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c | 49 + > 1 file changed, 29 insertions(+), 20 deletions(

Re: [U-Boot] [PATCH 09/22] mmc: refactor SD startup to make it easier to support new modes

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > The SDcard startup process currently handles only 2 modes. To make it > easier to add support for more modes, let's make the process more generic > and use a list of the modes to try. > The major functional change is that when a mode fails we t

Re: [U-Boot] [PATCH 21/22] mmc: Change mode when switching to a boot partition

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > Boot partitions do not support HS200. Changing to a lower performance mode > is required to access them. > mmc_select_mode_and_width() and sd_select_mode_and_width() are modified to > make it easier to call them outside of the initialization co

Re: [U-Boot] [PATCH 01/22] mmc: split mmc_startup()

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > No functionnal change here. The function is really big and can be split. > The part related to bus configuration are put in 2 separate functions: one > for MMC and one for SD. > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c |

Re: [U-Boot] [PATCH 02/22] mmc: move the MMC startup for version above v4.0 in a separate function

2017-05-14 Thread Simon Glass
On 12 May 2017 at 12:16, Jean-Jacques Hiblot wrote: > no functionnal change. This is only to further reduce the size o > mmc_startup(). > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/mmc/mmc.c | 316 > -- > 1 file changed, 165 insertio

Re: [U-Boot] [PATCH v2 4/5] usb: host: replace printf() by error() in ehci-generic

2017-05-14 Thread Simon Glass
On 12 May 2017 at 14:51, Marek Vasut wrote: > On 05/12/2017 07:27 PM, patrice.chot...@st.com wrote: >> From: Patrice Chotard > > Commit message does not explain WHY this change is needed. In fact ... > commit message is missing altogether ... Yes it really helps to have a commit message! > >> S

Re: [U-Boot] [PATCH v2] mmc: atmel_sdhci: Enable the quirk SDHCI_QUIRK_WAIT_SEND_CMD

2017-05-14 Thread Simon Glass
On 10 May 2017 at 18:25, Wenyou Yang wrote: > To fix the timeout of sending the write command, enable the quirk > SDHCI_QUIRK_WAIT_SEND_CMD. > > Signed-off-by: Wenyou Yang > --- > > Changes in v2: > - Add missed this quirk in atmel_sdhci_init(). > > drivers/mmc/atmel_sdhci.c | 4 ++-- > 1 file

Re: [U-Boot] [PATCH v5 13/14] ARM: DTS: STiH410: rework ohci nodes

2017-05-14 Thread Simon Glass
On 10 May 2017 at 10:09, wrote: > From: Patrice Chotard > > Update the compatible string in order to use ehci-generic > driver instead of a STi specific one > > Signed-off-by: Patrice Chotard > --- > > v5: _ update compatible to fit with ohci-generic driver > > arch/arm/dts/stih410.dtsi | 4

Re: [U-Boot] [PATCH 4/5] tools: add secure_boot_helper.py

2017-05-14 Thread Simon Glass
Hi, On 11 May 2017 at 09:14, Anatolij Gustschin wrote: > From: Markus Valentin > > This script should be used for simple creation of secure bootable > images for baytrail platforms > > Signed-off-by: Markus Valentin > --- > tools/secure_boot_helper.py | 313 > +

Re: [U-Boot] [PATCH 1/5] x86: congatec: add secureboot enabled defconfig for conga-qeval20-qa3-e3845

2017-05-14 Thread Simon Glass
On 11 May 2017 at 09:14, Anatolij Gustschin wrote: > From: Markus Valentin > > Signed-off-by: Markus Valentin > [agust: rebased, fixed to build with v2017.05] > Signed-off-by: Anatolij Gustschin > --- > ...0-qa3-e3845-internal-uart-secure-boot_defconfig | 77 > ++ > 1 file

Re: [U-Boot] [PATCH v5 11/14] ARM: DTS: STiH410: rework ehci nodes

2017-05-14 Thread Simon Glass
On 10 May 2017 at 10:09, wrote: > From: Patrice Chotard > > Update the compatible string in order to use ehci-generic > driver instead of a STi specific one > > Reverse the order of resets, due to the fact that softreset > must be deasserted first. > > Signed-off-by: Patrice Chotard > --- > > v

Re: [U-Boot] [PATCH] sandbox: Fix comparison of unsigned enum expression warning

2017-05-14 Thread Simon Glass
On 13 May 2017 at 18:11, Tom Rini wrote: > In os_dirent_get_typename() we are checking that type falls within the > known values of the enum os_dirent_t. With clang-3.8 testing this value > as being >= 0 results in a warning as it will always be true. This > assumes of course that we are only gi

Re: [U-Boot] [PATCH] rockchip: rk3036: clock: code clean

2017-05-14 Thread Simon Glass
Hi Kever, On 9 May 2017 at 06:11, Kever Yang wrote: > Embeded the shift in mask MACRO, and a few fix btw: > - hclk/pclk_div range use '<=' instead of '<' > - use GPLL for pd_bus > - peri HCLK/PCLK clock rate should not bigger than ACLK Can you please split out a patch that changes the shift/mask

Re: [U-Boot] [PATCH v2 2/5] usb: host: add error path and remove callback in ehci-generic

2017-05-14 Thread Simon Glass
Hi Patrice, On 12 May 2017 at 11:27, wrote: > From: Patrice Chotard > > Add error path to disable enabled clocks and to assert > deasserted resets > Populate the remove callback > > Signed-off-by: Patrice Chotard > --- > v2: _ split previous path 1, add error path and .remove callback > >

Re: [U-Boot] [PATCH v5 14/14] STiH410-B2260: enable USB, fastboot, reset related flags

2017-05-14 Thread Simon Glass
On 10 May 2017 at 10:09, wrote: > From: Patrice Chotard > > Signed-off-by: Patrice Chotard > --- > v5: _ remove CONFIG_USB_OHCI_STI and CONFIG_USB_EHCI_STI > _ enable CONFIG_USB_EHCI_GENERIC and CONFIG_USB_OHCI_GENERIC > > v4: _ enable CONFIG_PHY and CONFIG_STI_USB_PHY > > v3:

Re: [U-Boot] [PATCH v2 3/5] usb: host: extend generic EHCI driver with PHY

2017-05-14 Thread Simon Glass
Hi Patrice, On 12 May 2017 at 11:27, wrote: > From: Patrice Chotard > > Add support of generic PHY framework > > Signed-off-by: Patrice Chotard > --- > > v2: _ split previous path 1, add generic PHY framework > > drivers/usb/host/ehci-generic.c | 11 +++ > 1 file changed, 11 inser

Re: [U-Boot] [PATCH 3/5] x86: baytrail: secureboot: Add functions for verification of u-boot

2017-05-14 Thread Simon Glass
Hi, On 11 May 2017 at 09:14, Anatolij Gustschin wrote: > From: Markus Valentin > > Introduce functions that check the integrity of u-boot by utilising the > hashes stored in the oem-data block. U-Boot > > The verification functions get called in fsp_init() > > Signed-off-by: Markus Valentin >

Re: [U-Boot] [PATCH v5 09/14] STiH410-B2260: enable USB Host Networking

2017-05-14 Thread Simon Glass
On 10 May 2017 at 10:09, wrote: It's a good idea to always have a commit message. > From: Patrice Chotard > > Signed-off-by: Patrice Chotard > --- > > v5: _ none > v4: _ none > v3: _ none > v2: _ none > > > include/configs/stih410-b2260.h | 12 > 1 file changed,

Re: [U-Boot] [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-14 Thread Simon Glass
Hi, On 12 May 2017 at 10:06, Maxime Ripard wrote: > Hi Jernej, > > The patch content looks fine, but there's a few things that would need > to be addressed. > > On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrabec wrote: >> This commit adds support for TV (composite) output. >> >> Signed-off-

Re: [U-Boot] [PATCH v2 1/5] reset: add reset_request()

2017-05-14 Thread Simon Glass
On 12 May 2017 at 11:27, wrote: > From: Patrice Chotard > > This is needed in error path to assert previously deasserted > reset by using a saved reset_ctl reference. > > Signed-off-by: Patrice Chotard > --- > drivers/reset/reset-uclass.c | 9 + > include/reset.h | 9 +

Re: [U-Boot] [PATCH v5 03/14] mmc: sti_sdhci: Use reset framework

2017-05-14 Thread Simon Glass
Hi Patrice, On 10 May 2017 at 10:09, wrote: > From: Patrice Chotard > > Signed-off-by: Patrice Chotard > Reviewed-by: Jaehoon Chung > --- > > v5: _ none > v4: _ none > v3: _ none > v2: _ none > > > drivers/mmc/sti_sdhci.c | 31 ++- > 1 file changed

  1   2   >